From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Diego Schild Smiths <diegossmiths@fastmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, andy@kernel.org,
gregkh@linuxfoundation.org, matt@mattwardle.net,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, ~lkcamp/patches@lists.sr.ht,
koike@igalia.com
Subject: Re: [PATCH] staging: media: atomisp: Remove spaces at the start of a line
Date: Wed, 12 Aug 2026 11:14:53 +0300 [thread overview]
Message-ID: <anwrfd6dvlSS1970@ashevche-desk.local> (raw)
In-Reply-To: <20260727010826.91459-1-diegossmiths@fastmail.com>
On Sun, Jul 26, 2026 at 10:08:10PM -0300, Diego Schild Smiths wrote:
> Fix checkpatch.pl warnings:
> WARNING: please, no spaces at the start of a line
Describe the problem in plain English. Do not dump some tool output to the face
of the reader of this.
> Signed-off-by: Diego Schild Smiths <diegossmiths@fastmail.com>
While fixing indentation in the code, the Subject is wrong.
...
> void
> -ia_css_eed1_8_vmem_encode(
> - struct eed1_8_vmem_params *to,
> - const struct ia_css_eed1_8_config *from,
> - size_t size)
> +ia_css_eed1_8_vmem_encode(struct eed1_8_vmem_params *to,
> + const struct ia_css_eed1_8_config *from,
> + size_t size)
I believe there are much more of the cases.
...
Please, read lore.kernel.org linux-media@ archives against this driver to
understand why this patch is no-go.
Also, if you are in a group that is mentored, tell to the mentors to stop
looking into this driver by a newbie. This driver has much more urgent tasks
to do and it's not trivial, it also requires a real HW to be at hand to test.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-12 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 1:08 [PATCH] staging: media: atomisp: Remove spaces at the start of a line Diego Schild Smiths
2026-08-12 8:14 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anwrfd6dvlSS1970@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=diegossmiths@fastmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=koike@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=matt@mattwardle.net \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox