Re: [PATCH v2 40/44] media: ipu6: Map ipu7 firmware

[Antti Laakso <antti.laakso@linux.intel.com>]

Moi,
On Fri, Aug 21, 2026 at 09:23:32PM +0300, Sakari Ailus wrote:
> > @@ -728,18 +787,22 @@ static void ipu6_pci_remove(struct pci_dev *pdev)
> >  	struct ipu6_device *isp = pci_get_drvdata(pdev);
> >  	struct ipu6_mmu *isys_mmu = isp->isys->mmu;
> >  	struct ipu6_mmu *psys_mmu = isp->psys->mmu;
> > +	unsigned long dir;
> >  
> >  	devm_free_irq(&pdev->dev, pdev->irq, isp);
> > -	ipu6_cpd_free_pkg_dir(isp->psys);
> >  
> > -	ipu6_unmap_fw_region(isp->psys, DMA_TO_DEVICE);
> > +	dir = IS_IPU7(isp) ? DMA_BIDIRECTIONAL : DMA_TO_DEVICE;
> 
> Why is there a need for a bi-directional mapping for ipu7?
> 
In un-secure mode the mapped area includes firmware data window, thus
bi-directional. In secure mode the firmware can be read-only. I'll
adjust and limit the bi-directional mapping to un-secure mode only.

> > +	ipu6_cpd_free_pkg_dir(isp->psys);
> > +	ipu6_unmap_fw_region(isp->psys, dir);
> >  
> >  	if (isp->isys) {
> >  		ipu6_cpd_free_pkg_dir(isp->isys);
> >  		if (isp->isys->fw_sgt.nents)
> > -			ipu6_unmap_fw_region(isp->isys, DMA_TO_DEVICE);
> > +			ipu6_unmap_fw_region(isp->isys, dir);
> >  	}
> >  
> > +	vfree(isp->fw_code_region);
> > +
> >  	ipu6_buttress_exit(isp);
> >  
> >  	ipu6_bus_del_devices(pdev);
> > diff --git a/drivers/media/pci/intel/ipu6/ipu6.h b/drivers/media/pci/intel/ipu6/ipu6.h
> > index 6bef45a02c2b..a2992ffe8e3c 100644
> > --- a/drivers/media/pci/intel/ipu6/ipu6.h
> > +++ b/drivers/media/pci/intel/ipu6/ipu6.h
> > @@ -70,6 +70,7 @@ struct ipu6_device {
> >  	bool secure_mode;
> >  	u8 hw_ver;
> >  	bool bus_ready_to_probe;
> > +	u32 *fw_code_region;
> >  };
> >  
> >  #define IPU_PSYS	0
> 
> -- 
> Terveisin,
> 
> Sakari Ailus
>