From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Raushan Kumar <mitramaurya80@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: remove unnecessary return in gdc_reg_store()
Date: Mon, 17 Aug 2026 11:38:03 +0300 [thread overview]
Message-ID: <aoLIa8AaICrw_1Jk@ashevche-desk.local> (raw)
In-Reply-To: <20260815070105.124813-1-mitramaurya80@gmail.com>
On Sat, Aug 15, 2026 at 12:31:05PM +0530, Raushan Kumar wrote:
> Remove the return statement at the end of the void function
> gdc_reg_store(), as it's not needed since the function returns
> implicitly, as flagged by checkpatch.pl.
Is it the only a single leftover in the entire driver?
...
Please, read lore.kernel.org linux-media@ archives against this driver to
understand what to do with this patch.
Also, if you are in a group that is mentored, tell to the mentors to stop
looking into this driver by a newbie. This driver has much more urgent tasks
to do and it's not trivial, it also requires a real HW to be at hand to test.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-17 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 7:01 [PATCH] staging: media: atomisp: remove unnecessary return in gdc_reg_store() Raushan Kumar
2026-08-17 8:38 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoLIa8AaICrw_1Jk@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mitramaurya80@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox