From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-acpi@vger.kernel.org,
rafael@kernel.org
Subject: Re: [PATCH 3/3] media: i2c: Use ACPI_PTR() for ACPI ID tables
Date: Fri, 28 Aug 2026 15:30:10 +0200 [thread overview]
Message-ID: <apGNYsroZTTOqe4c@black.igk.intel.com> (raw)
In-Reply-To: <20260828084328.257703-4-sakari.ailus@linux.intel.com>
On Fri, Aug 28, 2026 at 11:43:28AM +0300, Sakari Ailus wrote:
> Add ACPI_PTR() to the ACPI ID tables where missing. The patch has been
> produced with the following command:
>
> git grep -lP 'acpi_match_table.*=\s*(?!ACPI_PTR)' \
> drivers/media/|while read i; do
> perl -i -pe 's/\.acpi_match_table\s*=\s*\K(\w+),/ACPI_PTR($1),/' $i;
> done
NAK.
It doesn't explain why we need that. This also inconsistent with OF type of
IDs.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-28 13:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 8:43 [PATCH 0/3] Make ACPI_PTR() use PTR_IF() Sakari Ailus
2026-08-28 8:43 ` [PATCH 1/3] media: ipu-bridge: Drop redundant ACPI_PTR() usage Sakari Ailus
2026-08-28 9:58 ` Rafael J. Wysocki (Intel)
2026-08-28 8:43 ` [PATCH 2/3] ACPI: Use PTR_IF() for ACPI_PTR() Sakari Ailus
2026-08-28 9:56 ` Rafael J. Wysocki (Intel)
2026-08-28 8:43 ` [PATCH 3/3] media: i2c: Use ACPI_PTR() for ACPI ID tables Sakari Ailus
2026-08-28 13:30 ` Andy Shevchenko [this message]
2026-08-28 15:10 ` Sakari Ailus
2026-08-28 15:22 ` Andy Shevchenko
2026-08-28 15:44 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apGNYsroZTTOqe4c@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox