Linux Media Controller development
 help / color / mirror / Atom feed
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Jai Luthra <jai.luthra@ideasonboard.com>
Cc: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	David Huang <d-huang@ti.com>, Devarsh Thakkar <devarsht@ti.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sebastian Fricke <sebastian.fricke@collabora.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] media: imagination: Fix value clamping in calculate_qp_tables()
Date: Mon, 31 Aug 2026 10:13:42 +0200	[thread overview]
Message-ID: <apU3tgw67BSgUrPe@linux.dev> (raw)
In-Reply-To: <178514849109.506511.14905916758246243206@freya>

On Mon, Jul 27, 2026 at 04:04:51PM +0530, Jai Luthra wrote:
> Quoting Thorsten Blum (2026-07-27 15:17:30)
> > The local variable val was never clamped to 1 or 255 because the return
> > value of clamp() was not used. Fix this by assigning the clamped value
> > back to val.
> > 
> > Fixes: a1e294045885 ("media: imagination: Add E5010 JPEG Encoder driver")
> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> 
> Reviewed-by: Jai Luthra <jai.luthra@ideasonboard.com>

Thank you for the review.

Could someone please pick this up?

Thanks,
Thorsten

      reply	other threads:[~2026-08-31  8:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  9:47 [PATCH RESEND] media: imagination: Fix value clamping in calculate_qp_tables() Thorsten Blum
2026-07-27 10:34 ` Jai Luthra
2026-08-31  8:13   ` Thorsten Blum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apU3tgw67BSgUrPe@linux.dev \
    --to=thorsten.blum@linux.dev \
    --cc=benjamin.gaignard@collabora.com \
    --cc=d-huang@ti.com \
    --cc=devarsht@ti.com \
    --cc=hverkuil@kernel.org \
    --cc=jai.luthra@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sebastian.fricke@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox