From: Antti Laakso <antti.laakso@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, antti.laakso@intel.com,
Lixu Zhang <lixu.zhang@intel.com>,
Miguel Vadillo <miguel.vadillo@intel.com>,
Dan Scally <dan.scally@ideasonboard.com>,
Hans de Goede <hansg@kernel.org>,
"Sapre, Sarang" <sarang.sapre@intel.com>
Subject: Re: [PATCH 1/3] media: ipu-bridge: Add ipu_bridge_get_ipu6()
Date: Wed, 9 Sep 2026 10:05:06 +0300 [thread overview]
Message-ID: <aqEFImO0tbU0YGmc@alaakso-desk> (raw)
In-Reply-To: <20260907203142.2775925-2-sakari.ailus@linux.intel.com>
Hi Sakari,
On Mon, Sep 07, 2026 at 11:31:40PM +0300, Sakari Ailus wrote:
> diff --git a/include/media/ipu-bridge.h b/include/media/ipu-bridge.h
> index 16fac765456e..373c63f98999 100644
> --- a/include/media/ipu-bridge.h
> +++ b/include/media/ipu-bridge.h
> @@ -169,12 +169,14 @@ struct ipu_bridge {
> };
>
> #if IS_ENABLED(CONFIG_IPU_BRIDGE)
> +struct pci_dev *ipu_bridge_get_ipu6(void);
> int ipu_bridge_init(struct device *dev,
> ipu_parse_sensor_fwnode_t parse_sensor_fwnode);
> int ipu_bridge_parse_ssdb(struct acpi_device *adev, struct ipu_sensor *sensor);
> int ipu_bridge_instantiate_vcm(struct device *sensor);
> #else
> /* Use a define to avoid the @parse_sensor_fwnode argument getting evaluated */
> +struct pci_dev *ipu_bridge_get_ipu6(void) { return NULL; }
I think this should be above the comment line. Should this also be
static?
> #define ipu_bridge_init(dev, parse_sensor_fwnode) (0)
> static inline int ipu_bridge_instantiate_vcm(struct device *s) { return 0; }
> #endif
> --
> 2.47.3
>
>
next prev parent reply other threads:[~2026-09-09 7:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 20:31 [PATCH 0/3] Rework IPU6 PCI table Sakari Ailus
2026-09-07 20:31 ` [PATCH 1/3] media: ipu-bridge: Add ipu_bridge_get_ipu6() Sakari Ailus
2026-09-09 7:05 ` Antti Laakso [this message]
2026-09-09 7:45 ` Sakari Ailus
2026-09-07 20:31 ` [PATCH 2/3] media: cvs: Use ipu_bridge_get_ipu6() Sakari Ailus
2026-09-07 20:31 ` [PATCH 3/3] media: ivsc: " Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqEFImO0tbU0YGmc@alaakso-desk \
--to=antti.laakso@linux.intel.com \
--cc=antti.laakso@intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=hansg@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=miguel.vadillo@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sarang.sapre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).