From: Antti Laakso <antti.laakso@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, antti.laakso@intel.com,
Lixu Zhang <lixu.zhang@intel.com>,
Miguel Vadillo <miguel.vadillo@intel.com>,
Dan Scally <dan.scally@ideasonboard.com>,
Hans de Goede <hansg@kernel.org>,
"Sapre, Sarang" <sarang.sapre@intel.com>
Subject: Re: [PATCH v2 2/3] media: cvs: Use ipu_bridge_get_ipu6()
Date: Wed, 9 Sep 2026 12:19:33 +0300 [thread overview]
Message-ID: <aqEkpWRLQFT8nhl7@alaakso-desk> (raw)
In-Reply-To: <20260909081953.3089179-3-sakari.ailus@linux.intel.com>
On Wed, Sep 09, 2026 at 11:19:51AM +0300, Sakari Ailus wrote:
> Instead of going through the PCI device ID table, use
> ipu_bridge_get_ipu6() to obtain a pointer to the IPU PCI device.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
Reviewed-by: Antti Laakso <antti.laakso@linux.intel.com>
> drivers/media/i2c/cvs/core.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/i2c/cvs/core.c b/drivers/media/i2c/cvs/core.c
> index d4a3b9c3bab1..98cadd58a075 100644
> --- a/drivers/media/i2c/cvs/core.c
> +++ b/drivers/media/i2c/cvs/core.c
> @@ -21,7 +21,6 @@
> #include <linux/workqueue.h>
>
> #include <media/ipu-bridge.h>
> -#include <media/ipu6-pci-table.h>
>
> #include "icvs.h"
>
> @@ -656,14 +655,12 @@ static int cvs_configure_dev_caps(struct icvs *ctx)
> */
> static int cvs_core_probe(struct device *dev, struct i2c_client *i2c)
> {
> - struct pci_dev *ipu = NULL;
> + struct pci_dev *ipu;
> struct icvs *ctx;
> int ret;
>
> /* Locate IPU device */
> - for (unsigned int i = 0; !ipu && ipu6_pci_tbl[i].vendor; i++)
> - ipu = pci_get_device(ipu6_pci_tbl[i].vendor,
> - ipu6_pci_tbl[i].device, NULL);
> + ipu = ipu_bridge_get_ipu6();
> for (unsigned int i = 0; !ipu && icvs_ipu7_tbl[i].vendor; i++)
> ipu = pci_get_device(icvs_ipu7_tbl[i].vendor,
> icvs_ipu7_tbl[i].device, NULL);
> --
> 2.47.3
>
>
next prev parent reply other threads:[~2026-09-09 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 8:19 [PATCH 0/3] Rework IPU6 PCI table Sakari Ailus
2026-09-09 8:19 ` [PATCH v2 1/3] media: ipu-bridge: Add ipu_bridge_get_ipu6() Sakari Ailus
2026-09-09 9:18 ` Antti Laakso
2026-09-09 14:24 ` Dan Scally
2026-09-09 8:19 ` [PATCH v2 2/3] media: cvs: Use ipu_bridge_get_ipu6() Sakari Ailus
2026-09-09 9:19 ` Antti Laakso [this message]
2026-09-09 14:24 ` Dan Scally
2026-09-09 8:19 ` [PATCH v2 3/3] media: ivsc: " Sakari Ailus
2026-09-09 9:20 ` Antti Laakso
2026-09-09 14:24 ` Dan Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqEkpWRLQFT8nhl7@alaakso-desk \
--to=antti.laakso@linux.intel.com \
--cc=antti.laakso@intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=hansg@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=miguel.vadillo@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sarang.sapre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox