From: Mehdi Djait <mehdi.djait@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, antti.laakso@linux.intel.com,
hao.yao@intel.com, dongcheng.yan@intel.com
Subject: Re: [PATCH 1/1] media: i2c: Add Omnivision ov05c10 sensor driver
Date: Wed, 30 Sep 2026 18:38:07 +0200 [thread overview]
Message-ID: <ar06tx536kSEzEK-@mdjait-mobl> (raw)
In-Reply-To: <20260929121802.2516868-1-sakari.ailus@linux.intel.com>
Hi Sakari,
On Tue, Sep 29, 2026 at 03:18:02PM +0300, Sakari Ailus wrote:
> From: Hao Yao <hao.yao@intel.com>
>
> Add a driver for the Omnivision ov05c10 camera sensor. This driver
> implements a single mode only.
[..]
> +/* This function tries to get power control resources */
> +static int ov05c10_get_pm_resources(struct device *dev)
> +{
> + struct v4l2_subdev *sd = dev_get_drvdata(dev);
> + struct ov05c10 *ov05c10 = to_ov05c10(sd);
> +
> + ov05c10->img_clk = devm_clk_get_optional(dev, NULL);
Please use the v4l2 clk helper here.
> + if (IS_ERR(ov05c10->img_clk))
> + return dev_err_probe(dev, PTR_ERR(ov05c10->img_clk),
> + "failed to get imaging clock\n");
--
Kind Regards
Mehdi Djait
next prev parent reply other threads:[~2026-09-30 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 12:18 [PATCH 1/1] media: i2c: Add Omnivision ov05c10 sensor driver Sakari Ailus
2026-09-30 12:27 ` Antti Laakso
2026-09-30 12:32 ` Sakari Ailus
2026-09-30 12:48 ` Antti Laakso
2026-09-30 16:38 ` Mehdi Djait [this message]
2026-09-30 17:28 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar06tx536kSEzEK-@mdjait-mobl \
--to=mehdi.djait@linux.intel.com \
--cc=antti.laakso@linux.intel.com \
--cc=dongcheng.yan@intel.com \
--cc=hao.yao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox