Re: [PATCH 2/2] media: ipu6: Warn if the active list isn't empty when returning buffers

[Antti Laakso <antti.laakso@linux.intel.com>]

On Tue, Sep 29, 2026 at 01:54:15PM +0300, Sakari Ailus wrote:
> The ISYS needs a reset when the active buffer list isn't empty. Warn about
> this.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/pci/intel/ipu6/ipu6-isys-queue.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> index 2608e3b91acb..c9ecda158fd1 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> @@ -423,6 +423,7 @@ static void return_buffers(struct ipu6_isys_queue *aq,
>  	struct ipu6_isys_video *av = ipu6_isys_queue_to_video(aq);
>  	struct ipu6_isys_buffer *ib;
>  	bool need_reset = false;
> +	bool first_buf = true;
>  	unsigned long flags;
>  
>  	spin_lock_irqsave(&aq->lock, flags);
> @@ -448,6 +449,12 @@ static void return_buffers(struct ipu6_isys_queue *aq,
>  	while (!list_empty(&aq->active)) {
>  		struct vb2_buffer *vb;
>  
> +		if (first_buf) {
> +			dev_warn(&av->isys->adev->auxdev.dev,
> +				 "buffer list not empty, needs isys reset\n");
> +			first_buf = false;
> +		}

Could the warning be in the end of the function, in need_reset block. We
could save one local variable too.

> +
>  		ib = list_first_entry(&aq->active, struct ipu6_isys_buffer,
>  				      head);
>  		vb = ipu6_isys_buffer_to_vb2_buffer(ib);
> -- 
> 2.47.3
>