From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E077236453 for ; Tue, 6 Oct 2026 02:19:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791253157; cv=none; b=LHJYi/8/VnWm/43Y017p3wQlV9WpnLGeQgV7n1vNuGmjAXtjUCfb6h3/1ujIScKKD/apPwaUNQ0OLTudz+QuprkYl/KjZJnZPAmY210a3xdU/sIS21ccHEIcXN6V2UwcG89OFd1yIDrKT1ffLiV9X/iPb5TiNTUDQirzbHVB9TQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791253157; c=relaxed/simple; bh=BmaEHSA4Sc5Ix5xoHHxmdmGUN9bsHAfm5IqRRWj5dtQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=VxA7m17mKJhclLe2Eu0h2ay7IAN6DV4BnJQUJf5tWmVY3Vb8kZwFsLvh9SLu24h8Y6OVFD0vb0+ASG2bqSgX+UBaCSjYnOFdG2Tib/HzCY1TaZNmSjb2peaH1lpGPFtGAx3BMyZVMKasxDi2LPunP3vX3utCDBKy8thMBdWTbgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ji0YnFNQ; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ji0YnFNQ" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-3115c4451c8so1632220eec.1 for ; Mon, 05 Oct 2026 19:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791253154; x=1791857954; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=goSUC8rOLbR1QanLKh3MMf1EmDUtSXdm+TglUr6s/zM=; b=ji0YnFNQKiH/7x9YSr9W2x55fxqgEZImVE5KwYUUe4LreOYV7redWibTtcYCvNAf9W gNkq+qWf4EqFRp4f2mkbAbMw/qD/fvUu/unjE0tMmMZGjurVVIoHLhzfSJMl/13/PpGT 8HO6aX0FFdqNvyMuKVJQlCZAQWYXOgJDeJH9OqEjy8B5hIBLqCdW5WxeUZwC+bDlBLZM 3XQzEfkkWzwDZM2NH9mULpPimxrmbjbr6XdhKcO7OvxpCwAWn6g3jhBtTSZcBqvCRXpL ehFFywwf+nKp/mNiMRK3e9y0nRFjrufdL/JufKMMirD7wdrtRafftqnHsf37pIsZ6DK5 RrdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791253154; x=1791857954; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=goSUC8rOLbR1QanLKh3MMf1EmDUtSXdm+TglUr6s/zM=; b=09wP7b4YLrVfJ1ItxMz/dLKuJwq7DHZPubEIic5oYrBZqCekpLzmgls68IepYYcEkz Klt9msCh/ygRoJpDhP1MHut3KoS7Ogcc7tK0TbG2HcSKT6SukONiRWih1Q5b6ofeWofU RCnWGPFBUvzYzORN5Ifrpl+ktmQcaHeQEtdACQU4UrdEEauV5WDu56sxPxzm96wofQCg wdqFzWzy2ubVb0JY3rlj9y+rNwe82XY1atyq7Go7tSg/u3TexfmFn5RJmu+KTmzAk/DL uj+1NUOuFUjHc3AAEa6fWFhFwFK7mngxRp/GQlMxBdG/tfzQ9IBgAjEXjnlFjSTdned/ eaoA== X-Forwarded-Encrypted: i=1; AKwUvBwXqfovP74+6TjFJkXwqntTfkX8HyMsah3Qn2JlsIc5Ghv5VRbkGUTYT+dQBTEmrqupGz2MPs7buUyeXg==@vger.kernel.org X-Gm-Message-State: AFq9FYL394Ic4ulM19xYN2ViIDUIiQTjy5JVnaJmwKw8U+IthlotSDng GDmIv7TEVdS1eLfvQ3rFI6iqLgK4HLRGuYO86o6aV4wp7pcYUk4MQshq X-Gm-Gg: AYBFou3Avb5QxSTrIu6pUCUL3WUhEYq5gk+wQj6/KrQWMhqbeWCUQ/KTUPMLw+h/bQa lI8ckM8MF64fYy+3xdHMlSdmW6OcR8Li+etJy9pFDtzPgXmfh1YK74PdddrLW3zNdThC6OUgQ0k GkT39iRuGRfhp7zhpuHu2csKk/JqyYCt9DHqWX90EyYklcY/hpN/MXfZeRTho+Yg+fl8dlQ9Pml YvuytMbDeLuJH6xLwJoTKABis619xWZdlKmXmx2a9LLD1M/J6GW2XGOT9Gf61r4gwWLLqU+pIl4 mtrqF/OHl+eAhuGjKr1rq5jBMIqUKor+tIvagbC7QQoVLEjNXQUrCnH+I8RUCuEAlpYDdUrl8XF FwaTX3xeMAz+hpNl+8uOGOPlCTeGln0wWt3jsAwhlEGIugY7900JJbNre4AvZPHMaw6HhfXlvi6 0b5Ulih8Lp4E1/F/E1bIdMY+/uNwusiCChqTikg1L4DIIg4wKQvoOcQUcZt1pVdp8WZv6iDHZ2 X-Received: by 2002:a05:7300:e9d7:10b0:351:2200:1cde with SMTP id 5a478bee46e88-35145200a8emr1646887eec.8.1791253153514; Mon, 05 Oct 2026 19:19:13 -0700 (PDT) Received: from arlo ([2607:fb90:742b:7290:cb9a:9a47:ea69:3868]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-35146a5b004sm3016308eec.18.2026.10.05.19.19.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2026 19:19:12 -0700 (PDT) Date: Mon, 5 Oct 2026 16:19:08 -1000 From: Raiden Horner To: slongerbeam@gmail.com, p.zabel@pengutronix.de, Frank.Li@nxp.com, mchehab@kernel.org, gregkh@linuxfoundation.org Cc: imx@lists.linux.dev, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: media: imx: Fixed depricated implementations of 80 char limit & open parentheses line ending Message-ID: Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Fixed open parentheses line ending issues & readability. I presume this syntax was there to meet the old 80 char limit, and double checked the changelogs to make sure this was not already submitted. If not I apologize, I am still getting used to using the indexing system. Signed-off-by: Raiden Horner --- Changes in v2: - Fixed line wrapping in the commit message to adhere to 75 columns drivers/staging/media/imx/imx-ic-prpencvf.c | 13 +++-- drivers/staging/media/imx/imx-media-csi.c | 4 +- .../staging/media/imx/imx-media-dev-common.c | 2 +- drivers/staging/media/imx/imx-media-fim.c | 5 +- drivers/staging/media/imx/imx-media-utils.c | 54 +++++-------------- 5 files changed, 24 insertions(+), 54 deletions(-) diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c b/drivers/staging/media/imx/imx-ic-prpencvf.c index 77360bfe081a..69f5ca280454 100644 --- a/drivers/staging/media/imx/imx-ic-prpencvf.c +++ b/drivers/staging/media/imx/imx-ic-prpencvf.c @@ -704,11 +704,11 @@ static int prp_start(struct prp_priv *priv) } if (ipu_rot_mode_is_irt(priv->rot_mode)) - priv->eof_irq = ipu_idmac_channel_irq( - ic_priv->ipu, priv->rot_out_ch, IPU_IRQ_EOF); + priv->eof_irq = ipu_idmac_channel_irq(ic_priv->ipu, + priv->rot_out_ch, IPU_IRQ_EOF); else - priv->eof_irq = ipu_idmac_channel_irq( - ic_priv->ipu, priv->out_ch, IPU_IRQ_EOF); + priv->eof_irq = ipu_idmac_channel_irq(ic_priv->ipu, + priv->out_ch, IPU_IRQ_EOF); ret = devm_request_irq(ic_priv->ipu_dev, priv->eof_irq, prp_eof_interrupt, 0, @@ -761,9 +761,8 @@ static void prp_stop(struct prp_priv *priv) /* * and then wait for interrupt handler to mark completion. */ - ret = wait_for_completion_timeout( - &priv->last_eof_comp, - msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT)); + ret = wait_for_completion_timeout(&priv->last_eof_comp, + msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT)); if (ret == 0) v4l2_warn(&ic_priv->sd, "wait last EOF timeout\n"); diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index ef22a083f8eb..4eb621ddda25 100644 --- a/drivers/staging/media/imx/imx-media-csi.c +++ b/drivers/staging/media/imx/imx-media-csi.c @@ -679,8 +679,8 @@ static void csi_idmac_wait_last_eof(struct csi_priv *priv) /* * and then wait for interrupt handler to mark completion. */ - ret = wait_for_completion_timeout( - &priv->last_eof_comp, msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT)); + ret = wait_for_completion_timeout(&priv->last_eof_comp, + msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT)); if (ret == 0) v4l2_warn(&priv->sd, "wait last EOF timeout\n"); } diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c index 0d0ee8627a2d..be445df93518 100644 --- a/drivers/staging/media/imx/imx-media-dev-common.c +++ b/drivers/staging/media/imx/imx-media-dev-common.c @@ -377,7 +377,7 @@ struct imx_media_dev *imx_media_dev_init(struct device *dev, EXPORT_SYMBOL_GPL(imx_media_dev_init); int imx_media_dev_notifier_register(struct imx_media_dev *imxmd, - const struct v4l2_async_notifier_operations *ops) + const struct v4l2_async_notifier_operations *ops) { int ret; diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c index ccbc0371fba2..9e9bacf9dcec 100644 --- a/drivers/staging/media/imx/imx-media-fim.c +++ b/drivers/staging/media/imx/imx-media-fim.c @@ -205,9 +205,8 @@ static void fim_acquire_first_ts(struct imx_media_fim *fim) if (!fim->enabled || fim->num_skip > 0) return; - ret = wait_for_completion_timeout( - &fim->icap_first_event, - msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT)); + ret = wait_for_completion_timeout(&fim->icap_first_event, + msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT)); if (ret == 0) v4l2_warn(fim->sd, "wait first icap event timeout\n"); } diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c index f119477cac6b..00cd391b5ff7 100644 --- a/drivers/staging/media/imx/imx-media-utils.c +++ b/drivers/staging/media/imx/imx-media-utils.c @@ -16,18 +16,12 @@ static const struct imx_media_pixfmt pixel_formats[] = { /*** YUV formats start here ***/ { .fourcc = V4L2_PIX_FMT_UYVY, - .codes = IMX_BUS_FMTS( - MEDIA_BUS_FMT_UYVY8_2X8, - MEDIA_BUS_FMT_UYVY8_1X16 - ), + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_UYVY8_2X8, MEDIA_BUS_FMT_UYVY8_1X16), .cs = IPUV3_COLORSPACE_YUV, .bpp = 16, }, { .fourcc = V4L2_PIX_FMT_YUYV, - .codes = IMX_BUS_FMTS( - MEDIA_BUS_FMT_YUYV8_2X8, - MEDIA_BUS_FMT_YUYV8_1X16 - ), + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_YUYV8_2X8, MEDIA_BUS_FMT_YUYV8_1X16), .cs = IPUV3_COLORSPACE_YUV, .bpp = 16, }, { @@ -71,10 +65,7 @@ static const struct imx_media_pixfmt pixel_formats[] = { .cycles = 2, }, { .fourcc = V4L2_PIX_FMT_RGB24, - .codes = IMX_BUS_FMTS( - MEDIA_BUS_FMT_RGB888_1X24, - MEDIA_BUS_FMT_RGB888_2X12_LE - ), + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_RGB888_2X12_LE), .cs = IPUV3_COLORSPACE_RGB, .bpp = 24, }, { @@ -132,55 +123,36 @@ static const struct imx_media_pixfmt pixel_formats[] = { .bayer = true, }, { .fourcc = V4L2_PIX_FMT_SBGGR16, - .codes = IMX_BUS_FMTS( - MEDIA_BUS_FMT_SBGGR10_1X10, - MEDIA_BUS_FMT_SBGGR12_1X12, - MEDIA_BUS_FMT_SBGGR14_1X14, - MEDIA_BUS_FMT_SBGGR16_1X16 - ), + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SBGGR10_1X10, MEDIA_BUS_FMT_SBGGR12_1X12, + MEDIA_BUS_FMT_SBGGR14_1X14, MEDIA_BUS_FMT_SBGGR16_1X16), .cs = IPUV3_COLORSPACE_RGB, .bpp = 16, .bayer = true, }, { .fourcc = V4L2_PIX_FMT_SGBRG16, - .codes = IMX_BUS_FMTS( - MEDIA_BUS_FMT_SGBRG10_1X10, - MEDIA_BUS_FMT_SGBRG12_1X12, - MEDIA_BUS_FMT_SGBRG14_1X14, - MEDIA_BUS_FMT_SGBRG16_1X16 - ), + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGBRG10_1X10, MEDIA_BUS_FMT_SGBRG12_1X12, + MEDIA_BUS_FMT_SGBRG14_1X14, MEDIA_BUS_FMT_SGBRG16_1X16), .cs = IPUV3_COLORSPACE_RGB, .bpp = 16, .bayer = true, }, { .fourcc = V4L2_PIX_FMT_SGRBG16, - .codes = IMX_BUS_FMTS( - MEDIA_BUS_FMT_SGRBG10_1X10, - MEDIA_BUS_FMT_SGRBG12_1X12, - MEDIA_BUS_FMT_SGRBG14_1X14, - MEDIA_BUS_FMT_SGRBG16_1X16 - ), + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SGRBG12_1X12, + MEDIA_BUS_FMT_SGRBG14_1X14, MEDIA_BUS_FMT_SGRBG16_1X16), .cs = IPUV3_COLORSPACE_RGB, .bpp = 16, .bayer = true, }, { .fourcc = V4L2_PIX_FMT_SRGGB16, - .codes = IMX_BUS_FMTS( - MEDIA_BUS_FMT_SRGGB10_1X10, - MEDIA_BUS_FMT_SRGGB12_1X12, - MEDIA_BUS_FMT_SRGGB14_1X14, - MEDIA_BUS_FMT_SRGGB16_1X16 - ), + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SRGGB10_1X10, MEDIA_BUS_FMT_SRGGB12_1X12, + MEDIA_BUS_FMT_SRGGB14_1X14, MEDIA_BUS_FMT_SRGGB16_1X16), .cs = IPUV3_COLORSPACE_RGB, .bpp = 16, .bayer = true, }, { .fourcc = V4L2_PIX_FMT_GREY, - .codes = IMX_BUS_FMTS( - MEDIA_BUS_FMT_Y8_1X8, - MEDIA_BUS_FMT_Y10_1X10, - MEDIA_BUS_FMT_Y12_1X12 - ), + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_Y8_1X8, MEDIA_BUS_FMT_Y10_1X10, + MEDIA_BUS_FMT_Y12_1X12), .cs = IPUV3_COLORSPACE_RGB, .bpp = 8, .bayer = true, -- 2.47.3