Re: [PATCH 3/3] media: i2c: ov5675: Add the OVTI5678 RGB-IR variant

["Uwe Kleine-König" <ukleinek@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

Hello Andy,

On Wed, Oct 21, 2026 at 08:57:58AM +0300, Andy Shevchenko wrote:
> On Tue, Oct 20, 2026 at 3:13 PM Uwe Kleine-König <ukleinek@kernel.org> wrote:
> > On Tue, Oct 20, 2026 at 11:57:34AM +0300, Andy Shevchenko wrote:
> > > On Tue, Oct 20, 2026 at 11:42:07AM +0300, Sakari Ailus wrote:
> > > > On Tue, Oct 20, 2026 at 09:50:01AM +0800, Alexander Patrakov wrote:
> 
> ...
> 
> > > > >  #include <linux/gpio/consumer.h>
> > > > >  #include <linux/i2c.h>
> > > > > +#include <linux/mod_devicetable.h>
> > > >
> > > > #include <linux/device-id/acpi.h>
> > >
> > > No, this has to be part of i2c.h on par with device-id/of.h
> >
> > Well, <linux/i2c.h> includes <linux/acpi.h> which in turn includes
> > <linux/device-id/acpi.h>, so <linux/i2c.h> already provides
> > acpi_device_id.
> >
> > > Uwe, can we get this fixed, please?
> >
> > With the above said, there is nothing to fix, is there?
> 
> I believe it's just a coincidence. We need to include both explicitly
> (I mean -id/of.h and -id/acpi.h). Do spi.h and platform_device.h
> include acpi.h as well?
> 
> TL;DR: we have an inconsistency behind this, so it's definitely
> something to address.

IMHO the transitive include is good enough, so I won't address your
concern. But if you consider it important, I also won't (try to) stop
you.

Best regards
Uwe


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]