Re: [PATCH v4 4/5] arm64: dts: renesas: r9a09g057: Add IVC and ISP nodes

[Jacopo Mondi <jacopo.mondi@ideasonboard.com>]

On Wed, Oct 28, 2026 at 10:47:37AM +0100, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Wed, 28 Oct 2026 at 10:28, Jacopo Mondi
> <jacopo.mondi@ideasonboard.com> wrote:
> > On Wed, Oct 28, 2026 at 09:38:05AM +0100, Linus Walleij wrote:
> > > On Tue, Oct 27, 2026 at 7:39 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > The driver uses Runtime PM, but I see no calls to
> > > > pm_runtime_resume_and_get()?
> > >
> > > It gets grabbed in *params.c and *stats.c:
> >
> > pm_runtime_resume_and_get() is called in the .start_streaming handler
> > for all video nodes (capture, params and stats)
>
> OK, but not from .probe(), which does hardware initialization
> before that?

The driver doesn't depend or select PM (to be honest, I don't see why
we would run without PM these days, but that's how things are the
moment).

So the peripheral is manually powered up and pm_runtime enabled in
'active' state

static int mali_c55_probe(struct platform_device *pdev)
{

	ret = __mali_c55_power_on(mali_c55);
	if (ret)
		return dev_err_probe(dev, ret, "failed to power on\n");

	ret = mali_c55_check_hwcfg(mali_c55);
	if (ret)
		goto err_power_off;

	ret = mali_c55_init_context(mali_c55, res);
	if (ret)
		goto err_power_off;

	mali_c55->media_dev.dev = dev;

	pm_runtime_set_autosuspend_delay(&pdev->dev, 2000);
	pm_runtime_use_autosuspend(&pdev->dev);
	pm_runtime_set_active(&pdev->dev);
	pm_runtime_enable(&pdev->dev);

If that wasn't the case, the driver would have failed to identify the
peripheral and would have bailed out in mali_c55_check_hwcfg()



>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds