From: Sean Young <sean@mess.org>
To: YuanZhe Liu <25031212351@stu.xidian.edu.cn>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"David Härdeman" <david@hardeman.nu>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
"Bin Yu" <byu@xidian.edu.cn>,
"Cheng Wen" <wencheng@xidian.edu.cn>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>
Subject: Re: [PATCH v2] media: rc: fix use-after-free of rc_map.name on register error path
Date: Fri, 30 Oct 2026 10:06:52 +0000 [thread overview]
Message-ID: <auRsPM9YO4aXd8qL@extorris.mess.org> (raw)
In-Reply-To: <20261030.pref-04.ec83d43911ee476d@stu.xidian.edu.cn>
On Fri, Oct 30, 2026 at 02:00:57PM +0800, YuanZhe Liu wrote:
> Hi Mauro,
>
> I am copying this address for visibility.
>
> [PATCH v2] media: rc: fix use-after-free of rc_map.name on register
> error path
This looks good on first pass, I need to review it.
> The remaining issue is a uevent racing with keymap cleanup while
> registered is still true. The proposed approach is to clear registered
> before freeing the keymap.
The problem with the current approach is that the remove uevent is
suppressed if it depends on registered. We need the uevent to always
be delivered, yet the uevent contains driver strings.
> The follow-up linked below describes the remaining issue and the changes
> needed for the current tree. I'd appreciate your feedback on the
> proposed approach.
>
> Discussion:
> https://lore.kernel.org/r/20261027021718.14264-1-25031212351@stu.xidian.edu.cn
>
> Original submission:
> https://lore.kernel.org/r/20261027014144.9144-1-25031212351@stu.xidian.edu.cn
>
> Thanks,
> YuanZhe
Thanks,
Sean
next prev parent reply other threads:[~2026-10-30 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 1:41 [PATCH v2] media: rc: fix use-after-free of rc_map.name on register error path YuanZhe Liu
2026-10-27 2:17 ` YuanZhe Liu
2026-10-30 6:00 ` YuanZhe Liu
2026-10-30 10:06 ` Sean Young [this message]
2026-10-30 13:05 ` YuanZhe Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auRsPM9YO4aXd8qL@extorris.mess.org \
--to=sean@mess.org \
--cc=25031212351@stu.xidian.edu.cn \
--cc=byu@xidian.edu.cn \
--cc=david@hardeman.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=wencheng@xidian.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox