From: Mehdi Djait <mehdi.djait@linux.intel.com>
To: Michal Simek <michal.simek@amd.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@amd.com,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"moderated list:ARM/ZYNQ ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:XILINX VIDEO IP CORES" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v2] media: xilinx: vip: Make use of the devm_clk_get_enabled()
Date: Wed, 18 Nov 2026 12:32:24 +0100 [thread overview]
Message-ID: <av2MP0VlOKC5RUXk@mdjait-mobl> (raw)
In-Reply-To: <8c5500e70fcd2b4da35e985b9f8a976afa1991b0.1794999782.git.michal.simek@amd.com>
Hi Michal,
On Wed, Nov 18, 2026 at 12:03:04PM +0100, Michal Simek wrote:
> There is missing return value check from clk_prepare_enable(). Fix it by
> using devm_clk_get_enabled() macro.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
[..]
> void xvip_cleanup_resources(struct xvip_device *xvip)
> {
> - clk_disable_unprepare(xvip->clk);
so the xvip_cleanup_resources() is empty after removing the
clk_disable_unprepare() call.
It is also called in xilinx-tpg.c and xilinx-vtc.c
> }
> EXPORT_SYMBOL_GPL(xvip_cleanup_resources);
--
Kind Regards
Mehdi Djait
next prev parent reply other threads:[~2026-11-18 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 11:03 [PATCH v2] media: xilinx: vip: Make use of the devm_clk_get_enabled() Michal Simek
2026-11-18 11:32 ` Mehdi Djait [this message]
2026-11-18 11:57 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av2MP0VlOKC5RUXk@mdjait-mobl \
--to=mehdi.djait@linux.intel.com \
--cc=git@amd.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=michal.simek@amd.com \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox