From: Dan Carpenter <error27@gmail.com>
To: Avishek Chaulagain <chaulagainavishek14@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] media: atomisp: Remove unused get_sp_code_addr()
Date: Mon, 16 Nov 2026 15:38:46 +0300 [thread overview]
Message-ID: <avr5VoP2Xtc3Chpe@stanley.mountain> (raw)
In-Reply-To: <20261116120703.6681-2-chaulagainavishek14@gmail.com>
On Mon, Nov 16, 2026 at 12:06:57PM +0000, Avishek Chaulagain wrote:
> get_sp_code_addr() has no callers anywhere in the tree. Remove the
> unused function and its declaration.
>
> Signed-off-by: Avishek Chaulagain <chaulagainavishek14@gmail.com>
> ---
> .../atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h | 1 -
> .../staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 5 -----
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h b/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
> index 3cd69284f..e00308818 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
> +++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h
> @@ -26,7 +26,6 @@ typedef struct {
> } ia_css_spctrl_cfg;
>
> /* Get the code addr in DDR of SP */
> -ia_css_ptr get_sp_code_addr(sp_ID_t sp_id);
Dangling comment.
regards,
dan carpenter
next prev parent reply other threads:[~2026-11-16 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 12:06 [PATCH 1/3] media: atomisp: Remove unused any_virq_signal() Avishek Chaulagain
2026-11-16 12:06 ` [PATCH 2/3] media: atomisp: Remove unused get_sp_code_addr() Avishek Chaulagain
2026-11-16 12:38 ` Dan Carpenter [this message]
2026-11-16 12:06 ` [PATCH 3/3] media: atomisp: Remove unused hmm_flush() Avishek Chaulagain
2026-11-16 12:38 ` [PATCH 1/3] media: atomisp: Remove unused any_virq_signal() Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avr5VoP2Xtc3Chpe@stanley.mountain \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=chaulagainavishek14@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox