Linux Media Controller development
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: "Jacopo Mondi" <jacopo.mondi+renesas@ideasonboard.com>,
	"Jai Luthra" <jai.luthra+renesas@ideasonboard.com>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Barnabás Pőcze" <barnabas.pocze+renesas@ideasonboard.com>,
	"Yusuke Goda" <yusuke.goda.sx@renesas.com>,
	"Yuya Hamamachi" <yuya.hamamachi.sx@renesas.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 2/4] media: rcar-isp: ispcore: Update image data flush settings
Date: Mon, 16 Nov 2026 13:21:24 +0100	[thread overview]
Message-ID: <avrtuJWtbEdnoQqu@zed> (raw)
In-Reply-To: <20261114-v4l2-add-nv12-v2-2-a3f5ecfd48d6@ragnatech.se>


On Sat, Nov 14, 2026 at 08:55:17PM +0100, Niklas Söderlund wrote:
> Later versions of the datasheet have an updated chapter on how the image

I'm looking at revision R19UH0259EJ0040 Rev.0.40
Are we on the same page ?

> out flush settings depends on proper stride settings. Update the bytes
> per line calculation and flush out settings to match the datasheet
> clarification.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> * Changes since v1
> - Fix spelling of capture.
> ---
>  drivers/media/platform/renesas/rcar-isp/core-io.c | 32 +++++++++++++++++++----
>  drivers/media/platform/renesas/rcar-isp/core.c    |  2 +-
>  2 files changed, 28 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rcar-isp/core-io.c b/drivers/media/platform/renesas/rcar-isp/core-io.c
> index cc538e984aa1..1c63194f6455 100644
> --- a/drivers/media/platform/renesas/rcar-isp/core-io.c
> +++ b/drivers/media/platform/renesas/rcar-isp/core-io.c
> @@ -727,12 +727,34 @@ static const struct v4l2_pix_format_mplane risp_io_capture_default_format = {
>  	.num_planes = 1,
>  	.plane_fmt = {
>  		[0] = {
> -			.bytesperline = ALIGN(1920 * 4, 256),
> -			.sizeimage = ALIGN(1920 * 4, 256) * 1080,
> +			.bytesperline = 15872, /* See risp_io_capture_bytesperline() */

not looking into the calculations yet, I just wonder if this value
can't be calculated (by calling risp_io_capture_bytesperline())
instead of hard-coded ?

> +			.sizeimage = 15872 * 1080,
>  		},
>  	},
>  };
>
> +static unsigned int risp_io_capture_bytesperline(unsigned int width, unsigned int bpp)
> +{
> +	/*
> +	 * The datasheet specifies strict alignment and padding rules to be able
> +	 * to flush out all the pixels. Each line must be 256 byte aligned and

Interestingly I read:

"When using flush out setting"

do you know if flush out has to be used unconditionally ?

> +	 * at the end of the frame at least one extra line of space must be
> +	 * available.
> +	 *
> +	 * As we can't extend the buffer with one extra line we need to work
> +	 * with stride setting to satisfy both constraints. Fortunately the
> +	 * datasheet gives us a calculation for this.
> +	 *
> +	 *   FLUSH[pixels] = ALIGN(WIDTH[pixels], 256)
> +	 *
> +	 *   PADDING[bytes] = ALIGN(BPP[bytes] * WIDTH[pixels], 256) - BPP[bytes] * WIDTH[pixels] + BPP[bytes] * FLUSH[pixels]
> +	 */
> +	unsigned int data = bpp * width;
> +	unsigned int padding = ALIGN(data, 256) - data + bpp * ALIGN(width, 256);

isn't this the additional space for a whole line where flush data
end up being written to ?

Assume 'data' is already 256-aligned, then we can remove
`ALIGN(data, 256) - data` from the calculation of padding.

What's left is

        padding = bpp * ALIGN(width, 256)

which is a full line length in bytes aligned to 256 pixels

> +
> +	return ALIGN(data + padding, 256);

Then here you add to the line length in bytes (`data`) the padding
(which is a full line itself).

As I presume this works when tested, where did I get lost ?

... a few minutes later ...

And now I've read Barnabas' comment on v1. We're here basically
doubling the line length then ?

I think the comment here is a bit mis-leading as I thought the idea
was to add to each line stride enough space to accommodate an additional
line at the end of the full frame.

And to get back to your reply to Barnabas in v1, I'm not sure I
understand why the additional padding lines (if unconditionally
needed) can't be added to sizeimage ?

> +}
> +
>  static void risp_io_capture_try_format(struct rcar_isp_core_io *io,
>  				       struct v4l2_pix_format_mplane *pix)
>  {
> @@ -749,16 +771,16 @@ static void risp_io_capture_try_format(struct rcar_isp_core_io *io,
>  	case V4L2_PIX_FMT_NV16M:
>  		pix->quantization = V4L2_QUANTIZATION_LIM_RANGE;
>  		pix->num_planes = 2;
> -		pix->plane_fmt[0].bytesperline = ALIGN(pix->width, 256);
> +		pix->plane_fmt[0].bytesperline = risp_io_capture_bytesperline(pix->width, 1);
>  		pix->plane_fmt[0].sizeimage = pix->plane_fmt[0].bytesperline * pix->height;
> -		pix->plane_fmt[1].bytesperline = ALIGN(pix->width, 256);
> +		pix->plane_fmt[1].bytesperline = pix->plane_fmt[0].bytesperline;
>  		pix->plane_fmt[1].sizeimage = pix->plane_fmt[1].bytesperline * pix->height;
>  		break;
>  	default:
>  		pix->pixelformat = V4L2_PIX_FMT_XBGR32;
>  		pix->quantization = V4L2_QUANTIZATION_FULL_RANGE;
>  		pix->num_planes = 1;
> -		pix->plane_fmt[0].bytesperline = ALIGN(pix->width * 4, 256);
> +		pix->plane_fmt[0].bytesperline = risp_io_capture_bytesperline(pix->width, 4);
>  		pix->plane_fmt[0].sizeimage = pix->plane_fmt[0].bytesperline * pix->height;
>  		break;
>  	}
> diff --git a/drivers/media/platform/renesas/rcar-isp/core.c b/drivers/media/platform/renesas/rcar-isp/core.c
> index 586a5adbedfa..8908496c734e 100644
> --- a/drivers/media/platform/renesas/rcar-isp/core.c
> +++ b/drivers/media/platform/renesas/rcar-isp/core.c
> @@ -398,7 +398,7 @@ static int risp_core_config_output(struct rcar_isp_core *core,
>
>  	/* Set image out flush EOF. */
>  	risp_core_write(core, ISPCORE_DMA_IMAGE_FLUSH_OUT_REG(index),
> -			pix->plane_fmt[0].bytesperline <<
> +			ALIGN(pix->width, 256) <<
>  			ISPCORE_DMA_IMAGE_FLUSH_OUT_PADDING_PIXEL_EOF_SHIFT);
>
>  	/* Enable DMA and set burst length. */
>
> --
> 2.55.0
>
>

  reply	other threads:[~2026-11-16 12:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 19:55 [PATCH v2 0/4] media: rcar-isp: Add NV12M support and fix stride Niklas Söderlund
2026-11-14 19:55 ` [PATCH v2 1/4] media: rcar-isp: ispcore: Honour requested bytesperline on RAW input Niklas Söderlund
2026-11-16 11:21   ` Jacopo Mondi
2026-11-14 19:55 ` [PATCH v2 2/4] media: rcar-isp: ispcore: Update image data flush settings Niklas Söderlund
2026-11-16 12:21   ` Jacopo Mondi [this message]
2026-11-14 19:55 ` [PATCH v2 3/4] media: rcar-isp: ispcore: Look at number of planes when programming Niklas Söderlund
2026-11-14 19:55 ` [PATCH v2 4/4] media: rcar-isp: ispcore: Add NV12M support Niklas Söderlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avrtuJWtbEdnoQqu@zed \
    --to=jacopo.mondi@ideasonboard.com \
    --cc=barnabas.pocze+renesas@ideasonboard.com \
    --cc=geert+renesas@glider.be \
    --cc=jacopo.mondi+renesas@ideasonboard.com \
    --cc=jai.luthra+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=yusuke.goda.sx@renesas.com \
    --cc=yuya.hamamachi.sx@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox