Linux Media Controller development
 help / color / mirror / Atom feed
From: Mehdi Djait <mehdi.djait@linux.intel.com>
To: Michael Riesch <michael.riesch@collabora.com>
Cc: linux-media@vger.kernel.org, paul.elder@ideasonboard.com,
	 daniel@makrotopia.org, linux-rockchip@lists.infradead.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v1 1/2] media: rockchip: rkcif: Don't reset the hardware in runtime suspend
Date: Tue, 17 Nov 2026 10:09:38 +0100	[thread overview]
Message-ID: <avwZpcF8fti2vVI9@mdjait-mobl> (raw)
In-Reply-To: <avsBed-E2RPJnZ6k@mdjait-mobl>

On Mon, Nov 16, 2026 at 03:30:33PM +0100, Mehdi Djait wrote:
> Hi Michael,
> 
> On Mon, Nov 16, 2026 at 11:58:35AM +0100, Michael Riesch wrote:
> > Hi Mehdi,
> > 
> > On 11/12/26 19:32, Mehdi Djait wrote:
> > > The reset in the runtime suspend also resets the VICAP IOMMU.
> > > 
> > > When the IOMMU driver accesses the IOMMU registers inside the delay window
> > > between the assert and deassert, e.g. in rk_iommu_zap_lines() to shootdown
> > > IOTLB entries, the system hangs.
> > > 
> > > Drop the reset and the now unused reset control.
> > 
> > I agree that the current situation is nothing more than a crude hack
> > that happened to work in most cases. But I doubt simply removing the
> > reset is the correct solution. Recently, I saw some downstream patch
> > that makes the reset a shared one, which seems like the right thing to
> > do here. What would you think about that?
> 
> Do you have a link for these patches ?
> 
> I also agree that this patch will not be the solution that will go in
> but the situation needs to change.
> 
> The VICAP_GLB_CTRL register does expose this:
> reset the VICAP(except MMU/AXI MASTER/REG FILE)
> 
> The Rockchip-bsp kernel exports the disable and enable functions of the
> iommu driver and calls them in the rkcif driver, see:
> https://github.com/rockchip-linux/kernel/blob/develop-6.1/drivers/media/platform/rockchip/cif/capture.c#L7269
> 

I mean, I of course don't think this is a solution to be considered, but
this is what I found for now..

--
Kind regards
Mehdi Djait

  reply	other threads:[~2026-11-17  9:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 18:32 [PATCH v1 0/2] media: rockchip: rkcif: Fix a system hang and validate the pixel format Mehdi Djait
2026-11-12 18:32 ` [PATCH v1 1/2] media: rockchip: rkcif: Don't reset the hardware in runtime suspend Mehdi Djait
2026-11-16 10:58   ` Michael Riesch
2026-11-16 14:30     ` Mehdi Djait
2026-11-17  9:09       ` Mehdi Djait [this message]
2026-11-12 18:32 ` [PATCH v1 2/2] media: rockchip: rkcif: Validate the pixel format against the media bus code Mehdi Djait
2026-11-16 10:55   ` Michael Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avwZpcF8fti2vVI9@mdjait-mobl \
    --to=mehdi.djait@linux.intel.com \
    --cc=daniel@makrotopia.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michael.riesch@collabora.com \
    --cc=paul.elder@ideasonboard.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox