From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FDAEC43331 for ; Thu, 2 Apr 2020 13:59:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 711622063A for ; Thu, 2 Apr 2020 13:59:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732625AbgDBN7h (ORCPT ); Thu, 2 Apr 2020 09:59:37 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:43502 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727412AbgDBN7h (ORCPT ); Thu, 2 Apr 2020 09:59:37 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: koike) with ESMTPSA id BE597280125 Subject: Re: [PATCH 3/3] rkisp1: Fix wrong PHY config dependency To: Ezequiel Garcia , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kernel@collabora.com, Hans Verkuil References: <20200401213721.24173-1-ezequiel@collabora.com> <20200401213721.24173-4-ezequiel@collabora.com> From: Helen Koike Message-ID: Date: Thu, 2 Apr 2020 10:59:29 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200401213721.24173-4-ezequiel@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 4/1/20 6:37 PM, Ezequiel Garcia wrote: > Instead of depending on the Rockchip PHY driver the ISP driver > should really depend on CONFIG_GENERIC_PHY_MIPI_DPHY, > given all it needs is the phy_mipi_dphy_get_default_config() symbol. > > Fix it. > > Signed-off-by: Ezequiel Garcia Acked-by: Helen Koike > --- > drivers/staging/media/rkisp1/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig > index b859a493caba..e3ba6826fbb0 100644 > --- a/drivers/staging/media/rkisp1/Kconfig > +++ b/drivers/staging/media/rkisp1/Kconfig > @@ -7,7 +7,7 @@ config VIDEO_ROCKCHIP_ISP1 > select VIDEOBUF2_DMA_CONTIG > select VIDEOBUF2_VMALLOC > select V4L2_FWNODE > - select PHY_ROCKCHIP_DPHY_RX0 > + select GENERIC_PHY_MIPI_DPHY > default n > help > Enable this to support the Image Signal Processing (ISP) module >