From: Bryan O'Donoghue <bod@kernel.org>
To: Christopher Obbard <christopher.obbard@linaro.org>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: venus: declare firmware files via MODULE_FIRMWARE
Date: Mon, 20 Apr 2026 11:20:44 +0100 [thread overview]
Message-ID: <b18d5f20-4013-47a3-bf43-06162682a65a@kernel.org> (raw)
In-Reply-To: <20260419-wip-obbardc-qcom-venus-firmware-v1-1-08a0d3cf056f@linaro.org>
On 19/04/2026 23:39, Christopher Obbard wrote:
> The driver loads firmware blobs at runtime via request_firmware()
> but does not currently advertise the possible filenames. Add
> MODULE_FIRMWARE() entries for all known firmware variants so they are
> visible via modinfo and can be picked up by user space tooling.
>
> Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
> ---
> drivers/media/platform/qcom/venus/core.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 7e639760c41d..7ed7cffb333b 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -1119,6 +1119,16 @@ static const struct venus_resources qcm2290_res = {
> .min_fw = &min_fw,
> };
>
> +MODULE_FIRMWARE("qcom/venus-1.8/venus.mbn");
> +MODULE_FIRMWARE("qcom/venus-4.2/venus.mbn");
> +MODULE_FIRMWARE("qcom/venus-4.4/venus.mbn");
> +MODULE_FIRMWARE("qcom/venus-4.4/venus.mdt");
> +MODULE_FIRMWARE("qcom/venus-5.2/venus.mbn");
> +MODULE_FIRMWARE("qcom/venus-5.4/venus.mbn");
> +MODULE_FIRMWARE("qcom/vpu-1.0/venus.mbn");
> +MODULE_FIRMWARE("qcom/vpu-2.0/venus.mbn");
> +MODULE_FIRMWARE("qcom/venus-6.0/venus.mbn");
> +
> static const struct of_device_id venus_dt_match[] = {
> { .compatible = "qcom,msm8916-venus", .data = &msm8916_res, },
> { .compatible = "qcom,msm8996-venus", .data = &msm8996_res, },
>
> ---
> base-commit: 4f5b4b748ac75683d61c304ee3ee0db235e8f312
> change-id: 20260419-wip-obbardc-qcom-venus-firmware-abdd35b05a22
>
> Best regards,
> --
> Christopher Obbard <christopher.obbard@linaro.org>
>
>
What about the board dtsi files ?
#( 04/20/26@10:29 )( deckard@inspiron14p-linux
):~/Development/linux@arm64-laptops-v7.1-rc6-camss✗✗✗
grep -r "venus.mbn" *
arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi: firmware-name
= "qcom/sm8250/xiaomi/elish/venus.mbn";
arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts: firmware-name =
"qcom/qcm6490/fairphone5/venus.mbn";
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts: firmware-name =
"qcom/msm8996/gemini/venus.mbn";
arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts: firmware-name =
"qcom/msm8996/oneplus3/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi: firmware-name =
"qcom/sdm845/Sony/tama/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts: firmware-name =
"qcom/sdm845/Xiaomi/polaris/venus.mbn";
arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi: firmware-name =
"qcom/sm8250/Sony/edo/venus.mbn";
arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts: firmware-name =
"qcom/sm8250/xiaomi/pipa/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi: firmware-name =
"qcom/sdm845/OnePlus/enchilada/venus.mbn";
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-scorpio.dts: firmware-name =
"qcom/msm8996/scorpio/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi: firmware-name =
"qcom/sdm845/Google/blueline/venus.mbn";
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts: firmware-name =
"qcom/qcm6490/SHIFT/otter/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts: firmware-name =
"qcom/sdm845/SHIFT/axolotl/venus.mbn";
arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts: firmware-name =
"qcom/msm8996/oneplus3t/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi:
firmware-name = "qcom/sdm845/Xiaomi/beryllium/venus.mbn";
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts: firmware-name =
"qcom/msm8996/natrium/venus.mbn";
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/venus-1.8/venus.mbn",
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/venus-4.2/venus.mbn",
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/venus-4.4/venus.mbn",
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/venus-5.2/venus.mbn",
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/venus-5.2/venus.mbn",
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/venus-5.4/venus.mbn",
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/vpu-1.0/venus.mbn",
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/vpu-2.0/venus.mbn",
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/vpu-2.0/venus.mbn",
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/venus-6.0/venus.mbn",
drivers/media/platform/qcom/venus/core.c: .fwname =
"qcom/vpu-2.0/venus.mbn",
drivers/media/platform/qcom/iris/iris_platform_gen1.c: .fwname =
"qcom/vpu-1.0/venus.mbn",
---
bod
next prev parent reply other threads:[~2026-04-20 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5RSTHU5_nsLp9gy49GbhT_8mHBjtBeKDsC6F1ABHCU9ZdpW9A8692UruVYnsCexIJGWsWiW2R5WtPULge31Gyw==@protonmail.internalid>
2026-04-19 22:39 ` [PATCH] media: venus: declare firmware files via MODULE_FIRMWARE Christopher Obbard
2026-04-20 10:20 ` Bryan O'Donoghue [this message]
2026-04-20 19:57 ` Christopher Obbard
2026-04-21 1:23 ` Bryan O'Donoghue
2026-04-21 21:10 ` Christopher Obbard
2026-04-22 0:26 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b18d5f20-4013-47a3-bf43-06162682a65a@kernel.org \
--to=bod@kernel.org \
--cc=christopher.obbard@linaro.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox