From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48B5F284690 for ; Tue, 12 May 2026 06:46:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778568380; cv=none; b=IH5/nbzo57L40GnMH1FyKzyzeIcc1uo0/nWufs2uC52c9Aju8U0mE8hlMx3MIO3dA8AXrCvFSJ05OEHaMjsTv8eYmRwigJdcSLmssQUlguTOWPMjKznjMHPHgu0F0cZ8j0o5Xxq7strn+6DdfDbi9rCehoXTR7FtnYcuzgF2y80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778568380; c=relaxed/simple; bh=CLY42ZZOGo+4sQn8BGDBCrauhj4O6Tqcq/5giz2mCCc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Content-Type; b=DXtpxQlte2QOqezWOpfTZTRv6dZ89riyg74UtFL+GZQN8MfafBs+agwRMQNgaWXxQBA8/3eL9kPeelmPxR0+kn/UJLoMdht581u37Cg5AtYCMHajIp5uPdcv4zA1zGiZr8jTJW8/uE9QxSu9ijxuMa7kmAAcgqp0cikgEulXiBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RCfOGKJU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RCfOGKJU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D446C2BCB0 for ; Tue, 12 May 2026 06:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778568377; bh=CLY42ZZOGo+4sQn8BGDBCrauhj4O6Tqcq/5giz2mCCc=; h=Date:From:Subject:To:From; b=RCfOGKJUBOPM9hASx/rgGiuNHBWYXlgbNdkin7pbcURBO+h5u8XrtJSdmZF/p37Bz ElanYeR2E1eNwMF11f+4IyksPWx74IRs55APoGwGIxEdgxnCuXo/4eVjhUFS8jIroL CLPWNiCYUysXZkbZgVXSxavyoKq8Z0hKXe1TSe1KN1Hn5rGGrxCoC2Ubz4BsqJq+Va 7Oe49e4eDxM1MMp7YR6k5jKPSYWt4Aps6qjRfMdXgMIrbeD8kfCEsM1eUPrKA39fD7 Iu8UegO/U3jRisoFOgQKusEdP/VEtLPtGDmVqvK2mS7Fp9mt94MvqsaMVYlXTkYEy8 ffLUizEylzQ0Q== Message-ID: Date: Tue, 12 May 2026 08:46:15 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans Verkuil Content-Language: en-US, nl Subject: [PATCH] media: visl: check if ctx->tpg_str_buf allocation failed To: Linux Media Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The result of ctx->tpg_str_buf = kzalloc(TPG_STR_BUF_SZ, GFP_KERNEL); was never checked. Add this. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/test-drivers/visl/visl-core.c b/drivers/media/test-drivers/visl/visl-core.c index 127ab18bce99..5e9bdd425d4a 100644 --- a/drivers/media/test-drivers/visl/visl-core.c +++ b/drivers/media/test-drivers/visl/visl-core.c @@ -339,6 +339,10 @@ static int visl_open(struct file *file) } ctx->tpg_str_buf = kzalloc(TPG_STR_BUF_SZ, GFP_KERNEL); + if (!ctx->tpg_str_buf) { + rc = -ENOMEM; + goto free_ctx; + } v4l2_fh_init(&ctx->fh, video_devdata(file)); ctx->dev = dev;