From: Devarsh Thakkar <devarsht@ti.com>
To: Jai Luthra <jai.luthra@ideasonboard.com>,
Jai Luthra <jai.luthra@linux.dev>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>
Cc: Rishikesh Donadkar <r-donadkar@ti.com>,
Vaishnav Achath <vaishnav.a@ti.com>,
Changhuang Liang <changhuang.liang@starfivetech.com>,
<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH 1/6] media: ti: j721e-csi2rx: Use devm_of_platform_populate
Date: Thu, 27 Mar 2025 11:55:30 +0530 [thread overview]
Message-ID: <b7439746-4143-4504-939e-e8abd705c962@ti.com> (raw)
In-Reply-To: <20250324-probe_fixes-v1-1-5cd5b9e1cfac@ideasonboard.com>
On 24/03/25 17:31, Jai Luthra wrote:
> Ensure that we clean up the platform bus when we remove this driver.
>
> This fixes a crash seen when reloading the module for the child device
> with the parent not yet reloaded.
>
> Fixes: b4a3d877dc92 ("media: ti: Add CSI2RX support for J721E")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
Regards
Devarsh
> ---
> drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> index 6412a00be8eab89548950dd21b3b3ec02dafa5b4..a066024bf745450e2ba01d06c0fec4e6bdbfa97e 100644
> --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> @@ -1118,7 +1118,7 @@ static int ti_csi2rx_probe(struct platform_device *pdev)
> if (ret)
> goto err_vb2q;
>
> - ret = of_platform_populate(csi->dev->of_node, NULL, NULL, csi->dev);
> + ret = devm_of_platform_populate(csi->dev);
> if (ret) {
> dev_err(csi->dev, "Failed to create children: %d\n", ret);
> goto err_subdev;
>
next prev parent reply other threads:[~2025-03-27 6:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 12:01 [PATCH 0/6] media: ti, cdns: Multiple pixel support and misc fixes Jai Luthra
2025-03-24 12:01 ` [PATCH 1/6] media: ti: j721e-csi2rx: Use devm_of_platform_populate Jai Luthra
2025-03-27 6:25 ` Devarsh Thakkar [this message]
2025-03-24 12:01 ` [PATCH 2/6] media: ti: j721e-csi2rx: Use fwnode_get_named_child_node Jai Luthra
2025-03-27 6:31 ` Devarsh Thakkar
2025-03-24 12:01 ` [PATCH 3/6] media: ti: j721e-csi2rx: Fix source subdev link creation Jai Luthra
2025-03-27 10:14 ` Devarsh Thakkar
2025-03-24 12:01 ` [PATCH 4/6] media: cadence: csi2rx: Implement get_fwnode_pad op Jai Luthra
2025-03-27 10:24 ` Devarsh Thakkar
2025-03-28 2:39 ` 回复: " Changhuang Liang
2025-03-24 12:01 ` [PATCH 5/6] media: cadence: cdns-csi2rx: Support multiple pixels per clock cycle Jai Luthra
2025-03-24 14:28 ` kernel test robot
2025-03-24 18:21 ` kernel test robot
2025-03-24 12:01 ` [PATCH 6/6] media: ti: j721e-csi2rx: Support multiple pixels per clock Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7439746-4143-4504-939e-e8abd705c962@ti.com \
--to=devarsht@ti.com \
--cc=changhuang.liang@starfivetech.com \
--cc=hverkuil@xs4all.nl \
--cc=jai.luthra@ideasonboard.com \
--cc=jai.luthra@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=r-donadkar@ti.com \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vaishnav.a@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox