From: Tobias Lorenz <tobias.lorenz@gmx.net>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: radio-si470x-usb.c warning: can I remove 'buf'?
Date: Fri, 26 Aug 2011 21:03:53 +0200 [thread overview]
Message-ID: <b7859e54bc9c2258672ded9be4cd8665@localhost> (raw)
In-Reply-To: <201108251425.37536.hverkuil@xs4all.nl>
Hi Hans,
> While going through the compile warnings generated in the daily build I
> came
> across this one:
>
> v4l-dvb-git/drivers/media/radio/si470x/radio-si470x-usb.c: In function
> 'si470x_int_in_callback':
> v4l-dvb-git/drivers/media/radio/si470x/radio-si470x-usb.c:398:16:
warning:
> variable 'buf' set but not used [-Wunused-but-set-variable]
>
> The 'unsigned char buf[RDS_REPORT_SIZE];' is indeed unused, but can I
just
> remove it? There is this single assignment to buf: 'buf[0] =
RDS_REPORT;'.
>
> This makes me wonder if it is perhaps supposed to be used after all.
>
> Please let me know if I can remove it, or if it is a bug that someone
needs
> to fix.
this is an artifact from shifting the rds processing function into
interrupt context.
Yes, this can safely be removed.
Can you do this?
Bye,
Toby
next prev parent reply other threads:[~2011-08-26 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 12:25 radio-si470x-usb.c warning: can I remove 'buf'? Hans Verkuil
2011-08-26 19:03 ` Tobias Lorenz [this message]
2011-08-27 14:33 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7859e54bc9c2258672ded9be4cd8665@localhost \
--to=tobias.lorenz@gmx.net \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox