* radio-si470x-usb.c warning: can I remove 'buf'?
@ 2011-08-25 12:25 Hans Verkuil
2011-08-26 19:03 ` Tobias Lorenz
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2011-08-25 12:25 UTC (permalink / raw)
To: Tobias Lorenz; +Cc: linux-media
Hi Tobias,
While going through the compile warnings generated in the daily build I came
across this one:
v4l-dvb-git/drivers/media/radio/si470x/radio-si470x-usb.c: In function 'si470x_int_in_callback':
v4l-dvb-git/drivers/media/radio/si470x/radio-si470x-usb.c:398:16: warning: variable 'buf' set but not used [-Wunused-but-set-variable]
The 'unsigned char buf[RDS_REPORT_SIZE];' is indeed unused, but can I just
remove it? There is this single assignment to buf: 'buf[0] = RDS_REPORT;'.
This makes me wonder if it is perhaps supposed to be used after all.
Please let me know if I can remove it, or if it is a bug that someone needs
to fix.
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: radio-si470x-usb.c warning: can I remove 'buf'?
2011-08-25 12:25 radio-si470x-usb.c warning: can I remove 'buf'? Hans Verkuil
@ 2011-08-26 19:03 ` Tobias Lorenz
2011-08-27 14:33 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Tobias Lorenz @ 2011-08-26 19:03 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media
Hi Hans,
> While going through the compile warnings generated in the daily build I
> came
> across this one:
>
> v4l-dvb-git/drivers/media/radio/si470x/radio-si470x-usb.c: In function
> 'si470x_int_in_callback':
> v4l-dvb-git/drivers/media/radio/si470x/radio-si470x-usb.c:398:16:
warning:
> variable 'buf' set but not used [-Wunused-but-set-variable]
>
> The 'unsigned char buf[RDS_REPORT_SIZE];' is indeed unused, but can I
just
> remove it? There is this single assignment to buf: 'buf[0] =
RDS_REPORT;'.
>
> This makes me wonder if it is perhaps supposed to be used after all.
>
> Please let me know if I can remove it, or if it is a bug that someone
needs
> to fix.
this is an artifact from shifting the rds processing function into
interrupt context.
Yes, this can safely be removed.
Can you do this?
Bye,
Toby
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: radio-si470x-usb.c warning: can I remove 'buf'?
2011-08-26 19:03 ` Tobias Lorenz
@ 2011-08-27 14:33 ` Hans Verkuil
0 siblings, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2011-08-27 14:33 UTC (permalink / raw)
To: Tobias Lorenz; +Cc: linux-media
On Friday, August 26, 2011 21:03:53 Tobias Lorenz wrote:
> Hi Hans,
>
> > While going through the compile warnings generated in the daily build I
> > came
> > across this one:
> >
> > v4l-dvb-git/drivers/media/radio/si470x/radio-si470x-usb.c: In function
> > 'si470x_int_in_callback':
> > v4l-dvb-git/drivers/media/radio/si470x/radio-si470x-usb.c:398:16:
> warning:
> > variable 'buf' set but not used [-Wunused-but-set-variable]
> >
> > The 'unsigned char buf[RDS_REPORT_SIZE];' is indeed unused, but can I
> just
> > remove it? There is this single assignment to buf: 'buf[0] =
> RDS_REPORT;'.
> >
> > This makes me wonder if it is perhaps supposed to be used after all.
> >
> > Please let me know if I can remove it, or if it is a bug that someone
> needs
> > to fix.
>
> this is an artifact from shifting the rds processing function into
> interrupt context.
> Yes, this can safely be removed.
>
> Can you do this?
Will do. I've just posted a pull request that includes this fix.
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-27 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-25 12:25 radio-si470x-usb.c warning: can I remove 'buf'? Hans Verkuil
2011-08-26 19:03 ` Tobias Lorenz
2011-08-27 14:33 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox