Re: [PATCH 2/3] phy-rockchip-dphy-rx0: Drop unneeded CONFIG_OF dependency

Ezequiel Garcia
2020-04-21T03:55:41Z

On Thu, 2020-04-02 at 10:59 -0300, Helen Koike wrote:
>
> On 4/1/20 6:37 PM, Ezequiel Garcia wrote:
> > The driver is perfectly capable of being built without CONFIG_OF.
> > Remove this dependency, which is useful for compile-only tests.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
>
> Acked-by: Helen Koike <helen.koike@collabora.com>
>
> > ---
> > drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig
> > index bd0147624de1..fb74df829371 100644
> > --- a/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig
> > +++ b/drivers/staging/media/phy-rockchip-dphy-rx0/Kconfig
> > @@ -2,7 +2,7 @@
> >
> > config PHY_ROCKCHIP_DPHY_RX0
> > tristate "Rockchip MIPI Synopsys DPHY RX0 driver"
> > - depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
> > + depends on ARCH_ROCKCHIP || COMPILE_TEST

After discussing other similar patches, I'm starting to
think this was a bad idea.

Instead, we want to do have (ARCH_ROCKCHIP && OF) || COMPILE_TEST
as the other Rockchip PHYs.

Thanks,
Ezequiel