linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Kaiser <thomas@kaiser-linux.li>
To: Karl Wallin <karl.wallin.86@gmail.com>, linux-media@vger.kernel.org
Subject: Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"
Date: Sun, 28 May 2017 22:01:13 +0200	[thread overview]
Message-ID: <b87109c6-9af7-a39c-8c45-eaac2dbb27d4@kaiser-linux.li> (raw)
In-Reply-To: <CAML3znGvFv7Gd0jHUVGn45+Phzn6dkUEhcHY16h-6BQg4r6joQ@mail.gmail.com>

On 28.05.2017 21:33, Karl Wallin wrote:
> Thanks for such a quick reply :)
> 
> Of course *facepalm* should have thought of that "./build" downloads
> everything again and of course replaces my modified "cec-core.c".
> I ran "make" and ran into new problems:
> 
> 
> Ok so using logic I should do the same changes in
> "/home/ubuntu/media_build/v4l/media-devnode.c":
> In ""/home/ubuntu/media_build/v4l/media-devnode.c" changed row 257 from:
> "ret = cdev_device_add(&devnode->cdev, &devnode->dev);" to:
> "ret = device_add(&devnode->dev);"
> and row 293 from:
> "cdev_device_del(&devnode->cdev, &devnode->dev);" to:
> "device_del(&devnode->dev);"
> and then run "make"
> 
> However it fails again :(
> 

>    CC [M]  /home/ubuntu/media_build/v4l/serial_ir.o
> /home/ubuntu/media_build/v4l/serial_ir.c:837:21: error: expected ')'
> before 'int'
>   module_param_hw(io, int, ioport, 0444);
>                       ^~~
> /home/ubuntu/media_build/v4l/serial_ir.c:841:25: error: expected ')'
> before 'ulong'
>   module_param_hw(iommap, ulong, other, 0444);
>                           ^~~~~
> /home/ubuntu/media_build/v4l/serial_ir.c:849:26: error: expected ')'
> before 'int'
>   module_param_hw(ioshift, int, other, 0444);
>                            ^~~
> /home/ubuntu/media_build/v4l/serial_ir.c:852:22: error: expected ')'
> before 'int'
>   module_param_hw(irq, int, irq, 0444);
>                        ^~~
> /home/ubuntu/media_build/v4l/serial_ir.c:855:28: error: expected ')'
> before 'bool'
>   module_param_hw(share_irq, bool, other, 0444);
>                              ^~~~
> scripts/Makefile.build:301: recipe for target
> '/home/ubuntu/media_build/v4l/serial_ir.o' failed
> make[3]: *** [/home/ubuntu/media_build/v4l/serial_ir.o] Error 1
> Makefile:1524: recipe for target '_module_/home/ubuntu/media_build/v4l' failed
> make[2]: *** [_module_/home/ubuntu/media_build/v4l] Error 2
> make[2]: Leaving directory '/usr/src/linux-headers-4.10.0-21-generic'
> Makefile:51: recipe for target 'default' failed
> make[1]: *** [default] Error 2
> make[1]: Leaving directory '/home/ubuntu/media_build/v4l'
> Makefile:26: recipe for target 'all' failed
> make: *** [all] Error 2
> 
> So I'm guessing that "/home/ubuntu/media_build/v4l/serial_ir.c" needs
> to be modified since it expects a ")" before the integer (numerical)
> value?
> 
> /Karl

Hi Karl

I compiled only the ddbridge driver. So I did not have to compile these files you have problems with. Therefor I don't know what is going on here, sorry.

Thomas

  reply	other threads:[~2017-05-28 20:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-27 19:28 Build fails Ubuntu 17.04 / "error: implicit declaration of function" Karl Wallin
2017-05-28  0:45 ` Vincent McIntyre
     [not found] ` <9102e964-8143-edd7-3a82-014ae0d29d48@kaiser-linux.li>
2017-05-28 19:06   ` Karl Wallin
2017-05-28 19:14     ` Thomas Kaiser
2017-05-28 19:33       ` Karl Wallin
2017-05-28 20:01         ` Thomas Kaiser [this message]
2017-05-28 21:42     ` Daniel Scheller
2017-05-30 19:35       ` Karl Wallin
2017-05-30 19:35         ` Karl Wallin
2017-06-04  6:50         ` Vincent McIntyre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b87109c6-9af7-a39c-8c45-eaac2dbb27d4@kaiser-linux.li \
    --to=thomas@kaiser-linux.li \
    --cc=karl.wallin.86@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).