From: Hans Verkuil <hverkuil+cisco@kernel.org>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH] v4l2-compliance: skip V4L2_CID_PRIVATE_BASE check for UVC
Date: Wed, 29 Oct 2025 11:15:51 +0100 [thread overview]
Message-ID: <b960f0fc-36e9-46c3-b56f-a06f6525d5ad@kernel.org> (raw)
UVC doesn't support V4L2_CID_PRIVATE_BASE, so skip the check.
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
---
Ricardo, can you test this to verify that this solves the issue?
---
diff --git a/utils/v4l2-compliance/v4l2-test-controls.cpp b/utils/v4l2-compliance/v4l2-test-controls.cpp
index e4925ca3..73a6a3be 100644
--- a/utils/v4l2-compliance/v4l2-test-controls.cpp
+++ b/utils/v4l2-compliance/v4l2-test-controls.cpp
@@ -321,6 +321,9 @@ int testQueryExtControls(struct node *node)
if (user_controls != user_controls_check)
return fail("expected %d user controls, got %d\n",
user_controls_check, user_controls);
+ /* UVC doesn't support V4L2_CID_PRIVATE_BASE */
+ if (is_uvcvideo)
+ priv_user_controls_check = 0;
if (priv_user_controls != priv_user_controls_check)
return fail("expected %d private controls, got %d\n",
priv_user_controls_check, priv_user_controls);
next reply other threads:[~2025-10-29 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 10:15 Hans Verkuil [this message]
2025-10-29 10:30 ` [PATCH] v4l2-compliance: skip V4L2_CID_PRIVATE_BASE check for UVC Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b960f0fc-36e9-46c3-b56f-a06f6525d5ad@kernel.org \
--to=hverkuil+cisco@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).