From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ECAA33B6C4 for ; Fri, 17 Apr 2026 19:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776455071; cv=none; b=OTAd0BOtvzD/hNSy4Xl75n4GbqW0MgD++JVmEiI0eWbTJnnvRtlQRDoLuqQJsoQ9Y6EFs8tU3V/SfWmKbFJfeXjm959M7WZpEKemilTfzi00dBpMM7kHfEPqB9iQPD1InjuSQmN7N/z2oA0oCdgCOwF8JPmvq3qGCu8SncVZg0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776455071; c=relaxed/simple; bh=4AUae5KcEeFvFh3msKQXl5hQJhIopamMvxo6YZ4ukss=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=M32zPGw0OqVPjjpv21kwWUKQnEDqB5L9IjKlq1OxYib30pW50lLbPUSO9eVfh+uca6EBgR7tPHiM+Ii76Yy+9j8o6OBGxRZMpEyscev4DKlRxGDJV6Ktx+D/JGAWMfTBh9WukeuYdwCWExN2xJ7ahZG0irU5eawfrBdnFzURKjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ScaF/hWL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=It09TyNk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ScaF/hWL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="It09TyNk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776455069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4AUae5KcEeFvFh3msKQXl5hQJhIopamMvxo6YZ4ukss=; b=ScaF/hWLflWAYuk0Z4w1zIK1BB61+gW2jXF0SUApYSVe4x6/DlccDRXxhm43jDEX7nGOx9 zpJDpXFvARmjPhSqh28hZWVRlV5edsVAyQnK5OAATzw/144O3EdunQlqWyGIvYlNIBil47 UtPKuX9K10QLLhIKOqjAgb62EcvYM1s= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-4cHM6yUFNnqPKXTuRVZY3w-1; Fri, 17 Apr 2026 15:44:28 -0400 X-MC-Unique: 4cHM6yUFNnqPKXTuRVZY3w-1 X-Mimecast-MFC-AGG-ID: 4cHM6yUFNnqPKXTuRVZY3w_1776455068 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8d654ade33aso505891485a.1 for ; Fri, 17 Apr 2026 12:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776455068; x=1777059868; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=4AUae5KcEeFvFh3msKQXl5hQJhIopamMvxo6YZ4ukss=; b=It09TyNkeaLuLq5JOmeUiG5518HDXWICADLfS3+mSr1U5uJunkN3tAs/bV+C3ps2+7 2BZ3lNNWZb+6yigizMHWKwGDfNaJQwX6DNMYzJF/uOBgzqk0XrEN859HEHWTap0LeWVn ugATgajPluFBWwADLZ/q2zkqJ2XBATjslOCaWHquZ78Xo2N1aCdlbR3Iz+IbqOD+dsCj C79SbHKoic7WxxnbzGtw41W+FwapM2HlvMkUDEspdsBuGG08krlYveFZdmEpipq7nTVn wOV5oeZcwW/5q4Y4XVgrtRYGDShNpnfUZbWKGxIy0Q/4pnoGB8T6jvTBFRWdU8ZLQZxj 8lNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776455068; x=1777059868; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4AUae5KcEeFvFh3msKQXl5hQJhIopamMvxo6YZ4ukss=; b=KkS/Q3MghXvowTNdtq2V8wnM4182/IZl9Z67oIhDuZvp2easl90AKfcHOSILDWV/HH t7YosGqPOr2ns85k1TtR+1y5IbDyKSrCyxDBOYW6Yy/Lq1neyDLCxBbZQNUrP6ztpPD7 J3a8WOJN7K2qiCW3GI2hIN7Rg3vD1QFjSY8JAhGhjy3tbWPJtmE2XMK51K4Wzza8i08s nCX2W13Z/7f5lHuL3L0aJ3b6cYMimUSEWqefs3Gv4J5twTS41gWafOe9PBkawKnBtYwD 2f8uRwjPVttqsqyOrJVD2CeDYlQlt88y9dST3l65gsRrfmVZkbkeVbrJ/WUTf2RKxNHB XFDA== X-Forwarded-Encrypted: i=1; AFNElJ+OqTFb8tmy5rRPoxz06mceprjIKJS7o/8HX/702WyBUChRbdoF7v42ApmPeMwpKW5RbZvVfbo3DWisag==@vger.kernel.org X-Gm-Message-State: AOJu0Yzlbj8vKuAIMtu/tFHBKXv2CWngKU0zvEs9DDK/+aLa6luxzhdu zPBNV1VaOHvEQqjvuZiUEL+7jbzIav0TM78dfGOmuTlVasBU0Q/MPQZD/wHm5Tp8cZH3e/Sdan+ o/94hTTKV6pnvfx1lBWtcUbc+w0XujaXy9c37VQzT9kzVdgkmZErE7j3J8j9stGp/ X-Gm-Gg: AeBDieuI0v5/3FuX0nhMTXZrPReSAXW7F9R/1nYqfEX3LvhyxnEJwsrxf3995jY0MCv CD47uhaQkR3Rasfakm4z8ZqeWj72Y4ULdWg54HXb/ix5Q3d9QaJ3in0kPmL1P5dIPenqUu8hZQm f+7gjIJT8nMHPJ2Qco4/dWGaS6MmxPyTiAa9GE0tmQmM5H9aEvj5xx1iXl+bd9EEAr86kJQv8IS keGJMhkzw3Wr0Spzt+21bVTjhn3x8YmjNrNX/SoXRiogXGnzHt5DFQx7p6bATqb7IO7Iaceygk0 qLBlTrnR3pa7BsA4muHccVF0iToJVqpgUEtWnCoGitAyMsmwlh0eBFG57HpsowRvqyVSRjIWb1p yM9JDfM4/BgHGZfjXKeTEgQRP4QF7 X-Received: by 2002:a05:620a:4408:b0:8d9:ca3b:5ca1 with SMTP id af79cd13be357-8e789c5ab1dmr528961585a.9.1776455067633; Fri, 17 Apr 2026 12:44:27 -0700 (PDT) X-Received: by 2002:a05:620a:4408:b0:8d9:ca3b:5ca1 with SMTP id af79cd13be357-8e789c5ab1dmr528955585a.9.1776455067197; Fri, 17 Apr 2026 12:44:27 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8e7d9abce59sm243352085a.46.2026.04.17.12.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 12:44:26 -0700 (PDT) Message-ID: Subject: Re: [PATCH v10 4/5] rust: drm: gem: Introduce shmem::SGTable From: lyude@redhat.com To: Alexandre Courbot Cc: nouveau@lists.freedesktop.org, Gary Guo , Daniel Almeida , rust-for-linux@vger.kernel.org, Danilo Krummrich , dri-devel@lists.freedesktop.org, Matthew Maurer , FUJITA Tomonori , Lorenzo Stoakes , christian.koenig@amd.com, Asahi Lina , Miguel Ojeda , Andreas Hindborg , Simona Vetter , Alice Ryhl , Boqun Feng , Sumit Semwal , Krishna Ketan Rai , linux-media@vger.kernel.org, Shankari Anand , David Airlie , Benno Lossin , Viresh Kumar , linaro-mm-sig@lists.linaro.org, Asahi Lina , Greg Kroah-Hartman , kernel@vger.kernel.org Date: Fri, 17 Apr 2026 15:44:25 -0400 In-Reply-To: References: <20260409001559.622026-1-lyude@redhat.com> <20260409001559.622026-5-lyude@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Just so it doesn't come as a surprise in the next respin - I don't really see a reasonable way of using get_or_insert_with() here (though I had no idea this was a thing!). However - I can get rid of all of the ret =3D statements and also clean up the indenting a little bit with block expressions as I forgot those exist. On Fri, 2026-04-10 at 16:55 +0900, Alexandre Courbot wrote: >=20 > nit: let's use `let ret =3D if let Some(sgt_res) ...` to avoid the > multiple `ret =3D `statements? >=20 > Or maybe even better, you might be able to use > `Option::get_or_insert_with`.