Re: [PATCH 5/5] media: ov02c10: Remove unnecessary hflip and vflip pointers

[Bryan O'Donoghue <bod@kernel.org>]

On 09/12/2025 16:06, Hans de Goede wrote:
> The cci_update_bits() inside ov02c10_set_ctrl() can used the passed
> in ctrk argument to access the vflip control value.

use the passed <data> in the ctrl argument

> 
> After changing this there is no need to store a pointer to the hflip
> and vflip controls inside struct ov02c10, drop these.
> 
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Bryan O'Donoghue <bod@kernel.org>
> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
> ---
>   drivers/media/i2c/ov02c10.c | 12 +++++-------
>   1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> index f912ae142040..cf93d36032e1 100644
> --- a/drivers/media/i2c/ov02c10.c
> +++ b/drivers/media/i2c/ov02c10.c
> @@ -381,8 +381,6 @@ struct ov02c10 {
>   	struct v4l2_ctrl *vblank;
>   	struct v4l2_ctrl *hblank;
>   	struct v4l2_ctrl *exposure;
> -	struct v4l2_ctrl *hflip;
> -	struct v4l2_ctrl *vflip;
> 
>   	struct clk *img_clk;
>   	struct gpio_desc *reset;
> @@ -471,7 +469,7 @@ static int ov02c10_set_ctrl(struct v4l2_ctrl *ctrl)
>   		cci_write(ov02c10->regmap, OV02C10_ISP_Y_WIN_CONTROL,
>   			  ctrl->val ? 2 : 1, &ret);
>   		cci_update_bits(ov02c10->regmap, OV02C10_ROTATE_CONTROL,
> -				BIT(4), ov02c10->vflip->val << 4, &ret);
> +				BIT(4), ctrl->val << 4, &ret);
>   		break;
> 
>   	default:
> @@ -549,11 +547,11 @@ static int ov02c10_init_controls(struct ov02c10 *ov02c10)
>   					      OV02C10_EXPOSURE_STEP,
>   					      exposure_max);
> 
> -	ov02c10->hflip = v4l2_ctrl_new_std(ctrl_hdlr, &ov02c10_ctrl_ops,
> -					   V4L2_CID_HFLIP, 0, 1, 1, 0);
> +	v4l2_ctrl_new_std(ctrl_hdlr, &ov02c10_ctrl_ops, V4L2_CID_HFLIP,
> +			  0, 1, 1, 0);
> 
> -	ov02c10->vflip = v4l2_ctrl_new_std(ctrl_hdlr, &ov02c10_ctrl_ops,
> -					   V4L2_CID_VFLIP, 0, 1, 1, 0);
> +	v4l2_ctrl_new_std(ctrl_hdlr, &ov02c10_ctrl_ops, V4L2_CID_VFLIP,
> +			  0, 1, 1, 0);
> 
>   	v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &ov02c10_ctrl_ops,
>   				     V4L2_CID_TEST_PATTERN,
> --
> 2.52.0
> 

Reviewed-by: Bryan O'Donoghue <bod@kernel.org>