From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C10772D0636 for ; Mon, 20 Oct 2025 05:59:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760939969; cv=none; b=IpeXpll4zMIc140gm9h0FH4U+IXuq7IlI1PMcgeQmjoFjWHTILjTBVB4D5fg3RBtrygglv2LSGZcwRT8CnlplwWvTVPOE/OvK2inC+aZNOx5qmITuCGYTIw97xT1cwLN2+Vf152q/hBPyOt+UWz1LvJjRoc3FHgBNqdJ1NOm0rc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760939969; c=relaxed/simple; bh=DfgQhDV2FB+r3jXdeQjlELojhkZCzkVAxCp7ukCYBp4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SqzNvYa+3TqxZiQea1gnmD9L44zg+qmfS41j5apwitIEEVEeDfTr0+5ZsdcxInANXFJYfphN/tl31+9cVMBee8YPcIU1bcQjoHPtizk7DtZlvF1xTkMUzzZwwHuvulf1tfbYU4seFCX1QuwRh/Nb/RttDHrqwhiXpFkiWhPc01M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AwvQAiHN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AwvQAiHN" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59JNNGO3010042 for ; Mon, 20 Oct 2025 05:59:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nM+18YfZG3eJcSFCMfzYrqy29nlqANkrqIV1DISydfs=; b=AwvQAiHNZfptJ/sS i5WDMuP2gRVCoBZ68zEz05L2Ju3az2ItKHRmAT6DUhiNLKy8s8ozHmuBu8Kz9ULM eWNZgonQhV+lfmHKBPfDj5xeYC+GMPa0DpRsnba3F3U2YJQS2J6HRTvOb237+m72 xQNCGieEZs+l5Bx58+CB37AkYupNbQLU0pB1yJ0kF9GTWwWs6QFjNEIdk8fxxG8s PSeBCIDMqhmWo8KbJx7ayULn/eurVcduffgVD5Rz/MeseGjoQT+7BCLsBtGMefND M7EPR0uxZd/Lh94X7BLvG8Sgw205tdyhip21CZYDrW9OrIItFDnAod1MQ5q6UpYJ 8NvWHA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v2yv3qk9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 20 Oct 2025 05:59:26 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7a153ba0009so7416098b3a.1 for ; Sun, 19 Oct 2025 22:59:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760939965; x=1761544765; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nM+18YfZG3eJcSFCMfzYrqy29nlqANkrqIV1DISydfs=; b=pVbeiidTofHXCmBxLtQ5qrS9uOiKrRwZjDaY1xxDbGDJvzQ3t0FtMlIf8JFzFmLzZl 0GeiukS9qjr0EQ6AJyT/u5tPkw1I/6/+e3lBrbNTlkmsXCP56+8jrluo5M+Y4nftGGFn j3HSX1HeAg9redd+cpWrrvXNsmyu+TV38WXtaOyG4PKFjr7Lwk2m+tcZjZ3NRoPWeRTU Yvhp7fe0SxqdQvtHlaq28srh9ikengkmhcYamJuu5fAy1sqIk5+wkXrpj9/PT1trgkkI lmNnBx33WJDfnqjUYHPEi0jAItFHM/eALYF1Kw3Xxvviaae7xcfzDogBlvLnmKUl4T65 oGrA== X-Forwarded-Encrypted: i=1; AJvYcCX8ToEy9kkaZpGb5r9wts6Yr5onGhUAe7eBZ/HL9j/ZVYZ3pJfJoRg+nyhQ/sykIxqaCzSk/isy5uI13Q==@vger.kernel.org X-Gm-Message-State: AOJu0YyOWNRETUdvHNlWCRtIwof1YInWlbiE1uAzG2hM8eHvOsB7O2Oh oUVgjLw3AfVIgj2HdZBRTZKNFjBJ6acqPLHbN/OF0ilCTodwn7KZeWj2FUaMEL6pwJ85nTDAscQ s9F9VifFFHcMm/Fi5peQuuFxFhodOApej8YJ03Pl6RBetpHOXW2IM3Rw0tndt8apaeg== X-Gm-Gg: ASbGnct6XCAvkUtadLGCW754h6HPu3TfxdudQIyNwHjPZEX7GcDJ0KLudk4SrU8BF/g ux0TmXrzhi+Hi16XFvgn5sKoeNsIlSn0n4QnsM3xXHUu1vJgkrlhQM0Eef8vXmrRta844zmUMrc Hyz2wJZLfKKoA+VY21bRbTC5CZYMCUUbFq/hcoI7/JdzyhMaDVF6bgdkAKAjIM1f9A/cQHAbKMG q7gqaCxzPGKcr+TJxttqQVhbBVZ80OjUdmEwydYJJYp6up/scGtGFoHy3Ex7v4xXl7p2deBGcEl v6Ez2618MdcNww6DfMJrO5cvwEfcFcAadV1tKFPZDi/Oj7wn+s6tP1yENkNDTCdclb0Gzy2ZGRy s4tx7ai0qGAaIKOgq1bn57038BEVJ1RoQX5TN4edQyf6ozS6cIzb+bLGKrwPI4KWj2jBhug== X-Received: by 2002:a05:6a00:21c4:b0:772:45ee:9b9e with SMTP id d2e1a72fcca58-7a220aa8c36mr12648436b3a.9.1760939965331; Sun, 19 Oct 2025 22:59:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOnIQKmKM4/wBe+q3U4Vl91ebk6gizKnC7NhQP4NZOp+sNVTSvIrGb+vHkb3XE0F6V5ZNQSg== X-Received: by 2002:a05:6a00:21c4:b0:772:45ee:9b9e with SMTP id d2e1a72fcca58-7a220aa8c36mr12648411b3a.9.1760939964922; Sun, 19 Oct 2025 22:59:24 -0700 (PDT) Received: from [10.133.33.90] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a22ff34ba6sm7240595b3a.18.2025.10.19.22.59.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Oct 2025 22:59:24 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 13:59:16 +0800 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] media: qcom: camss: csid: Add support for CSID 1080 To: Bryan O'Donoghue , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251014-add-support-for-camss-on-kaanapali-v2-0-f5745ba2dff9@oss.qualcomm.com> <20251014-add-support-for-camss-on-kaanapali-v2-5-f5745ba2dff9@oss.qualcomm.com> Content-Language: en-US From: Hangxiang Ma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: oqxVNWhpKhjo2D9_9YdV55f-u2UrS4S1 X-Proofpoint-GUID: oqxVNWhpKhjo2D9_9YdV55f-u2UrS4S1 X-Authority-Analysis: v=2.4 cv=f+5FxeyM c=1 sm=1 tr=0 ts=68f5cfbe cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=AXp2hmqOj5kKvFkYXygA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMyBTYWx0ZWRfX/SwGApCwlwp8 8YPc/cgbNXvKXxooQjbKZiEExOfBUZKwwU5q41F+Msl+L7260vM9+Aj8T+79Ddhp6rh8KXaWJsf TZVZ//zAUsxoLJmDRA3CTM+eE2PPhMpBCnaoi+h4r6dE2gI44+SB7nveOQgHyyyHsDljoPjVFjT aAaygCGzH0dQ2WBZGuolIJzXj06Ru2C4JzotI8qUoUpwDfPMc9PB/JzjSOB0AQkHrC3RPyWm4w9 WXazUXbl9djwGa2T2iEfgUeh4yPPgve7ZaecLOUnmjt2bNJkx7lL+nWOWHI1bbXrz7Sb+JsO+Ne cKc6bc1t1ofsYx/yKonVXCDRhTtJf7Hu/zRr+JDTtGOluaqFuOwg8nDD3HjrcAlulhQaa0rF11E 9Vqe4nTzUrWW66EzaF9Tz0AgIpA8CA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-20_02,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180023 On 10/16/2025 5:12 PM, Bryan O'Donoghue wrote: > On 15/10/2025 03:56, Hangxiang Ma wrote: >> +    for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++) >> +        if (csid->phy.en_vc & BIT(i)) { >> +            val = readl(csid->base + CSID_CSI2_RDIN_IRQ_STATUS(i)); >> +            writel(val, csid->base + CSID_CSI2_RDIN_IRQ_CLEAR(i)); >> + >> +            if (buf_done_val & BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + >> i)) { >> +                /* >> +                 * buf done and RUP IRQ have been moved to CSID from >> VFE. >> +                 * Once CSID received buf done, need notify VFE of this >> +                 * event and trigger VFE to handle buf done process. >> +                 */ >> +                camss_buf_done(csid->camss, csid->id, i); >> +            } >> +        } >> + > A multi-liner like this should be > > for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++) { >     /* etc */ > } > > in fact csid_reset_1080() does the right thing, please replicate. > Ack. Thanks. --- Hangxiang