Re: [PATCH 14/38] dt-bindings: media: mediatek,mt8195-jpeg: Allow range number in node address

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/09/2025 11:00, AngeloGioacchino Del Regno wrote:
> Il 04/08/25 11:02, AngeloGioacchino Del Regno ha scritto:
>> Il 24/07/25 11:14, Krzysztof Kozlowski ha scritto:
>>> On 24/07/2025 10:38, AngeloGioacchino Del Regno wrote:
>>>> The dual and triple core jpeg encoder and decoder (respectively)
>>>> on MT8195 are far apart: the only way to have this to make sense
>>>> is to split those in multiple address ranges in device trees as
>>>> one big range would overlap with other IP in at least the MT8195
>>>> SoC.
>>>>
>>>> Change both the jpegdec and jpegenc bindings to allow specifying
>>>> children nodes such as "jpegdec@0,10000", "jpegdec@1,0" or for
>>>> encoder "jpegenc@0,0", "jpegenc@1,0" to resolve dtbs_check issues.
>>>
>>>
>>> This should not be needed for standard MMIO/simple-bus nodes. I think
>>> DTS is wrong here.
>>>
>>> Which cases really need the ','?
>>>
>>
>> All of the multi-core JPEG enc/decoders on MT8195 (and newer).
>>
>> The DT changes are included in the same series as this commit; check:
>>
>> 20250724083914.61351-35-angelogioacchino.delregno@collabora.com
>>
>> Cheers,
>> Angelo
>>
> 
> Any further comments on this?

Well yeah, that's still wrong. These are simple MMIO, so comma is not
correct. Rob already commented on this at v1 of Ariel's patchset. It was
BTW the same device - mt8195 jpeg!


Best regards,
Krzysztof