From: Daniel Almeida <daniel.almeida@collabora.com>
To: Steve Cho <stevecho@chromium.org>
Cc: hverkuil@xs4all.nl, linux-media@vger.kernel.org,
Nicolas Dufresne <nicolas.dufresne@collabora.com>
Subject: Re: [RFC PATCH v2] media: Add AV1 uAPI
Date: Tue, 7 Jun 2022 14:43:44 -0300 [thread overview]
Message-ID: <bdfbe6d9-2b32-bd54-e718-f02fecb708a7@collabora.com> (raw)
In-Reply-To: <CAC-pXoPvkwowiBsrEo4w2kjE9geDEP=qPQ2ntkgAQxiwuc123w@mail.gmail.com>
Hi Steve.
> > Question about update_ref_delta, update_mode_delta flags for loop
> filter params in the spec.
> >
> > I don't see these flags in v4l2_av1_loop_filter struct.
> >
> > After looking at gstreamer implementation, I think arrays ref_deltas,
> mode_deltas are only filled in when these flags are 1.
> >
> > Is this correct understanding?
> > If not, can you explain the background why these flags are omitted?
>
> Possibly forgotten. Will fix in RFC v3.
I looked into this issue again. Apparently the other codec APIs do not
convey these flags either. Let's wait until we get a second driver to
see whether they will be necessary.
-- Daniel
prev parent reply other threads:[~2022-06-07 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 16:01 [RFC PATCH v2] media: Add AV1 uAPI daniel.almeida
2022-05-10 0:04 ` Steve Cho
2022-05-10 16:30 ` Daniel Almeida
2022-05-11 20:59 ` Steve Cho
2022-05-16 17:42 ` Steve Cho
2022-05-18 16:41 ` Steve Cho
[not found] ` <CAN0yncHrY6jfk6owTEue8PqGmxffU612UgccvPc9Y6XOz38LRA@mail.gmail.com>
2022-05-19 15:54 ` Steve Cho
[not found] ` <CAC-pXoNHRxqe6tzg3++TqYRZE-nocxiz-iPh5vPXC07iA_BaSw@mail.gmail.com>
[not found] ` <CAC-pXoNRoqT_Fse_3Z8cO-SDwtMTm3fzScpDWvi5sNVr1N1Dzg@mail.gmail.com>
[not found] ` <CAC-pXoOon18axGdT_+V38sdAWDh+t4jZetXqte7BCwO09YG+2w@mail.gmail.com>
[not found] ` <CAC-pXoMVKmAZ=9iM7ivuo8rvnL=KQWHnopWharDz-eDky0QS-g@mail.gmail.com>
2022-05-31 16:42 ` Daniel Almeida
[not found] ` <CAC-pXoPvkwowiBsrEo4w2kjE9geDEP=qPQ2ntkgAQxiwuc123w@mail.gmail.com>
2022-06-07 17:43 ` Daniel Almeida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdfbe6d9-2b32-bd54-e718-f02fecb708a7@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=stevecho@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox