From: Petr Cvek <petr.cvek@tul.cz>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [RFC] [PATCH 0/4] [media] pxa_camera: Fixing bugs and missing colorformats
Date: Sun, 14 May 2017 06:33:16 +0200 [thread overview]
Message-ID: <be13b205-2d60-b00a-06ec-5008cc635bed@tul.cz> (raw)
In-Reply-To: <c2c51214-71ad-7c32-5d19-63e731852781@tul.cz>
Dne 13.5.2017 v 08:40 Petr Cvek napsal(a):
> The second problem seems to be a same problem. When playing/encoding the data from the sensor (with or without previous fix) and calling (probably) anything on v4l2 the drivers stops in a same way. I discovered it by trying to use the CONFIG_VIDEO_ADV_DEBUG interface to realtime poking the sensor.
>
> You should be able to recreate that by starting the stream (mplayer or ffmpeg) and run:
> v4l2-ctl -n
> or reading registers, running v4l2-compliance etc...
>
I get it now. The second problem is likely in pxac_fops_camera_release(). At the closing of the device the function calls sensor_call → s_power and sets the sensor to OFF regardless if somebody is using it somewhere else. There should be reference counter (as was in the original soc_camera_close() function).
This bug makes impossible to debug pxa camera and its sensors.
cheers,
Petr
prev parent reply other threads:[~2017-05-14 4:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 4:20 [PATCH 0/4] [media] pxa_camera: Fixing bugs and missing colorformats Petr Cvek
2017-05-01 4:39 ` [RFC] " Petr Cvek
2017-05-02 14:57 ` Robert Jarzmik
2017-05-13 6:40 ` Petr Cvek
2017-05-14 4:33 ` Petr Cvek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be13b205-2d60-b00a-06ec-5008cc635bed@tul.cz \
--to=petr.cvek@tul.cz \
--cc=g.liakhovetski@gmx.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox