From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D63230AD05 for ; Wed, 10 Dec 2025 19:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765395404; cv=none; b=UEOERPo8kmbyU/zRmkHJw7uvxGNVK+oNxwHu6AbOrSKP3JXqJPXIWphCRCebTQIh9KwQ08Jsmde/aG7VYHdvNxepsYgwJKxOboiSt8gZivzlQzWdkZfeHNG1bNEqaMO7vdUHmG5Td5cYpHYeuPwahTsdTz7p8rbO5ZR/f3dWeow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765395404; c=relaxed/simple; bh=Ew1uAbyttj7rhEAFG5qaeC3ftzjpfOPyz7DDCcagp1s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OOTjaZ/XNnBsWuANk6RKFf8I5/GZ/m/LlKAWEUjPTkeYaBHdtb1BxnQE/SNbICknFuG1jY1GcxNhp6JQAwwsmScNvxFaAN/dT8sDZWDVb6wEUwHmr6KTeh1T666L82mfIe688qrn6ROvccWkhjkHO6bltINTLpQv0M8j36BNu7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UwaHXZSw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gz8fA+b7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UwaHXZSw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gz8fA+b7" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BAIRLZl3082226 for ; Wed, 10 Dec 2025 19:36:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= x9hCNA5xokRASa4lA7uwVKxWsgAlSC2cp9EuIIPSfRk=; b=UwaHXZSwO/AddfgG pybGBK9knvBxraifa11fh4sqbACoYpUOtMSryhhASTkSCPccfhpPKfRGvib94Nj5 v2HPmd2Xwudv4uYMvDwC2JchAkc2AOJrKrnVfJcjag4Y0fgFZok7lHexuBg1OwAG 9WhRuP13jsTUg9xdEHWeFYkcZvwYB61P8jUJt9xD3krqXm1HaVtnf1K1wxfwybof s/8E03nozuuysLEe4DCrQt4swptsRf4SC6iSv8eQvNWKvtF+qEgbWpRihgGxT2Sn 098yyFcRvThaM5inr9emuWv4iDJ3uS6eQCNVEZQzd5pkHZVQ6zLLaBjYOAdYMFFa rSv5MA== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ay2e0jn7d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Dec 2025 19:36:41 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b969f3f5bb1so253503a12.0 for ; Wed, 10 Dec 2025 11:36:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765395400; x=1766000200; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x9hCNA5xokRASa4lA7uwVKxWsgAlSC2cp9EuIIPSfRk=; b=Gz8fA+b7i1tR43i6q24UNBtyqN/Lj0e5XwuqsKdxuEVpAT2UaBB/JvhDIsK7yFrW9w fnwrnZsiAI+7LJFOW506RD5UborcD/SLf/3t1cFXXzHO2Fl1rFnZfGdVSiVpnxl6h1WO FrYJMd3Flu6PqexfV7XCTZPSKavTXX1suUfVDuoSFhlpGvwCHwh9U3XQ+Uk7KLEGP0iU rAFQ58fGt+F2+9I2c/zcs1KU3wMckGnyD3LgCi4BettOY8psCtesKfhnCt1ZGqBA2MBF Rq5Yj81+ApRQkYSBrcWv5rvSgei5YVyqzOyIaztKZ9/F+yTaKNYvMAURGi97R0wjE9J/ ZKXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765395400; x=1766000200; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x9hCNA5xokRASa4lA7uwVKxWsgAlSC2cp9EuIIPSfRk=; b=qBIOuXuOJ3sY+2WzcA+xOpScr4xVyMM5HETrXRiucGfnS9VF2al5smaTrpiXiWulTe Hm9WisFueP66FBxpBRJgVqS61FwArWvLchi6xPSFHJhikWf1b7J4zU6D5xpPOwnLL7CW OUllpbFz3/d20yJ3ENVooTLgrX2R0gIq3LW/hRoy4T5d05n5PHPciX70icgOYi8Uyfd7 XcpUMFlN/+C0FX0/OypB7GPeYei0xELzgoHj9AqPBVjNf+ZfRkMigyv7mcvtUfrxmZ9j y12+PiTqpp+ax00sxXLcaHOc/c6Qq7OFYwMdlDkYM9HeVhrbZ1SX+IZgLgR4ktfzCCbh nWWw== X-Forwarded-Encrypted: i=1; AJvYcCWweSzL1rr/XrUKVk5XwE4goafeoUVPFpQyrOgZiqn1OJ8OaceddY/tdI+lEohmbcrOx8JYmjBi02v6tw==@vger.kernel.org X-Gm-Message-State: AOJu0Yxb/rnTE7CzhnJq1xkbi4kZzhIOpRlT0xY6ZuxxBNJ9gQeBhuqG WyYshO1TMHkxLlDBK19CVYgkwMl3l1TnQRbY45qGfqVXKP8hzQa/xZkCduis2PNZ56mEpDbKEhv 8tSgtqhDMKkRMGH36fbVVpUn6D+CJo9fkmCl78QktPUr3hC/z6i7OOfLdQK8WlfQPWg== X-Gm-Gg: ASbGncut+6suisWYASeKXXUpC5J1o2HkQzIfqB1/c9yh8FeaN1e/DX1CFxJnXhurTHP 5zz7TqZjHQB6YKwQ7n03v2o47HRzsPHvm5urS1WJBJUuVdYkCHfqZL/UE83le/2QK+VVORs74m8 j4PJC8f1QHtOe/bdlvVGV9xkfuRe2i6xebgiVQkJ0xC4IgY9MVtXofoPca6khqewczi47IKg1aQ 0V1Hk5u2rgoJ6kVzK8f2wyss/lfZDOM/VqCOoQcGoRdZgBEnNDIaROFYB7Fi2xfR5aGBG1XSM15 gTuNdjJj+Nv9/31uEaqZDWp2Y3ab76RJ4Ml1PkpK05JMrnnNcqngbzrKUMvlg6ztEwyCyX89yCM UPpvidJPl6CRHCb+ROtoWFl7oziyNzb40/dFfAoUy X-Received: by 2002:a05:7022:6991:b0:11b:9386:826a with SMTP id a92af1059eb24-11f296adc6amr2522968c88.47.1765395400244; Wed, 10 Dec 2025 11:36:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUZ1v6jfRQGUJ626jnA7RexYEYVVeEaYFm9cmPSXnJMjNkZYBcc6sVDGTEc6vtPt+RuB3vFQ== X-Received: by 2002:a05:7022:6991:b0:11b:9386:826a with SMTP id a92af1059eb24-11f296adc6amr2522941c88.47.1765395399726; Wed, 10 Dec 2025 11:36:39 -0800 (PST) Received: from [192.168.1.57] ([98.148.145.183]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11f2e30491dsm910655c88.16.2025.12.10.11.36.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 11:36:39 -0800 (PST) Message-ID: Date: Wed, 10 Dec 2025 11:36:38 -0800 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 1/5] media: dt-bindings: Add CAMSS device for Kaanapali To: Dmitry Baryshkov Cc: Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Krzysztof Kozlowski References: <20251208-add-support-for-camss-on-kaanapali-v9-0-3fcd31258415@oss.qualcomm.com> <20251208-add-support-for-camss-on-kaanapali-v9-1-3fcd31258415@oss.qualcomm.com> <458a7841-e422-4cad-83de-f5b5c1b683a6@oss.qualcomm.com> <2e38b9f3-8a35-4a27-82d3-c1d4996a1684@oss.qualcomm.com> <9ecf4783-e1a2-430b-a889-997689bafe45@oss.qualcomm.com> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEwMDE2MCBTYWx0ZWRfX1OGFZkVMXgtE 4HiL4HXLcFDUV4iEMRQ7+LpX+jwsoUZtYwWSlaOzAjwrrcge56r2Br2rUefhQbAvHlnhGl/uJQw FLVrz3UF9D7jHxV+xRHmBkuL9BJn+vgV9Ku0Dbh89RCq/qlVpk0GZ4ZNIkuvV5e6LIkn8JxF4C2 VhENG5Vc+MDyJhnGEzWMX92IMeVm8RQP/KxU/Ciy/YOgEuHBgT5d9iGnrZ+EFMcTz7DpcPlhLHD BBrZ+e1SLXWIiwsrInJr0A30f9PSuC1il57d0Rm+0OJIm8M0mpTFfcKODyQv/6onGBMrzLXkM/E 6RWDV8WRGJsSaPCoZbrUqiDjvrM4AEGnPgfRiiBtbjmSupG9JCepAoT4gnwT17K5V+51j/KrWZF e4mTCzlz1bAB8ecZzdC11SA4bXnKpg== X-Proofpoint-ORIG-GUID: -kypQH-G88kP1ku1Xk0XYshMYLRBFNmt X-Authority-Analysis: v=2.4 cv=G5oR0tk5 c=1 sm=1 tr=0 ts=6939cbc9 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=BiHMn5M11h/vNwziJwzFrg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=WCWGkPf-bWonS_P_xYgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: -kypQH-G88kP1ku1Xk0XYshMYLRBFNmt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-10_02,2025-12-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512100160 On 12/10/2025 11:25 AM, Dmitry Baryshkov wrote: > On Wed, Dec 10, 2025 at 09:50:51AM -0800, Vijay Kumar Tumati wrote: >> On 12/8/2025 3:21 PM, Vijay Kumar Tumati wrote: >>> On 12/8/2025 2:48 PM, Dmitry Baryshkov wrote: >>>> On Mon, Dec 08, 2025 at 01:03:06PM -0800, Vijay Kumar Tumati wrote: >>>>> On 12/8/2025 11:53 AM, Dmitry Baryshkov wrote: >>>>>>> +  interconnects: >>>>>>> +    maxItems: 4 >>>>>>> + >>>>>>> +  interconnect-names: >>>>>>> +    items: >>>>>>> +      - const: ahb >>>>>>> +      - const: hf_mnoc >>>>>>> +      - const: sf_icp_mnoc >>>>>>> +      - const: sf_mnoc >>>>>> You know... Failure to look around is a sin. What are the names of >>>>>> interconnects used by other devices? What do they actually describe? >>>>>> >>>>>> This is an absolute NAK. >>>>> Please feel free to correct me here but, a couple things. >>>>> >>>>> 1. This is consistent with >>>>> Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml. no? >>>> I see that nobody noticed an issue with Agatti, Lemans and Monaco >>>> bindings (Krzysztof?) >>>> >>>> Usually interconnect names describe the blocks that are connected. Here >>>> are the top results of a quick git grep of interconnect names through >>>> arch/arm64/dts/qcom: >>>> >>>>      729 "qup-core", >>>>      717 "qup-config", >>>>      457 "qup-memory", >>>>       41 "usb-ddr", >>>>       41 "apps-usb", >>>>       39 "pcie-mem", >>>>       39 "cpu-pcie", >>>>       28 "sdhc-ddr", >>>>       28 "cpu-sdhc", >>>>       28 "cpu-cfg", >>>>       24 "mdp0-mem", >>>>       17 "memory", >>>>       14 "ufs-ddr", >>>>       14 "mdp1-mem", >>>>       14 "cpu-ufs", >>>>       13 "video-mem", >>>>       13 "gfx-mem", >>>> >>>> I hope this gives you a pointer on how to name the interconnects. >>>> >>>>> 2. If you are referring to some other targets that use, "cam_" >>>>> prefix, we >>>>> may not need that , isn't it? If we look at these interconnects >>>>> from camera >>>>> side, as you advised for other things like this? >>>> See above. >>> I see, so the names cam-cfg, cam-hf-mem, cam-sf-mem, cam-sf-icp-mem >>> should be ok? >>> >>> Or the other option, go exactly like >>> Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml. >>> >>> What would you advise? >>> >> To keep it consistent with the previous generations and still represent the >> block name, we will go ahead with the style in qcom,sc8280xp-camss.yaml. If >> anyone has any concerns, please do let us know. > Krzysztof, Bryan, your opinion? My preference would be to start using > sensible names, but I wouldn't enforce that. > >>>>>>> + >>>>>>> +  iommus: >>>>>>> +    items: >>>>>>> +      - description: VFE non-protected stream >>>>>>> +      - description: ICP0 shared stream >>>>>>> +      - description: ICP1 shared stream >>>>>>> +      - description: IPE CDM non-protected stream >>>>>>> +      - description: IPE non-protected stream >>>>>>> +      - description: JPEG non-protected stream >>>>>>> +      - description: OFE CDM non-protected stream >>>>>>> +      - description: OFE non-protected stream >>>>>>> +      - description: VFE / VFE Lite CDM non-protected stream >>>>>> This will map all IOMMUs to the same domain. Are you sure that this is >>>>>> what we want? Or do we wait for iommu-maps to be fixed? >> Yes, when it is available, we can start using iommu-maps to create separate >> context banks. > It would be necessary to justify removing items from the list. Wouldn't > it be better to map only necessary SIDs now and add other later once we > have iommu-maps? I will let Bryan take the call on this. He was the one who wanted all the SIDs in the bindings. Hi @Bryan, if you can kindly share your thoughts on this and the interconnect naming, we will go ahead and push rev 10 for this. I believe we have taken care of other things. Thank you. >