Re: [PATCH 3/4] arm64: dts: rockchip: add rx0 mipi-phy for rk3399

Johan Jonker
2020-04-02T14:38:01Z

On 4/2/20 4:31 PM, Heiko Stübner wrote:
> Am Donnerstag, 2. April 2020, 15:48:02 CEST schrieb Johan Jonker:
>> Hi Helen,
>>
>>> From: Helen Koike <helen.koike@collabora.com>
>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>>> index 33cc21fcf4c10..fc0295d2a65a1 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>>> @@ -1394,6 +1394,17 @@ io_domains: io-domains {
>>> status = "disabled";
>>> };
>>>
>>
>>> + mipi_dphy_rx0: mipi-dphy-rx0 {
>>
>> For Heiko sort syscon@ff770000 subnodes alphabetical or reg value first?
>
> Similar to main nodes ... so things without reg alphabetical,
> the rest by reg address
>
alphabetical first:

io-domains
mipi-dphy-rx0
usb2-phy@e450
.@..

or

with reg values first:

.@..
emmc_phy: phy@f780
mipi-dphy-rx0
pcie-phy

>
>>
>>> + compatible = "rockchip,rk3399-mipi-dphy-rx0";
>>> + clocks = <&cru SCLK_MIPIDPHY_REF>,
>>
>>> + <&cru SCLK_DPHY_RX0_CFG>,
>>> + <&cru PCLK_VIO_GRF>;
>>
>> Align ^
>>
>>> + clock-names = "dphy-ref", "dphy-cfg", "grf";
>>> + power-domains = <&power RK3399_PD_VIO>;
>>> + #phy-cells = <0>;
>>> + status = "disabled";
>>> + };
>>> +
>>> u2phy0: usb2-phy@e450 {
>>> compatible = "rockchip,rk3399-usb2phy";
>>> reg = <0xe450 0x10>;
>>
>>
>
>
>
>