public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: leandro Costantino <lcostantino@gmail.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Nicolau Werneck <nwerneck@gmail.com>, linux-media@vger.kernel.org
Subject: Re: patch to support for 0x0802 sensor in t613.c
Date: Fri, 18 Dec 2009 22:52:12 +0100	[thread overview]
Message-ID: <c2fe070d0912181352j7c8a8085sf14d8ea68fe63ddb@mail.gmail.com> (raw)
In-Reply-To: <20091218201349.69ca27a5@tele>

Nicolau, if you need help, let me know.
I also, sent you some mails asking for the patch for review some weeks
ago, i thougth you were missing :)
good woork
best regards

On Fri, Dec 18, 2009 at 8:13 PM, Jean-Francois Moine <moinejf@free.fr> wrote:
> On Fri, 18 Dec 2009 16:46:04 -0200
> Nicolau Werneck <nwerneck@gmail.com> wrote:
>
>> Hello. I am a clueless n00b, and I can't make patches or use any
>> proper development tools. But I made this modification to t613.c to
>> support this new sensor. It is working fine with me. I just cleaned
>> the code up a bit and compiled and tested with the 2.6.32 kernel, and
>> it seems to be working fine.
>>
>> If somebody could help me creating a proper patch to submit to the
>> source tree, I would be most grateful. The code is attached.
>
> Hello Nicolau,
>
> Your code seems fine. To create a patch, just go to the linux tree
> root, make a 'diff -u' from the original file to your new t613.c, edit
> it, at the head, add a comment and a 'Signed-off-by: <your email>', and
> submit to the mailing-list with subject '[PATCH] gspca - t613: Add new
> sensor lt168g'.
>
> BTW, as you know the name of your sensor, do you know the real name of
> the sensor '0x803' ('other')? (it should be in some xxx.ini file in a
> ms-win driver, but I could not find it - the table n4_other of t613.c
> should be a table 'Regxxx' in the xx.ini)
>
> Best regards.
>
> --
> Ken ar c'hentań |             ** Breizh ha Linux atav! **
> Jef             |               http://moinejf.free.fr/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2009-12-18 21:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-18 18:46 patch to support for 0x0802 sensor in t613.c Nicolau Werneck
2009-12-18 19:13 ` Jean-Francois Moine
2009-12-18 21:52   ` leandro Costantino [this message]
2009-12-30  9:56     ` leandro Costantino
2009-12-30 13:26       ` Nicolau Leal Werneck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2fe070d0912181352j7c8a8085sf14d8ea68fe63ddb@mail.gmail.com \
    --to=lcostantino@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=moinejf@free.fr \
    --cc=nwerneck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox