From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0671224201 for ; Fri, 5 Jan 2024 09:04:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="dqM7e62P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1704445456; bh=catFhC7QxRNUsfvTalqfYbmfWNtqfVz8smE35dp2IOk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dqM7e62PExG/bmTIZERtK/x66aCbZvC1Xok3bcvX+8NAdUB/jl7VWYpqYC3MtpqJz +FvFr1uGfsQyHbhF8T1NfzWbRmvFe10XBJ+OtKk5wBEbqCVGNEOYIif708jHRvZHin gJPYt8HEKWUyxpnPoEgN0J/iJMNt0SOvROXC8l+JwnUdjKrdtQZMpk8JVfbom0NwB7 ANZ4IXpQa0MnAb43IGl6yTZf7gDHv/cqDw1NJ5LbL61xgRkOk2fcC3CKNr2ygDHXW4 HLbFBRlRRbnhQqwfW617mCxkUoJIiM/0m6e6vMw1VsTPGtVosXFcvEt4BOYFwBO0Sz fpY5cyhL4bVkA== Received: from [100.74.67.65] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: jmassot) by madrid.collaboradmins.com (Postfix) with ESMTPSA id E52CB37801C1; Fri, 5 Jan 2024 09:04:15 +0000 (UTC) Message-ID: Date: Fri, 5 Jan 2024 10:04:14 +0100 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] media: cadence: csi2rx: use match fwnode for media link Content-Language: en-US To: Sakari Ailus Cc: j-luthra@ti.com, mchehab@kernel.org, mripard@kernel.org, kernel@collabora.com, linux-media@vger.kernel.org References: <20231218095604.1950737-1-julien.massot@collabora.com> <20231218095604.1950737-2-julien.massot@collabora.com> From: Julien Massot In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Sakari On 12/18/23 12:09, Sakari Ailus wrote: > Hi Julien, > > Thanks for the patch. > > On Mon, Dec 18, 2023 at 10:56:00AM +0100, Julien Massot wrote: >> On some subdev the fwnode is the device node and not the endpoint node. >> Using the subdev fwnode doesn't allow to fetch the subdev >> pad we are connected to when the remote subdev has multiple >> output pads. > > I'd change the commit message, endpoint-to-endpoint matching used to be the > preferred way to do things not long ago. > >> >> Fixes: 1fc3b37f34f69 ("media: v4l: cadence: Add Cadence MIPI-CSI2 RX driver") > > I think the driver was originally fine but I missed making the below change > when changing async matching. Instead I think you should have here: > > Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching") > > IOW applying your patch without 1029939b3782 will also break cdns-csi2rx > driver. I just replaced the fix tag, and the commit message as suggested in V3. Thank you, Julien