From: "Koenig, Christian" <Christian.Koenig@amd.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linaro-mm-sig@lists.linaro.org" <linaro-mm-sig@lists.linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] dma-buf: refcount the attachment for cache_sgt_mapping
Date: Wed, 12 Jun 2019 08:20:41 +0000 [thread overview]
Message-ID: <c5e04bf7-d07e-9e26-df65-d7382d6051ba@amd.com> (raw)
In-Reply-To: <20190612081554.GB8876@Asurada>
Am 12.06.19 um 10:15 schrieb Nicolin Chen:
> Hi Christian,
>
> On Wed, Jun 12, 2019 at 08:05:53AM +0000, Koenig, Christian wrote:
>> Am 12.06.19 um 10:02 schrieb Nicolin Chen:
>> [SNIP]
>>> We haven't used DRM/GRM_PRIME yet but I am also curious would it
>>> benefit DRM also if we reduce this overhead in the dma_buf?
>> No, not at all.
> From you replies, in a summary, does it means that there won't be a case
> of DRM having a dma_buf attaching to the same device, i.e. multiple calls
> of drm_gem_prime_import() function with same parameters of dev + dma_buf?
Well, there are some cases where this happens. But in those cases we
intentionally want to get a new attachment :)
So thinking more about it you would actually break those and that is not
something we can do.
> If so, we can just ignore/drop this patch. Sorry for the misunderstanding.
It might be interesting for things like P2P, but even then it might be
better to just cache the P2P settings instead of the full attachment.
Regards,
Christian.
>
> Thanks
> Nicolin
next prev parent reply other threads:[~2019-06-12 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 1:22 [PATCH] dma-buf: refcount the attachment for cache_sgt_mapping Nicolin Chen
2019-06-12 7:45 ` Koenig, Christian
2019-06-12 8:02 ` Nicolin Chen
2019-06-12 8:05 ` Koenig, Christian
2019-06-12 8:15 ` Nicolin Chen
2019-06-12 8:20 ` Koenig, Christian [this message]
2019-06-12 8:25 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5e04bf7-d07e-9e26-df65-d7382d6051ba@amd.com \
--to=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox