From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EF8A439006; Wed, 1 Jul 2026 11:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782903724; cv=none; b=ExsGmqVTEvyZZ3oTr1O24I/OWNzpqYqSA5hM6/hDQbGCxgCD/d8Qk/qFOAgi6xqv/X2b0PdKAZehubmS/5e748cmSlIdALKdBaoh4exZ4N4Vp+KqOYrFxRdeSubtGFzOnEBqLrDsh58SLjdvjFQCDEqhMCx4/sY8821OvSCiIEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782903724; c=relaxed/simple; bh=gPauPI/9fhjKIv+zHh4InusR8yG4d8qr+Y3ucsd24m4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pxz+60but4bM6/9FUpHMzNlNkyZfh7evyyjevJcfd2S4cL+9FNDddoCrtHGIkpP5M3h5GbvJo9EYk+RpvkmAvjVFyRUNewFWtdGWzR0xzeTTVqvVUQmMNSCOZGTf7YbbivkUXbNFNqw8UVMZvS5LVJ6+grG7DF/Ej1x84s734xM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TK5agZAt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TK5agZAt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85E8A1F000E9; Wed, 1 Jul 2026 11:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782903723; bh=YykEavimjxgypRXCeyiKw76UjGkQVu2lKItLt5Z0LKg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=TK5agZAtNpG68duqFSm/sqXzBv8eAKmTUVmJHy6Os4m7zEavHpJJxgptE/0CnC9dk RujUhNe3tHfkBhRfi4Q5Y4UikruNO45bpkXRosSpJYecgFhPGrPV57nteTIk+yfeCJ Jdn7PXA+rQoNTRBSTne/cULuL4zYhXBZBdeNu6fWhgiP+5ftGXkB+47zTts3uPJnMN ThW9AJ3zsc+KF7wHkR+bTc9K+NmH3agnRBf7ZLTaaKwoaEy4Nde8o9flgl8q9jwsHh YvsEXCn7LSw1vI5znqEz2Qd7k59Q+DxSQei6ucwILoGHsFz10hvfMjJY+DIa5BDSJG 6DDtYOKb4CmoA== Message-ID: Date: Wed, 1 Jul 2026 13:01:58 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/4] platform: int3472: discrete: con_id vana for Sony IMX471 as power enable To: Tarang Raval , Kate Hsuan , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Serin Yeh , Damjan Georgievski , Kieran Bingham Cc: computman , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Daniel Scally , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "platform-driver-x86@vger.kernel.org" References: <20260629074026.35490-1-hpa@redhat.com> <20260629074026.35490-4-hpa@redhat.com> <49257d09-a2fd-4a9d-9479-4d2b5e0fb8a6@kernel.org> From: Hans de Goede Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 1-Jul-26 08:19, Tarang Raval wrote: > Hi Hans, > >> On 30-Jun-26 09:32, Tarang Raval wrote: >>> Hi Kate, >>> >>>> Update the con_id for the Sony IMX471 sensor to "vana" to serve as the >>>> power enable. Additionally, the HID values SONY471A and TBE20A0, both >>>> associated with the IMX471 image sensor, have been identified on Lenovo >>>> laptops. >>>> >>>> Signed-off-by: Kate Hsuan >>> >>> Thanks, looks good. >>> >>> Reviewed-by: Tarang Raval >> >> Hmm, the imx471 driver is still pending upstream: >> >> https://lore.kernel.org/linux-media/20260629074026.35490-5-hpa@redhat.com/ >> >> As part of this series. >> >> Please just use the standardized "avdd" in that driver instead >> of "vana" (which also seems to refer to the analog supply vdd, >> which is what avdd stands for). >> >> Then this whole patch is unnecessary and can be dropped from >> this series. > > The regulator name "vana" comes directly from the Sony IMX471 sensor > datasheet, which typically refers to the analog supply voltage. Using the > datasheet name helps keep the driver consistent with the hardware > documentation and makes it easier to cross-reference. > > as per my understanding, the more standardized way is to use the regulator > name as per the sensor datasheet. Therefore, I respectfully disagree with > your suggestion. As shown by the need for this patch on x86 at least because there is no devicetree it greatly helps if all Linux sensor drivers use standardized names for their regulators rather then using the exact name from the datasheet which often is not very consistent. And "avdd" is the name we've standardized on for this, so lets use that: hans@shalem:~/projects/linux$ grep -l '"vana"' drivers/media/i2c/*.c | wc -l 4 hans@shalem:~/projects/linux$ grep -l '"avdd"' drivers/media/i2c/*.c | wc -l 36 The alternative is needing to add more and more quirks as different sensors are used, which is not great. Regards, Hans