From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C9E1CD54AF for ; Tue, 19 Sep 2023 10:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231537AbjISK22 (ORCPT ); Tue, 19 Sep 2023 06:28:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231376AbjISK21 (ORCPT ); Tue, 19 Sep 2023 06:28:27 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 612C8E8; Tue, 19 Sep 2023 03:28:21 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 59F1666071A9; Tue, 19 Sep 2023 11:28:19 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695119300; bh=rAdvkgL5tyqfrBVfmKlUnvhnLh0r/Gbt0KKyc0j2m8g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=P3vkWQlYkYzeJBYJVzFcViUt3c8RrVQRk/CRSo4oQStYWGHn9WwyIuXm39evSjqNU cV1tRIEQP8fL305BnPqp9kUm3/skSfUB2EZx9/ibaLJtarJhV/bLceaYruV+6G/MhH j3fS9natozasDlENWJl9h0bA97AV9E3Gx8crU0q55GS94IGh+HKfya02ZitHEQ1TKK V1jc+wqTmEFkWZvBtjVf0fZOTjpn/nbjVsUdstFO3BDqXgsL/tDr+8vMieAgtKb5eu nq+Nq19bB0DCVSdJEkSOVDZ1fB5MoqcNrliTRL+DNaKDNaiSa4GRHhDRvVeAHizsCd 7Ih+UErEgloSg== Message-ID: Date: Tue, 19 Sep 2023 12:28:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 2/2] media: platform: mtk-mdp3: Use devicetree phandle to retrieve SCP Content-Language: en-US To: Chen-Yu Tsai Cc: wens@kernel.org, mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, moudy.ho@mediatek.com, hverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com, u.kleine-koenig@pengutronix.de, linqiheng@huawei.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com References: <20230919095938.70679-1-angelogioacchino.delregno@collabora.com> <20230919095938.70679-3-angelogioacchino.delregno@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Il 19/09/23 12:26, Chen-Yu Tsai ha scritto: > On Tue, Sep 19, 2023 at 6:24 PM AngeloGioacchino Del Regno > wrote: >> >> Il 19/09/23 12:21, Chen-Yu Tsai ha scritto: >>> On Tue, Sep 19, 2023 at 6:00 PM AngeloGioacchino Del Regno >>> wrote: >>>> >>>> Instead of walking the entire parent node for something that has the >>>> right compatible, use the scp_get() function provided by the MediaTek >>>> SCP remoteproc driver to retrieve a handle to mtk_scp through the >>>> devicetree "mediatek,scp" (phandle) property. >>>> >>>> In case of multi-core SCP, this also allows to select a specific core. >>>> >>>> Signed-off-by: AngeloGioacchino Del Regno >>>> --- >>>> .../media/platform/mediatek/mdp3/mtk-mdp3-core.c | 16 ++++++++++------ >>>> 1 file changed, 10 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c >>>> index 8677e7fd5083..d93d3833633e 100644 >>>> --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c >>>> +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c >>>> @@ -254,13 +254,17 @@ static int mdp_probe(struct platform_device *pdev) >>>> goto err_destroy_job_wq; >>>> } >>>> >>>> - mm_pdev = __get_pdev_by_id(pdev, NULL, MDP_INFRA_SCP); >>>> - if (WARN_ON(!mm_pdev)) { >>>> - dev_err(&pdev->dev, "Could not get scp device\n"); >>>> - ret = -ENODEV; >>>> - goto err_destroy_clock_wq; >>>> + mdp->scp = scp_get(pdev); >>>> + if (!mdp->scp) { >>>> + mm_pdev = __get_pdev_by_id(pdev, NULL, MDP_INFRA_SCP); >>>> + if (WARN_ON(!mm_pdev)) { >>>> + dev_err(&pdev->dev, "Could not get scp device\n"); >>>> + ret = -ENODEV; >>>> + goto err_destroy_clock_wq; >>>> + } >>>> + mdp->scp = platform_get_drvdata(mm_pdev); >>> >>> You need to keep the original code as a fallback for old device trees. >>> >> >> I haven't removed the original code, it *is* there as a fallback :-) >> >> mdp->scp = scp_get() <--- new >> if (!mdp->scp) { fallback } > > I see it now. I guess it's time to call it a day... I even replied with > the wrong email ... > > Reviewed-by: Chen-Yu Tsai hahaha! no worries, it happens :-) Thanks for the review btw. Cheers! Angelo > >>> ChenYu >>> >>>> } >>>> - mdp->scp = platform_get_drvdata(mm_pdev); >>>> + >>>> mdp->rproc_handle = scp_get_rproc(mdp->scp); >>>> dev_dbg(&pdev->dev, "MDP rproc_handle: %pK", mdp->rproc_handle); >>>> >>>> -- >>>> 2.42.0 >>>> >>> _______________________________________________ >>> Kernel mailing list -- kernel@mailman.collabora.com >>> To unsubscribe send an email to kernel-leave@mailman.collabora.com >> >>