From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A5A3D1CA0 for ; Wed, 22 Apr 2026 12:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860749; cv=none; b=HCCQRFPt6pEwjTWMUmfmz/gIMsMuhlRgY/xO7uTVy9msezgQz3dke/oJLd6CyjU/8oeThvGpvaZHpGoThbVazs+MNbbvZ4AtTWPqKNjJBcSGvyWNVCLxk2B6I4EIBitjo5bLRMTa4S+yiV2ylQfTYC6Yuc4QT8/NoFMZB81kCEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860749; c=relaxed/simple; bh=fSgwybm8EB7GnGWRJtzgSEC1MgNI4d36M3kf88uxlCI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JUOyD6Xd50mku6kSWH8pUHMUY9RL8HI01U/iL+TW5CTPmLUecwRIhSozPFddS/X5sHqASRHN4UFZarRu2jXCKGl6+yPYbQNZDbQJI3aoYitCRrvsFS0W8Fec14IMIaLMJjW3NCX3yRfk6yBNXom7EhlTOFnV40ETYMFXfFJgzN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CIhcKeZ4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iczjK1Xr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CIhcKeZ4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iczjK1Xr" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M99HVv2065437 for ; Wed, 22 Apr 2026 12:25:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pYI32RcMK+rIbb/42OAco+jjgy3p3bOcRS0/OXM4iEs=; b=CIhcKeZ4Bee3Y/9o bGYGyFmxpAwkvSQiA4p5k97kAbEXo2AE4n6YJCnJ6/+sfLm5JBDaVDlcNSRSMxXE PDypnv6i2wgoqZP1Frgzjp6gF2J2iCGZPPlF8mCE8COsIkZ8tZ4+XrfPBnCnm8F6 GjCDHatWY1Tt0Fwd9KB7jJ2lA1UuDbQbInzrzthkO1YRxTz9ijU3IzTSNLcCq/At 9FTN9Gb4dr6q9DbgIOOBceyrJraCjxGMN8Kub1eAvo1ejXDohdzxlMkDjcahb84N MZ4eyX90/HnIQMOIl6YSIAJWFn5SXmU9S+3Mlhu3dXCTsSlxsjmME7Mm9+PHYQYv JRDHZQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenhkbxf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 12:25:47 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50e5d7f4b63so10065451cf.0 for ; Wed, 22 Apr 2026 05:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776860747; x=1777465547; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pYI32RcMK+rIbb/42OAco+jjgy3p3bOcRS0/OXM4iEs=; b=iczjK1Xr5nP9Uqdhr65TI6o8pSXrT7SmigyftGdq3UW5tVF29zAae8JN8t5/z76Isb WTvaZFthdX3lA4vN8bPNZGZMs1U6HkuVXI3hk6fAPqz+9qIOuE26XP8MWwpuWI+6qzpc q/JRIs1oFE8EuEFVOoYW+T9KI71yjwf5junaPJbifMlmayY9VR+NMRGTynb/x4ash9Bi ZvHpbS0Jnlss/pRLcpdDfN+zr9CAoyD41YoAV36Z7qruOX5g9qPd674xGhwslVJRZick /7SZWJW1kSxrMS6DKiBJUQFfhhbE12qWfJXfKM0snvNGInOUgSvUH1otsONk57cALVUq z6Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776860747; x=1777465547; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pYI32RcMK+rIbb/42OAco+jjgy3p3bOcRS0/OXM4iEs=; b=kHpU1gYh0OK+AGokX/F02/L6KJkGE9ybdBMl453okKLFxmyUarZlpwC/ZJ0DWpNdyy lFZTf4VfsFBQQjurB8nYgzFj8CpSaQDNRhkSZqz2yjKiBLZ8owPqcSmx+X4G78kEanOB RTl3CH/ZQxlDYpaZHVHZ+elYNfUd+8btsMMde9HzsWy4P0yZBdZx6iYJL+3H/mEMI2YV ekjuPNE9doLBhZcfJS/RO52sdEQv6KVjAjHjxTlMNwqt1u21zWyYEyS7T8HoXgWqYTnm Vx4rNsTXTLL8QQvCu87p7osR8Q+NgvHFCwW8z7EE7bs/W08lCVuPIERInFBJhJCOXC0h q8Ag== X-Gm-Message-State: AOJu0YwpcYvX2tkJHgU3iv4Co+2H0SV3TqHaT2HgXpxoKBT8kaMvSD+V Kl8S3+6GBvAhUPYmbW3AFC8J+AOrCqHQqLWJ5Qv8dmI5RWE4s4Ku+CxwpolbQeSGsQeQVNQI+S0 wB897nyfpxDYNB5zwVJ/IPaazLSHD+BpYbwKCaCGpddd7L2zcW2kcJaZta8PzH8alPg== X-Gm-Gg: AeBDievYlXYUUlCoOtAizDPcW5i/hXbUtvRG1LvcQ8fYu3Q5qHYrLxayEjJ9GwQFGPu YeeBnU/mfbSjNMVpt+tIAPBvSOdLlFa1CjLxQgKuZNNWTMK2zLzf34c4P/tMQ0scrOAfprYfYC2 FhqYxNCBMMWZsm2b6J/6wpOIS9bKkc1fw4U88wShxP5B+MRVUIKbrNT4WWQwJJkqqoNdvmCA7jj JSxW1Rm1zrJ5pgAEHfVIdZOjKlMOdLxtKQNd9CQzk0lu7FJ+mrNW6GrUeXxwp4V3Ue2diYizHQe iACU/zqxDoiGo+fyDPKGzmKMUIRjf6HxQRStZ2HMMpUtWvq7u4XelLgp4CEGmVYEnn1cejkoi4I iaUK5Q6vBX5zwM2Luvi9KHOsWFTdG23WP6kykxvGZ39FOsBjrZ/JBjhVzdm3TrvCfOMDSHebU8t SINS410rGmYW1/Lw== X-Received: by 2002:a05:622a:1f88:b0:50f:bfe3:a04e with SMTP id d75a77b69052e-50fbfe3a765mr27128071cf.7.1776860746795; Wed, 22 Apr 2026 05:25:46 -0700 (PDT) X-Received: by 2002:a05:622a:1f88:b0:50f:bfe3:a04e with SMTP id d75a77b69052e-50fbfe3a765mr27127801cf.7.1776860746428; Wed, 22 Apr 2026 05:25:46 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-672c480d735sm3230047a12.7.2026.04.22.05.25.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 05:25:45 -0700 (PDT) Message-ID: Date: Wed, 22 Apr 2026 14:25:42 +0200 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec() To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> <20260422-iris-code-improvement-v1-6-8e150482212d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260422-iris-code-improvement-v1-6-8e150482212d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: jvgWwvkByqlkoM-sVKGrvByWly8uVH8F X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEyMCBTYWx0ZWRfX9Kd4ubceUAYB JuFFx/0/OXhcGl6dTc0koU57rSuXCPkStdbwJ8kSQtXPIrx+iul05i15WXYFzb0spT4hWtorkRj 2OqJ68nvfAItKQ0efZpiRhZ+q9+jftkc2wz6HwwHsvQR/Tw6m4mzOK5+panDucMW+iIomn+cYUe EeAbJXCDpY1JgOT0R3XOYG0KIojuwSRVEBuNw86QusGwwOuspbi9cSwBs4RlBeUCepAMKzuwPm4 9BY43w7USQf4nxGacNOzwZwCp6H0qo4wDbtnafhKqY1aCCz5AzuqrZwatd+/Z8PLaRwulUWyz4N bu76g49WAT52YZNoQ9dIWq65N2YXbyvDqugEkSOPqa2bQYN+a/UABWHJifnIBwjAeDtJfcLISdJ 4LNEHlWlnPa0FpW1oGVrGQb3E8iVE0d8/DuvVyOkfHQi0PnA/UqmFodI5Ka8H/c/tnNu03KQlZA RYA2p824nn+KrulYJ9Q== X-Authority-Analysis: v=2.4 cv=WKJPmHsR c=1 sm=1 tr=0 ts=69e8be4b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=4W0TTdc1l3xnTvgem7MA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: jvgWwvkByqlkoM-sVKGrvByWly8uVH8F X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220120 On 4/22/26 1:16 PM, Dikshita Agarwal wrote: > Without the break the AV1 case falls through, risking unintended behaviour > if new cases are added after it. > > Fixes: 2af481a459a4 ("media: iris: Define AV1-specific platform capabilities and properties") > Signed-off-by: Dikshita Agarwal > --- 'fixes' is debatable here but anyway Reviewed-by: Konrad Dybcio Konrad