From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80D0839023F; Fri, 13 Mar 2026 11:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773401214; cv=none; b=SagFjF2pcVlMwqMJqSbi5JpcxVH/p0zKF34ChjAx1Mz2rw14nsy3J3iOsS58sOl2pSgRnzPCJA/l5oicT9BwOeSbHJx9vm0i9euipnMlDKN3+zC9hYDXzWyqis0/xJGhBDXvJXrdbfur8+b11vDFh8GBpS3lPMGo+I1I3Ehhd/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773401214; c=relaxed/simple; bh=eg6KebwN4fAq2cOS/0FOuwPpitLLxIN5MQAFQp3A4Fk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HE52xEAJp5TAs+bVtpjxHWlryekGk1vLlW1Wr3arxjrSCM3dT9nBaEmqkxckeXv902VWCFPHkRmEKJWsv6nnTWEbojHwfq8Semd2mwGGBno0dXVoQvHgddPXi8ZwVvvhcSVnkTQhq8Mnj7gJUUrsL9LX+oKdNuhhy+bfabGBIf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=Xjnh8QDw; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Xjnh8QDw" Received: from [192.168.0.43] (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0609FF52; Fri, 13 Mar 2026 12:25:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773401140; bh=eg6KebwN4fAq2cOS/0FOuwPpitLLxIN5MQAFQp3A4Fk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Xjnh8QDwDi+L9vAdXDNhsKizfnXOj6dCZHUlS8PYGgc3bAArMY1VAU82kmjpZlwqI CcSxVXkAMWLYEBpoAIdlX7sks2ocppy/7Lz6RzQnsbS3jGC8RzPpkjprtLKCIUrRER Y4kDEm5ceZKsIOjgxwQY0gQfHwMuwz5zxRz8U68w= Message-ID: Date: Fri, 13 Mar 2026 11:26:46 +0000 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] media: mali-c55: Fix wrong comment of ISP block types To: Jacopo Mondi , Anthony McGivern , Vincenzo Frascino , Nayden Kanchev , Konstantin Babin , =?UTF-8?Q?Barnab=C3=A1s_P=C5=91cze?= , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260313-mali-c55-fixes-v7-0-v1-0-21805b2b516b@ideasonboard.com> <20260313-mali-c55-fixes-v7-0-v1-1-21805b2b516b@ideasonboard.com> Content-Language: en-US From: Dan Scally In-Reply-To: <20260313-mali-c55-fixes-v7-0-v1-1-21805b2b516b@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jacopo On 13/03/2026 10:49, Jacopo Mondi wrote: > Some bad copy&paste happened in the description of the ISP block types > and AWB_CONFIG got mixed up with SHADING_CONFIG. > > Fix it by assigning to each block the correct type. > > As only the comment is changed, there is no uABI breakage or regression. > > Cc: stable@vger.kernel.org > Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") > Signed-off-by: Jacopo Mondi > --- Reviewed-by: Daniel Scally > drivers/media/platform/arm/mali-c55/mali-c55-params.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-params.c b/drivers/media/platform/arm/mali-c55/mali-c55-params.c > index be0e909bcf29..c03a6120ddbf 100644 > --- a/drivers/media/platform/arm/mali-c55/mali-c55-params.c > +++ b/drivers/media/platform/arm/mali-c55/mali-c55-params.c > @@ -43,9 +43,9 @@ > * @digital_gain: For header->type == MALI_C55_PARAM_BLOCK_DIGITAL_GAIN > * @awb_gains: For header->type == MALI_C55_PARAM_BLOCK_AWB_GAINS and > * header->type = MALI_C55_PARAM_BLOCK_AWB_GAINS_AEXP > - * @awb_config: For header->type == MALI_C55_PARAM_MESH_SHADING_CONFIG > - * @shading_config: For header->type == MALI_C55_PARAM_MESH_SHADING_SELECTION > - * @shading_selection: For header->type == MALI_C55_PARAM_BLOCK_SENSOR_OFFS > + * @awb_config: For header->type == MALI_C55_PARAM_BLOCK_AWB_CONFIG > + * @shading_config: For header->type == MALI_C55_PARAM_MESH_SHADING_CONFIG > + * @shading_selection: For header->type == MALI_C55_PARAM_MESH_SHADING_SELECTION > * @data: Allows easy initialisation of a union variable with a > * pointer into a __u8 array. > */ >