* [PATCH v9 1/5] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible
2026-01-21 18:31 [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk Nihal Kumar Gupta
@ 2026-01-21 18:31 ` Nihal Kumar Gupta
2026-02-04 15:58 ` Andi Shyti
2026-02-06 16:34 ` Krzysztof Kozlowski
2026-01-21 18:31 ` [PATCH v9 2/5] arm64: dts: qcom: monaco: Add CCI definitions Nihal Kumar Gupta
` (4 subsequent siblings)
5 siblings, 2 replies; 19+ messages in thread
From: Nihal Kumar Gupta @ 2026-01-21 18:31 UTC (permalink / raw)
To: bryan.odonoghue, robh, krzk+dt, conor+dt, andersson, konradybcio,
hverkuil-cisco, loic.poulain, rfoss, andi.shyti, linux-i2c,
cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Vladimir Zapolskiy
The three instances of CCI found on the QCS8300 are functionally the same
as on a number of existing Qualcomm SoCs.
Introduce a new SoC-specific compatible string "qcom,qcs8300-cci" with a
common fallback.
Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
index a3fe1eea6aec..399a09409e07 100644
--- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
+++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
@@ -28,6 +28,7 @@ properties:
- enum:
- qcom,kaanapali-cci
- qcom,qcm2290-cci
+ - qcom,qcs8300-cci
- qcom,sa8775p-cci
- qcom,sc7280-cci
- qcom,sc8280xp-cci
@@ -133,6 +134,7 @@ allOf:
enum:
- qcom,kaanapali-cci
- qcom,qcm2290-cci
+ - qcom,qcs8300-cci
- qcom,sm8750-cci
then:
properties:
--
2.34.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v9 1/5] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible
2026-01-21 18:31 ` [PATCH v9 1/5] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible Nihal Kumar Gupta
@ 2026-02-04 15:58 ` Andi Shyti
2026-02-06 16:34 ` Krzysztof Kozlowski
2026-02-06 16:34 ` Krzysztof Kozlowski
1 sibling, 1 reply; 19+ messages in thread
From: Andi Shyti @ 2026-02-04 15:58 UTC (permalink / raw)
To: Nihal Kumar Gupta
Cc: bryan.odonoghue, robh, krzk+dt, conor+dt, andersson, konradybcio,
hverkuil-cisco, loic.poulain, rfoss, linux-i2c,
cros-qcom-dts-watchers, quic_svankada, linux-media, linux-arm-msm,
devicetree, linux-kernel, Vladimir Zapolskiy
Hi Nihal,
On Thu, Jan 22, 2026 at 12:01:38AM +0530, Nihal Kumar Gupta wrote:
> The three instances of CCI found on the QCS8300 are functionally the same
> as on a number of existing Qualcomm SoCs.
>
> Introduce a new SoC-specific compatible string "qcom,qcs8300-cci" with a
> common fallback.
>
> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
just this patch merged to i2c/i2c-host-2(*)
Thanks,
Andi
(*) The pull request for i2c/i2c-host-2 will be sent in the
middle of the merge window.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v9 1/5] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible
2026-02-04 15:58 ` Andi Shyti
@ 2026-02-06 16:34 ` Krzysztof Kozlowski
0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-06 16:34 UTC (permalink / raw)
To: Andi Shyti, Nihal Kumar Gupta
Cc: bryan.odonoghue, robh, krzk+dt, conor+dt, andersson, konradybcio,
hverkuil-cisco, loic.poulain, rfoss, linux-i2c,
cros-qcom-dts-watchers, quic_svankada, linux-media, linux-arm-msm,
devicetree, linux-kernel, Vladimir Zapolskiy
On 04/02/2026 16:58, Andi Shyti wrote:
> Hi Nihal,
>
> On Thu, Jan 22, 2026 at 12:01:38AM +0530, Nihal Kumar Gupta wrote:
>> The three instances of CCI found on the QCS8300 are functionally the same
>> as on a number of existing Qualcomm SoCs.
>>
>> Introduce a new SoC-specific compatible string "qcom,qcs8300-cci" with a
>> common fallback.
>>
>> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>
> just this patch merged to i2c/i2c-host-2(*)
>
> Thanks,
> Andi
>
> (*) The pull request for i2c/i2c-host-2 will be sent in the
> middle of the merge window.
No, drop, it has wrong chain.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v9 1/5] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible
2026-01-21 18:31 ` [PATCH v9 1/5] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible Nihal Kumar Gupta
2026-02-04 15:58 ` Andi Shyti
@ 2026-02-06 16:34 ` Krzysztof Kozlowski
1 sibling, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-06 16:34 UTC (permalink / raw)
To: Nihal Kumar Gupta, bryan.odonoghue, robh, krzk+dt, conor+dt,
andersson, konradybcio, hverkuil-cisco, loic.poulain, rfoss,
andi.shyti, linux-i2c, cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Vladimir Zapolskiy
On 21/01/2026 19:31, Nihal Kumar Gupta wrote:
> The three instances of CCI found on the QCS8300 are functionally the same
> as on a number of existing Qualcomm SoCs.
>
> Introduce a new SoC-specific compatible string "qcom,qcs8300-cci" with a
> common fallback.
>
> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
Incorrect SoB chain.
Having this broken at v9 is surprising.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v9 2/5] arm64: dts: qcom: monaco: Add CCI definitions
2026-01-21 18:31 [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk Nihal Kumar Gupta
2026-01-21 18:31 ` [PATCH v9 1/5] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible Nihal Kumar Gupta
@ 2026-01-21 18:31 ` Nihal Kumar Gupta
2026-02-06 16:37 ` Krzysztof Kozlowski
2026-01-21 18:31 ` [PATCH v9 3/5] arm64: dts: qcom: monaco: Add camera MCLK pinctrl Nihal Kumar Gupta
` (3 subsequent siblings)
5 siblings, 1 reply; 19+ messages in thread
From: Nihal Kumar Gupta @ 2026-01-21 18:31 UTC (permalink / raw)
To: bryan.odonoghue, robh, krzk+dt, conor+dt, andersson, konradybcio,
hverkuil-cisco, loic.poulain, rfoss, andi.shyti, linux-i2c,
cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Ravi Shankar, Vishal Verma, Vladimir Zapolskiy,
Konrad Dybcio
Qualcomm QCS8300 SoC contains three Camera Control Interface (CCI).
Compared to Lemans, the key difference is in SDA/SCL GPIO assignments
and number of CCIs.
Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
Co-developed-by: Ravi Shankar <quic_rshankar@quicinc.com>
Signed-off-by: Ravi Shankar <quic_rshankar@quicinc.com>
Co-developed-by: Vishal Verma <quic_vishverm@quicinc.com>
Signed-off-by: Vishal Verma <quic_vishverm@quicinc.com>
Co-developed-by: Suresh Vankadara <quic_svankada@quicinc.com>
Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com>
Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/monaco.dtsi | 303 +++++++++++++++++++++++++++
1 file changed, 303 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
index 5d2df4305d1c..634337611012 100644
--- a/arch/arm64/boot/dts/qcom/monaco.dtsi
+++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
@@ -5319,6 +5319,117 @@ videocc: clock-controller@abf0000 {
#power-domain-cells = <1>;
};
+ cci0: cci@ac13000 {
+ compatible = "qcom,qcs8300-cci", "qcom,msm8996-cci";
+ reg = <0x0 0x0ac13000 0x0 0x1000>;
+
+ interrupts = <GIC_SPI 460 IRQ_TYPE_EDGE_RISING>;
+
+ clocks = <&camcc CAM_CC_CPAS_AHB_CLK>,
+ <&camcc CAM_CC_CCI_0_CLK>;
+ clock-names = "cpas_ahb",
+ "cci";
+
+ power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>;
+
+ pinctrl-0 = <&cci0_0_default &cci0_1_default>;
+ pinctrl-1 = <&cci0_0_sleep &cci0_1_sleep>;
+ pinctrl-names = "default", "sleep";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ status = "disabled";
+
+ cci0_i2c0: i2c-bus@0 {
+ reg = <0>;
+ clock-frequency = <1000000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ cci0_i2c1: i2c-bus@1 {
+ reg = <1>;
+ clock-frequency = <1000000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
+ cci1: cci@ac14000 {
+ compatible = "qcom,qcs8300-cci", "qcom,msm8996-cci";
+ reg = <0x0 0x0ac14000 0x0 0x1000>;
+
+ interrupts = <GIC_SPI 271 IRQ_TYPE_EDGE_RISING>;
+
+ clocks = <&camcc CAM_CC_CPAS_AHB_CLK>,
+ <&camcc CAM_CC_CCI_1_CLK>;
+ clock-names = "cpas_ahb",
+ "cci";
+
+ power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>;
+
+ pinctrl-0 = <&cci1_0_default &cci1_1_default>;
+ pinctrl-1 = <&cci1_0_sleep &cci1_1_sleep>;
+ pinctrl-names = "default", "sleep";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ status = "disabled";
+
+ cci1_i2c0: i2c-bus@0 {
+ reg = <0>;
+ clock-frequency = <1000000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ cci1_i2c1: i2c-bus@1 {
+ reg = <1>;
+ clock-frequency = <1000000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
+ cci2: cci@ac15000 {
+ compatible = "qcom,qcs8300-cci", "qcom,msm8996-cci";
+ reg = <0x0 0x0ac15000 0x0 0x1000>;
+
+ interrupts = <GIC_SPI 651 IRQ_TYPE_EDGE_RISING>;
+
+ clocks = <&camcc CAM_CC_CPAS_AHB_CLK>,
+ <&camcc CAM_CC_CCI_2_CLK>;
+ clock-names = "cpas_ahb",
+ "cci";
+
+ power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>;
+
+ pinctrl-0 = <&cci2_0_default &cci2_1_default>;
+ pinctrl-1 = <&cci2_0_sleep &cci2_1_sleep>;
+ pinctrl-names = "default", "sleep";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ status = "disabled";
+
+ cci2_i2c0: i2c-bus@0 {
+ reg = <0>;
+ clock-frequency = <1000000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ cci2_i2c1: i2c-bus@1 {
+ reg = <1>;
+ clock-frequency = <1000000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+ };
+
camss: isp@ac78000 {
compatible = "qcom,qcs8300-camss";
@@ -5876,6 +5987,198 @@ tlmm: pinctrl@f100000 {
#interrupt-cells = <2>;
wakeup-parent = <&pdc>;
+ cci0_0_default: cci0-0-default-state {
+ sda-pins {
+ pins = "gpio57";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+
+ scl-pins {
+ pins = "gpio58";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+ };
+
+ cci0_0_sleep: cci0-0-sleep-state {
+ sda-pins {
+ pins = "gpio57";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ scl-pins {
+ pins = "gpio58";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+ };
+
+ cci0_1_default: cci0-1-default-state {
+ sda-pins {
+ pins = "gpio29";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+
+ scl-pins {
+ pins = "gpio30";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+ };
+
+ cci0_1_sleep: cci0-1-sleep-state {
+ sda-pins {
+ pins = "gpio29";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ scl-pins {
+ pins = "gpio30";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+ };
+
+ cci1_0_default: cci1-0-default-state {
+ sda-pins {
+ pins = "gpio59";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+
+ scl-pins {
+ pins = "gpio60";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+ };
+
+ cci1_0_sleep: cci1-0-sleep-state {
+ sda-pins {
+ pins = "gpio59";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ scl-pins {
+ pins = "gpio60";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+ };
+
+ cci1_1_default: cci1-1-default-state {
+ sda-pins {
+ pins = "gpio31";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+
+ scl-pins {
+ pins = "gpio32";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+ };
+
+ cci1_1_sleep: cci1-1-sleep-state {
+ sda-pins {
+ pins = "gpio31";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ scl-pins {
+ pins = "gpio32";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+ };
+
+ cci2_0_default: cci2-0-default-state {
+ sda-pins {
+ pins = "gpio61";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+
+ scl-pins {
+ pins = "gpio62";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+ };
+
+ cci2_0_sleep: cci2-0-sleep-state {
+ sda-pins {
+ pins = "gpio61";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ scl-pins {
+ pins = "gpio62";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+ };
+
+ cci2_1_default: cci2-1-default-state {
+ sda-pins {
+ pins = "gpio54";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+
+ scl-pins {
+ pins = "gpio55";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-up = <2200>;
+ };
+ };
+
+ cci2_1_sleep: cci2-1-sleep-state {
+ sda-pins {
+ pins = "gpio54";
+ function = "cci_i2c_sda";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ scl-pins {
+ pins = "gpio55";
+ function = "cci_i2c_scl";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+ };
+
hs0_mi2s_active: hs0-mi2s-active-state {
pins = "gpio106", "gpio107", "gpio108", "gpio109";
function = "hs0_mi2s";
--
2.34.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v9 2/5] arm64: dts: qcom: monaco: Add CCI definitions
2026-01-21 18:31 ` [PATCH v9 2/5] arm64: dts: qcom: monaco: Add CCI definitions Nihal Kumar Gupta
@ 2026-02-06 16:37 ` Krzysztof Kozlowski
2026-02-09 16:14 ` Nihal Kumar Gupta
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-06 16:37 UTC (permalink / raw)
To: Nihal Kumar Gupta, bryan.odonoghue, robh, krzk+dt, conor+dt,
andersson, konradybcio, hverkuil-cisco, loic.poulain, rfoss,
andi.shyti, linux-i2c, cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Ravi Shankar, Vishal Verma, Vladimir Zapolskiy,
Konrad Dybcio
On 21/01/2026 19:31, Nihal Kumar Gupta wrote:
> Qualcomm QCS8300 SoC contains three Camera Control Interface (CCI).
> Compared to Lemans, the key difference is in SDA/SCL GPIO assignments
> and number of CCIs.
>
> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
> Co-developed-by: Ravi Shankar <quic_rshankar@quicinc.com>
> Signed-off-by: Ravi Shankar <quic_rshankar@quicinc.com>
> Co-developed-by: Vishal Verma <quic_vishverm@quicinc.com>
> Signed-off-by: Vishal Verma <quic_vishverm@quicinc.com>
> Co-developed-by: Suresh Vankadara <quic_svankada@quicinc.com>
> Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
Wrong DCO chain. And above looks like total mess...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v9 2/5] arm64: dts: qcom: monaco: Add CCI definitions
2026-02-06 16:37 ` Krzysztof Kozlowski
@ 2026-02-09 16:14 ` Nihal Kumar Gupta
0 siblings, 0 replies; 19+ messages in thread
From: Nihal Kumar Gupta @ 2026-02-09 16:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, bryan.odonoghue, robh, krzk+dt, conor+dt,
andersson, konradybcio, hverkuil-cisco, loic.poulain, rfoss,
andi.shyti, linux-i2c, cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Ravi Shankar, Vishal Verma, Vladimir Zapolskiy,
Konrad Dybcio
On 06-02-2026 22:07, Krzysztof Kozlowski wrote:
> On 21/01/2026 19:31, Nihal Kumar Gupta wrote:
>> Qualcomm QCS8300 SoC contains three Camera Control Interface (CCI).
>> Compared to Lemans, the key difference is in SDA/SCL GPIO assignments
>> and number of CCIs.
>>
>> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
>> Co-developed-by: Ravi Shankar <quic_rshankar@quicinc.com>
>> Signed-off-by: Ravi Shankar <quic_rshankar@quicinc.com>
>> Co-developed-by: Vishal Verma <quic_vishverm@quicinc.com>
>> Signed-off-by: Vishal Verma <quic_vishverm@quicinc.com>
>> Co-developed-by: Suresh Vankadara <quic_svankada@quicinc.com>
>> Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com>
>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> Wrong DCO chain. And above looks like total mess...
Understood regarding the DCO ordering. Until v6, Vikram was sending the
series, so his Signed-off-by was placed first. I have now taken over
maintaining and sending the patches, and the previous tags were left
behind unintentionally.
I will correct the chain so that the primary author’s Signed-off-by
comes first, followed by any Co-developed-by + Signed-off-by entries,
and send an updated revision.
--
Regards,
Nihal Kumar Gupta
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v9 3/5] arm64: dts: qcom: monaco: Add camera MCLK pinctrl
2026-01-21 18:31 [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk Nihal Kumar Gupta
2026-01-21 18:31 ` [PATCH v9 1/5] dt-bindings: i2c: qcom-cci: Document qcs8300 compatible Nihal Kumar Gupta
2026-01-21 18:31 ` [PATCH v9 2/5] arm64: dts: qcom: monaco: Add CCI definitions Nihal Kumar Gupta
@ 2026-01-21 18:31 ` Nihal Kumar Gupta
2026-01-21 18:31 ` [PATCH v9 4/5] arm64: dts: qcom: monaco-evk: Add camera AVDD regulators Nihal Kumar Gupta
` (2 subsequent siblings)
5 siblings, 0 replies; 19+ messages in thread
From: Nihal Kumar Gupta @ 2026-01-21 18:31 UTC (permalink / raw)
To: bryan.odonoghue, robh, krzk+dt, conor+dt, andersson, konradybcio,
hverkuil-cisco, loic.poulain, rfoss, andi.shyti, linux-i2c,
cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Konrad Dybcio, Vladimir Zapolskiy
Define pinctrl definitions to enable camera master clocks on Monaco.
Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
arch/arm64/boot/dts/qcom/monaco.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
index 634337611012..0c0d7fa09cfb 100644
--- a/arch/arm64/boot/dts/qcom/monaco.dtsi
+++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
@@ -5987,6 +5987,27 @@ tlmm: pinctrl@f100000 {
#interrupt-cells = <2>;
wakeup-parent = <&pdc>;
+ cam0_default: cam0-default-state {
+ pins = "gpio67";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ cam1_default: cam1-default-state {
+ pins = "gpio68";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ cam2_default: cam2-default-state {
+ pins = "gpio69";
+ function = "cam_mclk";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
cci0_0_default: cci0-0-default-state {
sda-pins {
pins = "gpio57";
--
2.34.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH v9 4/5] arm64: dts: qcom: monaco-evk: Add camera AVDD regulators
2026-01-21 18:31 [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk Nihal Kumar Gupta
` (2 preceding siblings ...)
2026-01-21 18:31 ` [PATCH v9 3/5] arm64: dts: qcom: monaco: Add camera MCLK pinctrl Nihal Kumar Gupta
@ 2026-01-21 18:31 ` Nihal Kumar Gupta
2026-02-06 16:15 ` Vladimir Zapolskiy
2026-01-21 18:31 ` [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay Nihal Kumar Gupta
2026-01-22 3:10 ` [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk Rob Herring
5 siblings, 1 reply; 19+ messages in thread
From: Nihal Kumar Gupta @ 2026-01-21 18:31 UTC (permalink / raw)
To: bryan.odonoghue, robh, krzk+dt, conor+dt, andersson, konradybcio,
hverkuil-cisco, loic.poulain, rfoss, andi.shyti, linux-i2c,
cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Konrad Dybcio
Define three fixed regulators for camera AVDD rails, each gpio-controlled
with corresponding pinctrl definitions.
Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/monaco-evk.dts | 51 +++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
index 565418b86b2a..65c1b49c6dfb 100644
--- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
@@ -77,6 +77,36 @@ platform {
};
};
};
+
+ vreg_cam0_2p8: vreg-cam0-2p8 {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_cam0_2p8";
+ startup-delay-us = <10000>;
+ enable-active-high;
+ gpio = <&tlmm 73 GPIO_ACTIVE_HIGH>;
+ pinctrl-0 = <&cam0_avdd_2v8_en_default>;
+ pinctrl-names = "default";
+ };
+
+ vreg_cam1_2p8: vreg-cam1-2p8 {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_cam1_2p8";
+ startup-delay-us = <10000>;
+ enable-active-high;
+ gpio = <&tlmm 74 GPIO_ACTIVE_HIGH>;
+ pinctrl-0 = <&cam1_avdd_2v8_en_default>;
+ pinctrl-names = "default";
+ };
+
+ vreg_cam2_2p8: vreg-cam2-2p8 {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_cam2_2p8";
+ startup-delay-us = <10000>;
+ enable-active-high;
+ gpio = <&tlmm 75 GPIO_ACTIVE_HIGH>;
+ pinctrl-0 = <&cam2_avdd_2v8_en_default>;
+ pinctrl-names = "default";
+ };
};
&apps_rsc {
@@ -564,6 +594,27 @@ perst-pins {
};
};
+ cam0_avdd_2v8_en_default: cam0-avdd-2v8-en-state {
+ pins = "gpio73";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ cam1_avdd_2v8_en_default: cam1-avdd-2v8-en-state {
+ pins = "gpio74";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ cam2_avdd_2v8_en_default: cam2-avdd-2v8-en-state {
+ pins = "gpio75";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
qup_i2c15_default: qup-i2c15-state {
pins = "gpio91", "gpio92";
function = "qup1_se7";
--
2.34.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v9 4/5] arm64: dts: qcom: monaco-evk: Add camera AVDD regulators
2026-01-21 18:31 ` [PATCH v9 4/5] arm64: dts: qcom: monaco-evk: Add camera AVDD regulators Nihal Kumar Gupta
@ 2026-02-06 16:15 ` Vladimir Zapolskiy
0 siblings, 0 replies; 19+ messages in thread
From: Vladimir Zapolskiy @ 2026-02-06 16:15 UTC (permalink / raw)
To: Nihal Kumar Gupta, bryan.odonoghue, robh, krzk+dt, conor+dt,
andersson, konradybcio, hverkuil-cisco, loic.poulain, rfoss,
andi.shyti, linux-i2c, cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Konrad Dybcio
On 1/21/26 20:31, Nihal Kumar Gupta wrote:
> Define three fixed regulators for camera AVDD rails, each gpio-controlled
> with corresponding pinctrl definitions.
>
> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/monaco-evk.dts | 51 +++++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index 565418b86b2a..65c1b49c6dfb 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -77,6 +77,36 @@ platform {
> };
> };
> };
> +
> + vreg_cam0_2p8: vreg-cam0-2p8 {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_cam0_2p8";
> + startup-delay-us = <10000>;
> + enable-active-high;
> + gpio = <&tlmm 73 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&cam0_avdd_2v8_en_default>;
> + pinctrl-names = "default";
> + };
> +
> + vreg_cam1_2p8: vreg-cam1-2p8 {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_cam1_2p8";
> + startup-delay-us = <10000>;
> + enable-active-high;
> + gpio = <&tlmm 74 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&cam1_avdd_2v8_en_default>;
> + pinctrl-names = "default";
> + };
> +
> + vreg_cam2_2p8: vreg-cam2-2p8 {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_cam2_2p8";
> + startup-delay-us = <10000>;
> + enable-active-high;
> + gpio = <&tlmm 75 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&cam2_avdd_2v8_en_default>;
> + pinctrl-names = "default";
Since voltage level is known for all three regulators, why not to add
regulator-min-microvolt = <2800000>;
regulator-max-microvolt = <2800000>;
properties?
> + }
> };
>
> &apps_rsc {
> @@ -564,6 +594,27 @@ perst-pins {
> };
> };
>
> + cam0_avdd_2v8_en_default: cam0-avdd-2v8-en-state {
> + pins = "gpio73";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + cam1_avdd_2v8_en_default: cam1-avdd-2v8-en-state {
> + pins = "gpio74";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + cam2_avdd_2v8_en_default: cam2-avdd-2v8-en-state {
> + pins = "gpio75";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> qup_i2c15_default: qup-i2c15-state {
> pins = "gpio91", "gpio92";
> function = "qup1_se7";
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
2026-01-21 18:31 [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk Nihal Kumar Gupta
` (3 preceding siblings ...)
2026-01-21 18:31 ` [PATCH v9 4/5] arm64: dts: qcom: monaco-evk: Add camera AVDD regulators Nihal Kumar Gupta
@ 2026-01-21 18:31 ` Nihal Kumar Gupta
2026-02-06 16:39 ` Krzysztof Kozlowski
2026-01-22 3:10 ` [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk Rob Herring
5 siblings, 1 reply; 19+ messages in thread
From: Nihal Kumar Gupta @ 2026-01-21 18:31 UTC (permalink / raw)
To: bryan.odonoghue, robh, krzk+dt, conor+dt, andersson, konradybcio,
hverkuil-cisco, loic.poulain, rfoss, andi.shyti, linux-i2c,
cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Ravi Shankar, Vishal Verma, Vladimir Zapolskiy,
Konrad Dybcio
Monaco EVK board does not include a camera sensor in its default hardware
configuration. Introducing a device tree overlay to support optional
integration of the IMX577 sensor via CSIPHY1.
Camera reset is handled through an I2C expander, and power is enabled
via TLMM GPIO74.
An example media-ctl pipeline for the imx577 is:
media-ctl --reset
media-ctl -V '"imx577 3-001a":0[fmt:SRGGB10/4056x3040 field:none]'
media-ctl -V '"msm_csiphy1":0[fmt:SRGGB10/4056x3040]'
media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
media-ctl -l '"msm_csiphy1":1->"msm_csid0":0[1]'
media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video1
Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
Co-developed-by: Ravi Shankar <quic_rshankar@quicinc.com>
Signed-off-by: Ravi Shankar <quic_rshankar@quicinc.com>
Co-developed-by: Vishal Verma <quic_vishverm@quicinc.com>
Signed-off-by: Vishal Verma <quic_vishverm@quicinc.com>
Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/Makefile | 4 ++
.../dts/qcom/monaco-evk-camera-imx577.dtso | 66 +++++++++++++++++++
2 files changed, 70 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtso
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index f80b5d9cf1e8..4c348cf62d59 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -45,6 +45,10 @@ lemans-evk-el2-dtbs := lemans-evk.dtb lemans-el2.dtbo
dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-el2.dtb
dtb-$(CONFIG_ARCH_QCOM) += milos-fairphone-fp6.dtb
dtb-$(CONFIG_ARCH_QCOM) += monaco-evk.dtb
+
+monaco-evk-camera-imx577-dtbs := monaco-evk.dtb monaco-evk-camera-imx577.dtbo
+dtb-$(CONFIG_ARCH_QCOM) += monaco-evk-camera-imx577.dtb
+
dtb-$(CONFIG_ARCH_QCOM) += msm8216-samsung-fortuna3g.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb
diff --git a/arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtso
new file mode 100644
index 000000000000..0d5ccd020e6e
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtso
@@ -0,0 +1,66 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/clock/qcom,sa8775p-camcc.h>
+#include <dt-bindings/gpio/gpio.h>
+
+&camss {
+ vdda-phy-supply = <&vreg_l4a>;
+ vdda-pll-supply = <&vreg_l5a>;
+
+ status = "okay";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@1 {
+ reg = <1>;
+
+ csiphy1_ep: endpoint {
+ data-lanes = <0 1 2 3>;
+ remote-endpoint = <&imx577_ep1>;
+ };
+ };
+ };
+};
+
+&cci1 {
+ pinctrl-0 = <&cci1_0_default>;
+ pinctrl-1 = <&cci1_0_sleep>;
+
+ status = "okay";
+};
+
+&cci1_i2c0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera@1a {
+ compatible = "sony,imx577";
+ reg = <0x1a>;
+
+ reset-gpios = <&expander2 1 GPIO_ACTIVE_LOW>;
+ pinctrl-0 = <&cam1_default>;
+ pinctrl-names = "default";
+
+ clocks = <&camcc CAM_CC_MCLK1_CLK>;
+ assigned-clocks = <&camcc CAM_CC_MCLK1_CLK>;
+ assigned-clock-rates = <24000000>;
+
+ avdd-supply = <&vreg_cam1_2p8>;
+
+ port {
+ imx577_ep1: endpoint {
+ link-frequencies = /bits/ 64 <600000000>;
+ data-lanes = <1 2 3 4>;
+ remote-endpoint = <&csiphy1_ep>;
+ };
+ };
+ };
+};
--
2.34.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
2026-01-21 18:31 ` [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay Nihal Kumar Gupta
@ 2026-02-06 16:39 ` Krzysztof Kozlowski
2026-02-09 16:36 ` Nihal Kumar Gupta
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-06 16:39 UTC (permalink / raw)
To: Nihal Kumar Gupta, bryan.odonoghue, robh, krzk+dt, conor+dt,
andersson, konradybcio, hverkuil-cisco, loic.poulain, rfoss,
andi.shyti, linux-i2c, cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Ravi Shankar, Vishal Verma, Vladimir Zapolskiy,
Konrad Dybcio
On 21/01/2026 19:31, Nihal Kumar Gupta wrote:
> Monaco EVK board does not include a camera sensor in its default hardware
> configuration. Introducing a device tree overlay to support optional
> integration of the IMX577 sensor via CSIPHY1.
>
> Camera reset is handled through an I2C expander, and power is enabled
> via TLMM GPIO74.
>
> An example media-ctl pipeline for the imx577 is:
>
> media-ctl --reset
> media-ctl -V '"imx577 3-001a":0[fmt:SRGGB10/4056x3040 field:none]'
> media-ctl -V '"msm_csiphy1":0[fmt:SRGGB10/4056x3040]'
> media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
> media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
> media-ctl -l '"msm_csiphy1":1->"msm_csid0":0[1]'
> media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
> yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video1
>
> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
> Co-developed-by: Ravi Shankar <quic_rshankar@quicinc.com>
> Signed-off-by: Ravi Shankar <quic_rshankar@quicinc.com>
> Co-developed-by: Vishal Verma <quic_vishverm@quicinc.com>
> Signed-off-by: Vishal Verma <quic_vishverm@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 4 ++
> .../dts/qcom/monaco-evk-camera-imx577.dtso | 66 +++++++++++++++++++
> 2 files changed, 70 insertions(+)
So many people developed it, three people reviewed it, patch is at v9 and...
still was not build-tested by the author. At this point this is big
surprise.
NAK
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
2026-02-06 16:39 ` Krzysztof Kozlowski
@ 2026-02-09 16:36 ` Nihal Kumar Gupta
2026-02-09 16:38 ` Krzysztof Kozlowski
0 siblings, 1 reply; 19+ messages in thread
From: Nihal Kumar Gupta @ 2026-02-09 16:36 UTC (permalink / raw)
To: Krzysztof Kozlowski, bryan.odonoghue, robh, krzk+dt, conor+dt,
andersson, konradybcio, hverkuil-cisco, loic.poulain, rfoss,
andi.shyti, linux-i2c, cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Ravi Shankar, Vishal Verma, Vladimir Zapolskiy,
Konrad Dybcio
On 06-02-2026 22:09, Krzysztof Kozlowski wrote:
>> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
>> Co-developed-by: Ravi Shankar <quic_rshankar@quicinc.com>
>> Signed-off-by: Ravi Shankar <quic_rshankar@quicinc.com>
>> Co-developed-by: Vishal Verma <quic_vishverm@quicinc.com>
>> Signed-off-by: Vishal Verma <quic_vishverm@quicinc.com>
>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 4 ++
>> .../dts/qcom/monaco-evk-camera-imx577.dtso | 66 +++++++++++++++++++
>> 2 files changed, 70 insertions(+)
>
> So many people developed it, three people reviewed it, patch is at v9 and...
>
> still was not build-tested by the author. At this point this is big
> surprise.
>
> NAK
Krzysztof, Thanks for your review.
All patches posted here were build‑tested and verified by the author. On the current master tip, I am seeing an unrelated issue where RB4 fails to boot due to a rootfs mount error.
From next time, I’ll include the exact SHA on which the patches were validated.
Rootfs mount error log snippet:
Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)
[Firmware Bug]: Unable to handle paging request in EFI runtime service
[ end Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) ]
--
Regards,
Nihal Kumar Gupta
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
2026-02-09 16:36 ` Nihal Kumar Gupta
@ 2026-02-09 16:38 ` Krzysztof Kozlowski
2026-02-10 12:42 ` Nihal Kumar Gupta
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-09 16:38 UTC (permalink / raw)
To: Nihal Kumar Gupta, bryan.odonoghue, robh, krzk+dt, conor+dt,
andersson, konradybcio, hverkuil-cisco, loic.poulain, rfoss,
andi.shyti, linux-i2c, cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Ravi Shankar, Vishal Verma, Vladimir Zapolskiy,
Konrad Dybcio
On 09/02/2026 17:36, Nihal Kumar Gupta wrote:
>
>
> On 06-02-2026 22:09, Krzysztof Kozlowski wrote:
>>> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
>>> Co-developed-by: Ravi Shankar <quic_rshankar@quicinc.com>
>>> Signed-off-by: Ravi Shankar <quic_rshankar@quicinc.com>
>>> Co-developed-by: Vishal Verma <quic_vishverm@quicinc.com>
>>> Signed-off-by: Vishal Verma <quic_vishverm@quicinc.com>
>>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
>>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/Makefile | 4 ++
>>> .../dts/qcom/monaco-evk-camera-imx577.dtso | 66 +++++++++++++++++++
>>> 2 files changed, 70 insertions(+)
>>
>> So many people developed it, three people reviewed it, patch is at v9 and...
>>
>> still was not build-tested by the author. At this point this is big
>> surprise.
>>
>> NAK
>
> Krzysztof, Thanks for your review.
> All patches posted here were build‑tested and verified by the author.
Then please explain reported by Rob build-process warnings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
2026-02-09 16:38 ` Krzysztof Kozlowski
@ 2026-02-10 12:42 ` Nihal Kumar Gupta
2026-02-10 12:51 ` Krzysztof Kozlowski
0 siblings, 1 reply; 19+ messages in thread
From: Nihal Kumar Gupta @ 2026-02-10 12:42 UTC (permalink / raw)
To: Krzysztof Kozlowski, bryan.odonoghue, robh, krzk+dt, conor+dt,
andersson, konradybcio, hverkuil-cisco, loic.poulain, rfoss,
andi.shyti, linux-i2c, cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Ravi Shankar, Vishal Verma, Vladimir Zapolskiy,
Konrad Dybcio
On 09-02-2026 22:08, Krzysztof Kozlowski wrote:
>> Krzysztof, Thanks for your review.
>> All patches posted here were build‑tested and verified by the author.
> Then please explain reported by Rob build-process warnings.
The dt-binding for qcom,qcs8300-cci specifies two clocks:
clock-names = "ahb", "cci";
On Monaco, the CCI node currently defines:
clock-names = "cpas_ahb", "cci";
The dt-binding warns because it expects the clock-names to be "ahb" and
"cci", while the Monaco DTS uses "cpas_ahb" instead of "ahb". The
hardware works correctly, but the name doesn't match the binding.
Renaming "cpas_ahb" to "ahb" aligns the DTS with the binding and clears
the warning. Please advise if you prefer a different approach.
--
Regards,
Nihal Kumar Gupta
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
2026-02-10 12:42 ` Nihal Kumar Gupta
@ 2026-02-10 12:51 ` Krzysztof Kozlowski
2026-02-11 13:39 ` Nihal Kumar Gupta
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-10 12:51 UTC (permalink / raw)
To: Nihal Kumar Gupta, bryan.odonoghue, robh, krzk+dt, conor+dt,
andersson, konradybcio, hverkuil-cisco, loic.poulain, rfoss,
andi.shyti, linux-i2c, cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Ravi Shankar, Vishal Verma, Vladimir Zapolskiy,
Konrad Dybcio
On 10/02/2026 13:42, Nihal Kumar Gupta wrote:
>
>
> On 09-02-2026 22:08, Krzysztof Kozlowski wrote:
>>> Krzysztof, Thanks for your review.
>>> All patches posted here were build‑tested and verified by the author.
>> Then please explain reported by Rob build-process warnings.
>
> The dt-binding for qcom,qcs8300-cci specifies two clocks:
> clock-names = "ahb", "cci";
>
> On Monaco, the CCI node currently defines:
> clock-names = "cpas_ahb", "cci";
>
> The dt-binding warns because it expects the clock-names to be "ahb" and
> "cci", while the Monaco DTS uses "cpas_ahb" instead of "ahb". The
> hardware works correctly, but the name doesn't match the binding.
> Renaming "cpas_ahb" to "ahb" aligns the DTS with the binding and clears
> the warning. Please advise if you prefer a different approach.
I said this was not build-time tested. I gave a proof of that.
You said it was build tested but you confirm it has build error.
Listen, when tools report you errors and maintainers say your code does
not pass basic tests, don't insist that this was basic tested.
It was not and discussing this just wastes our time. I am not going to
spend more time on this discussion, wasted already too much.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay
2026-02-10 12:51 ` Krzysztof Kozlowski
@ 2026-02-11 13:39 ` Nihal Kumar Gupta
0 siblings, 0 replies; 19+ messages in thread
From: Nihal Kumar Gupta @ 2026-02-11 13:39 UTC (permalink / raw)
To: Krzysztof Kozlowski, bryan.odonoghue, robh, krzk+dt, conor+dt,
andersson, konradybcio, hverkuil-cisco, loic.poulain, rfoss,
andi.shyti, linux-i2c, cros-qcom-dts-watchers
Cc: quic_svankada, linux-media, linux-arm-msm, devicetree,
linux-kernel, Ravi Shankar, Vishal Verma, Vladimir Zapolskiy,
Konrad Dybcio
On 10-02-2026 18:21, Krzysztof Kozlowski wrote:
>> Renaming "cpas_ahb" to "ahb" aligns the DTS with the binding and clears
>> the warning. Please advise if you prefer a different approach.
> I said this was not build-time tested. I gave a proof of that.
>
> You said it was build tested but you confirm it has build error.
>
> Listen, when tools report you errors and maintainers say your code does
> not pass basic tests, don't insist that this was basic tested.
>
> It was not and discussing this just wastes our time. I am not going to
> spend more time on this discussion, wasted already too much.
Apologies for the inconvenience, Krzysztof.
I will discuss this internally with the team and resend the patch accordingly.
--
Regards,
Nihal Kumar Gupta
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk
2026-01-21 18:31 [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk Nihal Kumar Gupta
` (4 preceding siblings ...)
2026-01-21 18:31 ` [PATCH v9 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay Nihal Kumar Gupta
@ 2026-01-22 3:10 ` Rob Herring
5 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2026-01-22 3:10 UTC (permalink / raw)
To: Nihal Kumar Gupta
Cc: cros-qcom-dts-watchers, rfoss, quic_svankada, linux-i2c,
linux-kernel, bryan.odonoghue, devicetree, linux-media,
konradybcio, hverkuil-cisco, krzk+dt, andersson, andi.shyti,
conor+dt, linux-arm-msm, loic.poulain
On Thu, 22 Jan 2026 00:01:37 +0530, Nihal Kumar Gupta wrote:
> From: Nihal Kumar Gupta <nihalkum@qti.qualcomm.com>
>
> Monaco EVK is a single-board computer based on the Qualcomm QCS8300 SoC.
> It lacks a camera sensor in its default configuration.
> This series adds CCI support and enables the IMX577 sensor via CSIPHY1
> through device tree overlay.
>
> We have tested IMX577 Sensor on CCI1 with following commands:
> - media-ctl --reset
> - media-ctl -V '"imx577 3-001a":0[fmt:SRGGB10/4056x3040 field:none]'
> - media-ctl -V '"msm_csiphy1":0[fmt:SRGGB10/4056x3040]'
> - media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
> - media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
> - media-ctl -l '"msm_csiphy1":1->"msm_csid0":0[1]'
> - media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
> - yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video1
> ---
>
> Changes in v9:
> - Added i2c maintainers and linux-i2c mailing list for the qcom,i2c-cci.yaml
> dt-bindings patch - Bryan
> - Rebased onto the latest master.
> - Link to v8:
> https://lore.kernel.org/all/20251222095914.1995041-1-quic_nihalkum@quicinc.com
>
> Changes in v8:
> - Removed clock-lanes property from CAMSS node - Vladimir
> - Changed data-lanes property to <1 2 3 4> on sensor node - Vladimir
> - Sorted regulator entries with respect to the pin index - Konrad
> - Link to v7:
> https://lore.kernel.org/all/20251216062223.2474216-1-quic_nihalkum@quicinc.com
>
> Changes in v7:
> - Define MCLK pinctrl definitions in monaco.dtsi - Konrad and Vladimir
> - Define fixed regulators for camera AVDD rails in monaco-evk.dts - Konrad
> - Link to v6:
> https://lore.kernel.org/all/20251126081057.4191122-1-quic_vikramsa@quicinc.com
>
> Changes in v6:
> - Fixed ordering of property-n and property-names in vreg_cam1_2p8 - Konrad
> - Moved vreg_cam1_2p8 defintion to monaco-evk.dts - Konrad
> - Removed description of pins with MCLK and Regulators function - Konrad
> - Added pin hardware description for MCLK, regulators in monaco.dtsi - Konrad
> - Link to v5:
> https://lore.kernel.org/all/20251114064541.446276-1-quic_vikramsa@quicinc.com
>
> Changes in v5:
> - Rename cciX_i2cY_* to cciX_Y_* to shorten the labels - Vladimir
> - Added description of pins with MCLK function - Vladimir
> - Link to v4:
> https://lore.kernel.org/all/20251015131303.2797800-1-quic_vikramsa@quicinc.com
>
> Changes in v4:
> - Remove the AXI source clock from the CCI node - Konrad
> - Updated the qcs8300-camss device tree binding.
> - Link to v3:
> https://lore.kernel.org/all/20250917130647.1701883-1-quic_vikramsa@quicinc.com
>
> Changes in v3:
> - Updated and Wrapped commit messages for [PATCH v2 1/3] and [PATCH v2 2/3] - Rob
> - Link to v2:
> https://lore.kernel.org/all/20250912141134.2799078-1-quic_vikramsa@quicinc.com
>
> Changes in v2:
> - Remove the patch that adds PHY supply documentation in the qcs8300 CAMSS.
> bindings. This change should be submitted together with the qcs8300 bindings patch.
> - Fix indentation and regulator node name - Krzysztof.
> - Update commit message as suggested - Dmitry.
> - Link to v1:
> https://lore.kernel.org/lkml/20250909114241.840842-1-quic_vikramsa@quicinc.com
>
> Used following tools for the sanity check of these changes.
> - make -j32 W=1
> - checkpatch.pl
> - make DT_CHECKER_FLAGS=-m W=1 DT_SCHEMA_FILES=i2c/qcom,i2c-cci.yaml dt_binding_check
> - make CHECK_DTBS=y W=1 DT_SCHEMA_FILES=i2c/qcom,i2c-cci.yaml
> - make DT_CHECKER_FLAGS=-m W=1 DT_SCHEMA_FILES=media/qcom,qcs8300-camss.yaml dt_binding_check
> - make CHECK_DTBS=y W=1 DT_SCHEMA_FILES=media/qcom,qcs8300-camss.yaml
>
> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
>
> Nihal Kumar Gupta (5):
> dt-bindings: i2c: qcom-cci: Document qcs8300 compatible
> arm64: dts: qcom: monaco: Add CCI definitions
> arm64: dts: qcom: monaco: Add camera MCLK pinctrl
> arm64: dts: qcom: monaco-evk: Add camera AVDD regulators
> arm64: dts: qcom: monaco-evk-camera: Add DT overlay
>
> .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 +
> arch/arm64/boot/dts/qcom/Makefile | 4 +
> .../dts/qcom/monaco-evk-camera-imx577.dtso | 66 ++++
> arch/arm64/boot/dts/qcom/monaco-evk.dts | 51 +++
> arch/arm64/boot/dts/qcom/monaco.dtsi | 324 ++++++++++++++++++
> 5 files changed, 447 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtso
>
> --
> 2.34.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20260121 (exact match)
Base: tags/next-20260121 (use --merge-base to override)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260121183142.1867199-1-quic_nihalkum@quicinc.com:
arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: cci@ac13000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: cci@ac14000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: cci@ac15000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk.dtb: cci@ac13000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk.dtb: cci@ac14000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk.dtb: cci@ac15000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtb: cci@ac13000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtb: cci@ac14000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtb: cci@ac15000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
^ permalink raw reply [flat|nested] 19+ messages in thread