* [PATCH] media: pci: intel: ivsc: select V4L2_FWNODE
@ 2023-09-27 7:21 Arnd Bergmann
2023-09-27 10:40 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2023-09-27 7:21 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Wentong Wu, Sakari Ailus
Cc: Arnd Bergmann, Hans Verkuil, Randy Dunlap, linux-media,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Some missing select statements were already added back, but I ran into
another one that is missing:
ERROR: modpost: "v4l2_fwnode_endpoint_free" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
ERROR: modpost: "v4l2_fwnode_endpoint_alloc_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
ERROR: modpost: "v4l2_fwnode_endpoint_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
Fixes: 29006e196a566 ("media: pci: intel: ivsc: Add CSI submodule")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/pci/intel/ivsc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/pci/intel/ivsc/Kconfig b/drivers/media/pci/intel/ivsc/Kconfig
index 0acea4678fc0d..6a2995b02d274 100644
--- a/drivers/media/pci/intel/ivsc/Kconfig
+++ b/drivers/media/pci/intel/ivsc/Kconfig
@@ -7,6 +7,7 @@ config INTEL_VSC
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_ASYNC
+ select V4L2_FWNODE
help
This adds support for Intel Visual Sensing Controller (IVSC).
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: pci: intel: ivsc: select V4L2_FWNODE
2023-09-27 7:21 [PATCH] media: pci: intel: ivsc: select V4L2_FWNODE Arnd Bergmann
@ 2023-09-27 10:40 ` Sakari Ailus
2023-09-27 11:32 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2023-09-27 10:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mauro Carvalho Chehab, Wentong Wu, Arnd Bergmann, Hans Verkuil,
Randy Dunlap, linux-media, linux-kernel
Hi Arnd,
On Wed, Sep 27, 2023 at 09:21:19AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Some missing select statements were already added back, but I ran into
> another one that is missing:
>
> ERROR: modpost: "v4l2_fwnode_endpoint_free" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
> ERROR: modpost: "v4l2_fwnode_endpoint_alloc_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
> ERROR: modpost: "v4l2_fwnode_endpoint_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
>
> Fixes: 29006e196a566 ("media: pci: intel: ivsc: Add CSI submodule")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/pci/intel/ivsc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/pci/intel/ivsc/Kconfig b/drivers/media/pci/intel/ivsc/Kconfig
> index 0acea4678fc0d..6a2995b02d274 100644
> --- a/drivers/media/pci/intel/ivsc/Kconfig
> +++ b/drivers/media/pci/intel/ivsc/Kconfig
> @@ -7,6 +7,7 @@ config INTEL_VSC
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_ASYNC
> + select V4L2_FWNODE
Thanks for the fix.
V4L2_FWNODE already implies V4L2_ASYNC so V4L2_ASYNC can be removed. I
somehow thought this only needed V4L2_ASYNC but that indeed is not the
case.
I'll just drop the line selecting V4L2_ASYNC above if that's fine.
> help
> This adds support for Intel Visual Sensing Controller (IVSC).
>
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: pci: intel: ivsc: select V4L2_FWNODE
2023-09-27 10:40 ` Sakari Ailus
@ 2023-09-27 11:32 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-09-27 11:32 UTC (permalink / raw)
To: Sakari Ailus, Arnd Bergmann
Cc: Mauro Carvalho Chehab, Wentong Wu, Hans Verkuil, Randy Dunlap,
linux-media, linux-kernel
On Wed, Sep 27, 2023, at 12:40, Sakari Ailus wrote:
>
> V4L2_FWNODE already implies V4L2_ASYNC so V4L2_ASYNC can be removed. I
> somehow thought this only needed V4L2_ASYNC but that indeed is not the
> case.
>
> I'll just drop the line selecting V4L2_ASYNC above if that's fine.
>
Sure, sounds good to me.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-27 11:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 7:21 [PATCH] media: pci: intel: ivsc: select V4L2_FWNODE Arnd Bergmann
2023-09-27 10:40 ` Sakari Ailus
2023-09-27 11:32 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).