From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC4EC4360C for ; Tue, 8 Oct 2019 17:30:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66552217D7 for ; Tue, 8 Oct 2019 17:30:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LakZLwH2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727409AbfJHRaU (ORCPT ); Tue, 8 Oct 2019 13:30:20 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:37677 "EHLO mail-wr1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725917AbfJHRaT (ORCPT ); Tue, 8 Oct 2019 13:30:19 -0400 Received: by mail-wr1-f45.google.com with SMTP id p14so19432205wro.4 for ; Tue, 08 Oct 2019 10:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=/NuJKLkWuKLCFRWYxxah4JzhJEy/G7dYYGpVfwZEoIQ=; b=LakZLwH24ALEljCcvw9fVkfD8yn6/ZPybmI5Ifv3PafJJTA+QCtNMcaPzEcOM8UoPD 9xXOgg9CQ+CjOyvGA4Hfao3MMpCF8qXx6d+aippmf713A63ZiXzhU5dZ3sYX6naTRruy imx5v+3pQG+Fx168WBdppvGvE14Ksr+N+048InFZ0CjfNn/EMbpqfy0ypoSPgLLiI4o2 PAikC84rae5CJ5xLijTw317XhhajfKYtQs1MlgfJUUwLmX/vnek7MAoRLQoWzIgnpa5h IfGmSoIYNowCNghVKJBEyQAXDt2TcehuDijv4LoNV/a1KXujfhQ80tOYxfeDWpxSx94s u64A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=/NuJKLkWuKLCFRWYxxah4JzhJEy/G7dYYGpVfwZEoIQ=; b=qRhWb6+83oRbf+n7tNcSux/GCl2GEtUFTByWeL0PiM9vQ4MpTG71Hp/6jWPo2Pt0k+ NHam54N07D5C7mbhPAbaXmOSkZJVgh8wXSkt5epUTqpxwli02kQDMKKE08GU2BJT6z1t HKyWsHZjFI973DyAUVRQDNm0ot+26pY3FQ/4Ox854Xdg6MwEac7tiWivDtQx5t2p7sLT t692SjOvaivAkf+2FoRGsraKopQIC0fv/WfcW6D7wAxauurkNwgcTLsqzPltVO3taEiq UxiKxj6jfLzIiCTlKYv3afyEGXVlYU4Qri9ORN26CRZkRLktryZQTsuuVr4jBKlTavHG YI/A== X-Gm-Message-State: APjAAAWEUE4qpDRIpfxoGr7S7LI1SibwTmGHYq+AhgLSJK+xb1Egudch DoFhFfnjpMJFDnPcpiO8raQP6Iwf X-Google-Smtp-Source: APXvYqwbzLGIoRm/5ZwAhxJshWjWmFMzjSASRqipKdeNZ1iJVMz4za+12ANTitv6N9Tq1PFM26Iu7Q== X-Received: by 2002:adf:ec02:: with SMTP id x2mr15473949wrn.145.1570555815213; Tue, 08 Oct 2019 10:30:15 -0700 (PDT) Received: from [172.30.88.213] (sjewanfw1-nat.mentorg.com. [139.181.7.34]) by smtp.gmail.com with ESMTPSA id c4sm23314352wru.31.2019.10.08.10.30.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Oct 2019 10:30:14 -0700 (PDT) Subject: Re: ADV7180 Capture with i.MX53 To: Ian Arkver , Tim Harvey , Fabio Estevam Cc: Philipp Zabel , linux-media , Nicolas Dufresne References: <8bcd8085-c1a1-0b6c-8470-cf77e5047a7a@gmail.com> From: Steve Longerbeam Message-ID: Date: Tue, 8 Oct 2019 10:30:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 10/8/19 10:20 AM, Ian Arkver wrote: > On 08/10/2019 18:14, Steve Longerbeam wrote: >> >> >> On 10/8/19 9:55 AM, Tim Harvey wrote: >>> On Tue, Oct 8, 2019 at 4:21 AM Fabio Estevam >>> wrote: >>>> On Mon, Oct 7, 2019 at 10:07 PM Fabio Estevam >>>> wrote: >>>> >>>>> So now I need to see if I can get Gstreamer to accept a pipeline >>>>> like: >>>>> >>>>> gst-lauch-1.0 v4l2src ! kmssink >>>> Ok, so now I decided use the hardware video deinterlacer: >>>> >>>> media-ctl -l "'adv7180 1-0021':0 -> 'ipu1_csi0':0[1]" >>>> media-ctl -l "'ipu1_csi0':1 -> 'ipu1_vdic':0[1]" >>>> media-ctl -l "'ipu1_vdic':2 -> 'ipu1_ic_prp':0[1]" >>>> media-ctl -l "'ipu1_ic_prp':2 -> 'ipu1_ic_prpvf':0[1]" >>>> media-ctl -l "'ipu1_ic_prpvf':1 -> 'ipu1_ic_prpvf capture':0[1]" >>>> >>>> media-ctl -V "'adv7180 1-0021':0 [fmt:UYVY2X8/720x480 >>>> field:alternate]" >>>> media-ctl -V "'ipu1_csi0':1 [fmt:AYUV32/720x480]" >>>> media-ctl -V "'ipu1_vdic':2 [fmt:AYUV32/720x480 field:none]" >>>> media-ctl -V "'ipu1_ic_prp':2 [fmt:AYUV32/720x480 field:none]" >>>> media-ctl -V "'ipu1_ic_prpvf':1 [fmt:AYUV32/720x480field:none]" >>>> >>>> And then Gstreamer can be launched: >>>> >>>> # gst-launch-1.0 v4l2src device=/dev/video2 ! kmssink --verbose >>>> Setting pipeline to PAUSED ... >>>> Pipeline is live and does not need PREROLL ... >>>> /GstPipeline:pipeline0/GstKMSSink:kmssink0: display-width = 800 >>>> /GstPipeline:pipeline0/GstKMSSink:kmssink0: display-height = 480 >>>> Setting pipeline to PLAYING ... >>>> New clock: GstSystemClock >>>> /GstPipeline:pipeline0/GstV4l2Src:v4l2src0.GstPad:src: caps = >>>> video/x-raw, format=(string)YUY2, width=(int)720, height=(int)480, >>>> framerate=(fraction)25/1, colorimetry=(string)bt601, >>>> interlace-mode=(string)progressive >>>> /GstPipeline:pipeline0/GstKMSSink:kmssink0.GstPad:sink: caps = >>>> video/x-raw, format=(string)YUY2, width=(int)720, height=(int)480, >>>> framerate=(fraction)25/1, colorimetry=(string)bt601, >>>> interlace-mode=(string)progressive >>>> >>> Fabio, >>> >>> Yes, you need to use the vdic to capture from adv7180 with gstreamer >>> as it can't handle alternate. >>> >>>> However the video looks like a broken old TV scrolling the image >>>> horizontally: >>>> https://www.dropbox.com/s/2yef8egn6s8z7ff/mx53_adv7180_capture.mp4?dl=0 >>>> >>>> >>> This would be because of the initial corrupt frames that this and many >>> other decoders produce while waiting for proper sync. I added >>> 'g_skip_frames' support in 9483a3f8e1b58ba1d7cd21687d8d0a63a015c36b >>> but I'm not sure how to get gstreamer to use it? >>> >>> I still carry around a patch from Steve for imx-csi that drops first >>> few frames from BT656 sources: >>> https://github.com/Gateworks/linux-imx6/commit/959fbd42ee6433f49ef4a04fb1abe8f8c78db5ad >>> >>> to deal with this. >> >> Yes, that's likely the issue, from a look at Fabio's video. The patch >> referenced by Tim hard-codes the number of frames to skip, instead of >> calling the adv7180's g_skip_frames op. I still don't have an answer >> as to how to call the adv7180 from the CSI subdev. > > Seems to me initial corrupt frames would produce a fixed offset of > some kind. A rolling video like that looks more like the number of > lines being captured is wrong. Nope, rolling video is one of the symptoms of initial corrupt frames, from my own experience. I don't really have an explanation for it, but IIRC the IPU will insert lines on its own to recover from an initial wrong # lines captured, to regain vertical sync. That should mean the rolling should eventually stop once vertical sync is re-established, but I've seen many instances where rolling video continues, and skipping the initial corrupt frames fixes it. Steve