Re: [PATCH v10 05/17] dt-bindings: media: Add bindings for ARM mali-c55

Dan Scally
2025-07-10T15:19:41Z

Hello Krzysztof

On 25/06/2025 10:08, Krzysztof Kozlowski wrote:
> On 25/06/2025 11:05, Krzysztof Kozlowski wrote:
>> On 24/06/2025 12:21, Daniel Scally wrote:
>>> Add the yaml binding for ARM's Mali-C55 Image Signal Processor.
>>>
>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> You changed the binding significantly - adding new properties (which do
>> not even follow DTS coding style).
>>
>> This invalidates the review. You cannot just keep growing it after you
>> received a review.
>>
> Although if it is conflicting with my earlier message that some earlier
> changes - reset properties - were trivial and review should be kept,
> then apologies. Adding new, custom, vendor properties is not trivial.
> Adding obvious existing properties usually is, although I understand why
> it could also be a reason to drop review. In any case sorry for
> confusion, but this needs re-review.

I'm about to post another version of this set, but I dropped the change adding the new property.  Am
I alright to keep the review tag? It's now identical to the reviewed version, but just wanted to
make totally sure :)

Thanks

Dan

>
> Best regards,
> Krzysztof