Re: [PATCH v10 05/17] dt-bindings: media: Add bindings for ARM mali-c55

Rob Herring
2025-06-25T03:27:05Z

On Tue, Jun 24, 2025 at 11:21:18AM +0100, Daniel Scally wrote:
> Add the yaml binding for ARM's Mali-C55 Image Signal Processor.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Acked-by: Nayden Kanchev <nayden.kanchev@arm.com>
> Co-developed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
> ---
> Changes in v10:
>
> - None
>
> Changes in v9:
>
> - Added the arm,inline_mode property to differentiate between inline and
> memory input configurations
>
> Changes in v8:
>
> - Added the video clock back in. Now that we have actual hardware it's
> clear that it's necessary.
> - Added reset lines
> - Dropped R-bs
>
> Changes in v7:
>
> - None
>
> Changes in v6:
>
> - None
>
> Changes in v5:
>
> - None
>
> Changes in v4:
>
> - Switched to port instead of ports
>
> Changes in v3:
>
> - Dropped the video clock as suggested by Laurent. I didn't retain it
> for the purposes of the refcount since this driver will call .s_stream()
> for the sensor driver which will refcount the clock anyway.
> - Clarified that the port is a parallel input port rather (Sakari)
>
> Changes in v2:
>
> - Added clocks information
> - Fixed the warnings raised by Rob
> ---
> .../devicetree/bindings/media/arm,mali-c55.yaml | 89 ++++++++++++++++++++++
> 1 file changed, 89 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/arm,mali-c55.yaml b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..539fa8163bd07cf8a80c361012400cbcc7d073eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/arm,mali-c55.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/arm,mali-c55.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM Mali-C55 Image Signal Processor
> +
> +maintainers:
> + - Daniel Scally <dan.scally@ideasonboard.com>
> + - Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> +
> +properties:
> + compatible:
> + const: arm,mali-c55
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: ISP Video Clock
> + - description: ISP AXI clock
> + - description: ISP AHB-lite clock
> +
> + clock-names:
> + items:
> + - const: vclk
> + - const: aclk
> + - const: hclk
> +
> + resets:
> + items:
> + - description: vclk domain reset
> + - description: aclk domain reset
> + - description: hclk domain reset
> +
> + reset-names:
> + items:
> + - const: vresetn
> + - const: aresetn
> + - const: hresetn
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Input parallel video bus
> +
> + properties:
> + endpoint:
> + $ref: /schemas/graph.yaml#/properties/endpoint
> +
> + arm,inline_mode:

arm,inline-mode

> + description:
> + The ISP can be either electrically connected to sensor and CSI-2 receiver
> + or driven through a DMA input device. This property declares the ISP as
> + being electrically connected to the source of image data.
> + type: boolean
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + mali_c55: isp@400000 {

Drop unused labels.

> + compatible = "arm,mali-c55";
> + reg = <0x400000 0x200000>;
> + clocks = <&clk 0>, <&clk 1>, <&clk 2>;
> + clock-names = "vclk", "aclk", "hclk";
> + resets = <&resets 0>, <&resets 1>, <&resets 2>;
> + reset-names = "vresetn", "aresetn", "hresetn";
> + interrupts = <0>;
> +
> + port {
> + isp_in: endpoint {
> + remote-endpoint = <&csi2_rx_out>;
> + };
> + };
> + };
> +...
>
> --
> 2.34.1
>