From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F4C91A680E for ; Sun, 21 Jun 2026 06:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782021674; cv=none; b=D3PqqfMPs/jugVi4S//QSnYf7r19g8vYZtOnybsHkgXhm/qDIB03p+c6Ku7T05jpJvy83sb1PDsdlXJC/P5c6uc3bKbjusa3PLB7P5FEQDm+IAVjkIXYfRnIilCqzxbM+E9hfspBvpKO8/TFtGE9Vwc1ntP296XQYrGTsGgxThs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782021674; c=relaxed/simple; bh=Ps4FYVhY/+AWPZL6Cgx+yY0Oak9eRrn0s+QgtMMDndc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I6LqqCFn+YDA4o9zcI9FdqD+hH/5DOhnUBFcfDAfwZ3JYHgZ1+AmX3jUqGtNM9WVh5TbhU48c2uuITPuCwrYWu7FJInLjS7T8Uww1Dy/tRiJBuS4GALAe+rYXjGMPH+4b8yMfbubuXne8MUWguU7psoyxrvcG7bm0QEqWMwj34U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bWAavCub; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QnWSIK1I; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bWAavCub"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QnWSIK1I" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65L5jATZ1012920 for ; Sun, 21 Jun 2026 06:01:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WfmmR4KR+FxAid9sd3QGFwzw4X7Tu5ccd/ACfHBvlSo=; b=bWAavCubaAeSbQ2B 5X7Tk45bwritVIUZ6q7ChKGUS5amfhJX7i6Jd3+U8KstjQVYB//B890waTbupy9b tJGRNDICPR1Jmflh+TmMNV29BxRzu7Cc+SFEay0RQthRnVPYESrrpI7WkU5VD143 wexfNLzPJ1ZnOnb5OMuuIkR5VKYO2anf62kK7rZAWbyQvF5FH3QEr+Vm42Q+MPG1 8okJYHbaGa4baOhiXL9wGya+HQK2q/qefMZ1x09nSEovfWnr1czKkIP5oN2215pS vJF2COzVkgD5GEGRKuUE12Bl+jL8bxINXTToZzgEPUkQFTGeZEl5+zA5C8N8CehX pcEM4A== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ewm58278d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 21 Jun 2026 06:01:11 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c860544c077so4752987a12.3 for ; Sat, 20 Jun 2026 23:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782021671; x=1782626471; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WfmmR4KR+FxAid9sd3QGFwzw4X7Tu5ccd/ACfHBvlSo=; b=QnWSIK1Ieh3z6sMm15nAIjkEnBshbx7p3MFclrQpGrch6/A1v45DcOqnPJYh3sa/mD gfvhs7XSbC5Fg53rItnmHSXgIqSUq9N0juHBMeHniREacli6aD3OXePsJ/R74HMt6IR+ U0Vt0asPCIHumqvdCrJhlAFoDZs7ZofVgngjybOkhIvW3VUGmZnTrUQSxcfUKIbNR8oe SOJF7ebOte/cZgGugnXPWZ8VohmqyRDEMzGLfRpb2enS8EG7C/68HpZwyWfeqIyOc+yN VMQCqcwaQn4hj/DDRDP/zODrRQwDOA43J5xd076Uo9Fb+tMGIhPysTbAfdiYiI1HT+Xx 6Uog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782021671; x=1782626471; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WfmmR4KR+FxAid9sd3QGFwzw4X7Tu5ccd/ACfHBvlSo=; b=mTpbCesNSC0vKdeXpagMRi/ZJGBU57UnWo2LmG1d9U3G0EW7hM2rTQd/HcGo7FN3Nw W61TFlVmPzq9Zler7uTlIgtyfXnjIQibWbjgcmhVfuV4EATlP64U0epy2Ri9BJSKZd8m 0cIXrssQITQXq0/KARvWPqweg+jEWFf5T1Tfq2jT8yBIg4ecN7NFm4l9LvHxd4f+7yDn zmCV9eY7+SGMHHeijD1CWjpb28KdCc8SnV9AC+oLQHRJQg2qGdAi4DUdyT6SsyW0gfNL 6N+QBbahUxd7vnLxCvmkdaGlEi3FINlgeSZeZZcflNviw67AJShx0E/wImDfhaTgu0xx hFPw== X-Forwarded-Encrypted: i=1; AFNElJ8wWW8hwQxvoxfHcXKCXLyAYXY4gRZSsjUHsUTrpE7H8Mv8rJFMw8XH64pCVJxfWHEQrQZzdCpmz9ERZQ==@vger.kernel.org X-Gm-Message-State: AOJu0YwUHXw2b/E4FztZbwk3gu5xtxraCgGDl4kYfCL1zOTdznoEMAOd Gsw3E/WrHX2mTjp5+6HJDSY2T1/j3t0CONjwN1dTn4v+KFdl9RxdNktXGnOMDbNyiJgdpR5uUss msTXTAC1vtCbMrG7hRtRBCQvH1095YIj9BsUxc2/P/Znz+M0Nvs1S0nOwb6QHDpPrlQ== X-Gm-Gg: AfdE7ckcql5vB6RIklyRx/RIDyrN1b+SsGTvB7s/qIUUUB5ZXe5WpIgZHzgSynSEjRC h6TnNrfMZESPwAEH6OQ0hSbaQ2Yt128ZsfakQVKAwIc5Jyywl+UobxDvqm6eE0xqCWJbUwMBJQU LVdaOiWCtys8JTdg3NGY1wiIOts77XGCgTYNo8QGdrHLr/RFN3GqdE/y7XbSovMBj0FMDyT0jGz D4VvVF/IBFsyHkIxW73M41rxcM/PQ82oEmjfqNhxrfjI40AeKt+tCHoDJ2+QJvEWcNmTn83KYlO hYa+X654ROMJ+1s+uuDYbTOR91RRwTxIhVOMeP7kcVFc8ys1plmuiPRjYUN94bhtecL929zN5eH UfiMVjEUy/k5/TNy0XIsWJRdRf1LyLVNAZ93COlqAmQ== X-Received: by 2002:a05:6a00:4385:b0:823:d2c:b156 with SMTP id d2e1a72fcca58-8455078c20dmr11621230b3a.5.1782021671036; Sat, 20 Jun 2026 23:01:11 -0700 (PDT) X-Received: by 2002:a05:6a00:4385:b0:823:d2c:b156 with SMTP id d2e1a72fcca58-8455078c20dmr11621188b3a.5.1782021670637; Sat, 20 Jun 2026 23:01:10 -0700 (PDT) Received: from [192.168.29.115] ([49.43.226.145]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564ecd779sm3823101b3a.53.2026.06.20.23.01.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jun 2026 23:01:10 -0700 (PDT) Message-ID: Date: Sun, 21 Jun 2026 11:30:59 +0530 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] arm64: dts: qcom: shikra: Add pin configuration for mclks To: Konrad Dybcio , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Andi Shyti , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Suresh Vankadara , Vikram Sharma References: <20260615-shikra-camss-review-v4-0-bcb51081735b@oss.qualcomm.com> <20260615-shikra-camss-review-v4-4-bcb51081735b@oss.qualcomm.com> <6e760884-87b1-4ec8-9ae1-e53901451b65@oss.qualcomm.com> Content-Language: en-US From: Nihal Kumar Gupta In-Reply-To: <6e760884-87b1-4ec8-9ae1-e53901451b65@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: vOG6HcLZsM9LBk9gnBU2jv83ZIZivmzm X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIxMDA1NyBTYWx0ZWRfX8M/rK6m4/gph IF2d6B2Y4Qm9eLBKvGE6Wt3ASXwi5y0z6BpmNZrGUMJrRNRWxOPCOJJ7YauXwEU2eGrhNottMv8 PoUnfWy05agxv1UbhoGKKWmrFtRnlIM= X-Proofpoint-GUID: vOG6HcLZsM9LBk9gnBU2jv83ZIZivmzm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIxMDA1NyBTYWx0ZWRfX3g/edoOpCv2d 4QRSWLODaCcQ49NXgyhagd0rnlJkwtwldPWMskpzDkueHvg7ZwKvs7jm8l4WHbC76L/krsJlB45 /IDI+kyhn3xQ20sU5Cx0dQy2gLwlPQ/wF4puajpv3iVR5b0OvTveDhwikSCI0pi6HqZWd6YSnPN iRPMeGM+MnDhG8tUVV532wRg8U0Y0y5e4YLOe1oUBTdV6RWn/WSmKhlbRAv3UumruDJeQGI7EAP KGwSwCN49B7PdZcl4sPCMhynorZMLrhX5CzQGnNCTqIB+9PP8p4Z7LlC0mfvpn3m5z7s0KHzOcI QuNnTO8zZoowxlm1sY8TRagWqlSHCBpFceYkWln8cEIIJnflKzu7R6qn7k211ZcgYcSAEgWAl4d VPIb6lBk4xEpSdh/3sNetyZ6bkM7o+dVVA+KbloZ+wUX3sfDD06X9ZM7tB3w9vDj90XaVhhS7wT pWyS1EFp634w3uFSE9A== X-Authority-Analysis: v=2.4 cv=FOQrAeos c=1 sm=1 tr=0 ts=6a377e27 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=Kt9MDo777XuedpO0AoDL9g==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=EEnOiY-A6ZLknHPuIi8A:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-20_04,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 adultscore=0 phishscore=0 spamscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606210057 On 19-06-2026 21:06, Konrad Dybcio wrote: >> + cam_mclk3_default: cam-mclk3-default-state { >> + pins = "gpio98"; >> + function = "cam_mclk"; >> + drive-strength = <2>; >> + bias-disable; >> + }; > Please try to keep the entries roughly sorted by the pin index > > For the entries themselves: > > Reviewed-by: Konrad Dybcio ACK, will fix pin ordering in v5 - qup_uart0 (gpio0/1/...) first, then cci_i2c(gpio36/37/41/42), then mclk0-3(gpio34/35/96/98). Could you please review the other DTS patches too? -- Regards, Nihal Kumar Gupta