Re: [PATCH 1/2] staging: atomisp: add menu entries to choose between ATOMISP_2400 and ATOMISP_2401.

Dan Carpenter
2017-09-11T21:09:15Z

No changelog. No Signed-off-by line. Without reading too carefully, or
trying to do a build, it looks like we're activating the menu items and
then fixing the build. It should be the other way around so that we
don't break git bisect. People are always doing randconfig and the
autobuilders detect breakage really quick.

On Mon, Sep 11, 2017 at 08:50:26PM +0200, Vincent Hervieux wrote:
> @@ -347,8 +347,16 @@ DEFINES := -DHRT_HW -DHRT_ISP_CSS_CUSTOM_HOST -DHRT_USE_VIR_ADDRS -D__HOST__
> #DEFINES += -DPUNIT_CAMERA_BUSY
> #DEFINES += -DUSE_KMEM_CACHE
>
> +ifeq ($(CONFIG_VIDEO_ATOMISP_ISP2400),y)
> +# Merrifield, Baytrail
> DEFINES += -DATOMISP_POSTFIX=\"css2400b0_v21\" -DISP2400B0
> DEFINES += -DSYSTEM_hive_isp_css_2400_system -DISP2400
> +endif
> +ifeq ($(CONFIG_VIDEO_ATOMISP_ISP2401),y)
> +# Anniedale (Merrifield+ / Moorefield), Cherrytrail
> +DEFINES += -DATOMISP_POSTFIX=\"css2401a0_v21\" -DISP2401A0
> +DEFINES += -DSYSTEM_hive_isp_css_2400_system -DISP2401 -DISP2401_NEW_INPUT_SYSTEM

These defines are a bit ugly. Eventually we will want to get rid of
these.

regards,
dan carpenter