From: Sean Young <sean@mess.org>
To: linux-media@vger.kernel.org, Matthias Reichl <hias@horus.com>
Cc: Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Alex Deryskyba <alex@codesnake.com>,
Jonas Karlman <jonas@kwiboo.se>,
linux-amlogic@lists.infradead.org
Subject: [PATCH v2 0/7] Improve latency of IR decoding
Date: Sun, 8 Apr 2018 22:19:35 +0100 [thread overview]
Message-ID: <cover.1523221902.git.sean@mess.org> (raw)
The current IR decoding is much too slow. Many IR protocols rely on
a trailing space for decoding (e.g. rc-6 needs to know when the bits
end). The trailing space is generated by the IR timeout, and if this
is longer than required, buttons can feel slow to respond.
The other issue is the keyup timer. IR has no concept of a keyup message,
this is implied by the absence of IR. So, minimising the timeout for
this makes buttons less "sticky"; the are released much quicker.
With these patches in place, using IR with the builtin decoders is much
improved and feels very snappy.
Changes since v1:
- lost more testing
- fixed various issues with mce decoder
- fixed mceusb so it can use better timeout too
Sean Young (7):
media: rc: set timeout to smallest value required by enabled protocols
media: rc: add ioctl to get the current timeout
media: rc: per-protocol repeat period and minimum keyup timer
media: rc: mce_kbd decoder: low timeout values cause double keydowns
media: rc: mce_kbd protocol encodes two scancodes
media: rc: mce_kbd decoder: fix stuck keys
media: rc: mceusb: allow the timeout to be configurable
Documentation/media/uapi/rc/lirc-func.rst | 1 +
.../media/uapi/rc/lirc-set-rec-timeout.rst | 14 +++--
drivers/media/cec/cec-core.c | 2 +-
drivers/media/rc/ir-imon-decoder.c | 1 +
drivers/media/rc/ir-jvc-decoder.c | 1 +
drivers/media/rc/ir-mce_kbd-decoder.c | 36 +++++++-----
drivers/media/rc/ir-nec-decoder.c | 1 +
drivers/media/rc/ir-rc5-decoder.c | 1 +
drivers/media/rc/ir-rc6-decoder.c | 1 +
drivers/media/rc/ir-sanyo-decoder.c | 1 +
drivers/media/rc/ir-sharp-decoder.c | 1 +
drivers/media/rc/ir-sony-decoder.c | 1 +
drivers/media/rc/ir-xmp-decoder.c | 1 +
drivers/media/rc/lirc_dev.c | 9 ++-
drivers/media/rc/mceusb.c | 22 +++++++
drivers/media/rc/rc-core-priv.h | 1 +
drivers/media/rc/rc-ir-raw.c | 31 +++++++++-
drivers/media/rc/rc-main.c | 68 +++++++++++-----------
include/uapi/linux/lirc.h | 6 ++
19 files changed, 144 insertions(+), 55 deletions(-)
--
2.14.3
next reply other threads:[~2018-04-08 21:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 21:19 Sean Young [this message]
2018-04-08 21:19 ` [PATCH v2 1/7] media: rc: set timeout to smallest value required by enabled protocols Sean Young
2018-04-08 21:19 ` [PATCH v2 2/7] media: rc: add ioctl to get the current timeout Sean Young
2018-04-08 21:19 ` [PATCH v2 3/7] media: rc: per-protocol repeat period and minimum keyup timer Sean Young
2018-04-08 21:19 ` [PATCH v2 4/7] media: rc: mce_kbd decoder: low timeout values cause double keydowns Sean Young
2018-04-08 21:19 ` [PATCH v2 5/7] media: rc: mce_kbd protocol encodes two scancodes Sean Young
2018-04-08 21:19 ` [PATCH v2 6/7] media: rc: mce_kbd decoder: fix stuck keys Sean Young
2018-04-08 21:19 ` [PATCH v2 7/7] media: rc: mceusb: allow the timeout to be configurable Sean Young
2018-04-17 19:14 ` Matthias Reichl
2018-04-18 11:24 ` Sean Young
2018-04-18 17:42 ` Matthias Reichl
2018-04-19 22:17 ` Matthias Reichl
2018-04-21 13:18 ` Matthias Reichl
2018-04-21 17:41 ` Matthias Reichl
2018-05-07 15:54 ` Matthias Reichl
2018-05-09 21:44 ` Sean Young
2018-05-10 11:01 ` Matthias Reichl
2018-05-13 11:34 ` Matthias Reichl
2018-04-10 17:53 ` [PATCH v2 0/7] Improve latency of IR decoding Matthias Reichl
2018-04-10 18:39 ` Sean Young
2018-04-10 19:24 ` Matthias Reichl
2018-04-12 22:02 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1523221902.git.sean@mess.org \
--to=sean@mess.org \
--cc=alex@codesnake.com \
--cc=carlo@caione.org \
--cc=hias@horus.com \
--cc=hkallweit1@gmail.com \
--cc=jonas@kwiboo.se \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).