From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: unlisted-recipients:; (no To-header on input)@bombadil.infradead.org
Cc: "Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Mauro Carvalho Chehab" <mchehab@infradead.org>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Steve Longerbeam" <slongerbeam@gmail.com>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Sebastian Reichel" <sre@kernel.org>
Subject: [PATCH 0/3] Coding style cleanups after the fwnode patchset
Date: Thu, 4 Oct 2018 18:13:45 -0400 [thread overview]
Message-ID: <cover.1538690587.git.mchehab+samsung@kernel.org> (raw)
The fwnode patchset added a several new warnings, as identified by
checkpatch.pl --strict.
Those are at the core stuff, and makes harder to review patches there.
The most irritating stuff there are functions like:
some_very_long_function_that_has_a_very_comprehensive_name(
...);
Functions ending with a "(" without arguments doesn't follow the
right coding style, and it is an heritage of the usage of "indent".
Ok, it sounds that the patches were actually trying to follow an existing
coding style inside it.
As we're about to close the media merge window, and the fwnode patches
already changed a lot of code there, before that becomes an habit to
follow its weird style, let's fix it.
After this series, all we have is the lack of SPDX inside the sources,
and some long lines (with is inevitable without renaming those kAPI
functions).
Btw, I was tempted to rename them, renaming functions like:
v4l2_async_notifier_parse_fwnode_endpoints_by_port
to something like:
v4l2_async_parse_fwnode_ep_by_port
or even:
v4l2_parse_fwnode_ep_by_port
with is probably good enough, but, as this is part of the kAPI, I
opted to keep it as-is - for now.
Mauro Carvalho Chehab (3):
media: v4l2-core: cleanup coding style at V4L2 async/fwnode
media: v4l2-fwnode: cleanup functions that parse endpoints
media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props()
call
drivers/media/v4l2-core/v4l2-async.c | 45 +++---
drivers/media/v4l2-core/v4l2-fwnode.c | 190 ++++++++++++++------------
include/media/v4l2-async.h | 12 +-
include/media/v4l2-fwnode.h | 45 +++---
include/media/v4l2-mediabus.h | 32 +++--
5 files changed, 177 insertions(+), 147 deletions(-)
--
2.17.1
next reply other threads:[~2018-10-05 5:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 22:13 Mauro Carvalho Chehab [this message]
2018-10-04 22:13 ` [PATCH 1/3] media: v4l2-core: cleanup coding style at V4L2 async/fwnode Mauro Carvalho Chehab
2018-10-05 7:55 ` Sakari Ailus
2018-10-05 10:12 ` Mauro Carvalho Chehab
2018-10-05 10:22 ` Sakari Ailus
2018-10-04 22:13 ` [PATCH 2/3] media: v4l2-fwnode: cleanup functions that parse endpoints Mauro Carvalho Chehab
2018-10-05 8:01 ` Sakari Ailus
2018-10-05 9:52 ` Mauro Carvalho Chehab
2018-10-05 10:08 ` Sakari Ailus
2018-10-05 10:33 ` Mauro Carvalho Chehab
2018-10-04 22:13 ` [PATCH 3/3] media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call Mauro Carvalho Chehab
2018-10-05 8:03 ` Sakari Ailus
2018-10-05 9:54 ` Mauro Carvalho Chehab
2018-10-05 10:06 ` Sakari Ailus
2018-10-05 10:31 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1538690587.git.mchehab+samsung@kernel.org \
--to=mchehab+samsung@kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
--cc=slongerbeam@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox