From: Deborah Brouwer <deborahbrouwer3563@gmail.com>
To: linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl, jaffe1@gmail.com,
Deborah Brouwer <deborahbrouwer3563@gmail.com>
Subject: [PATCH v4 0/2] cec: add tests for Give Deck Status message
Date: Thu, 3 Jun 2021 19:40:51 -0700 [thread overview]
Message-ID: <cover.1622773904.git.deborahbrouwer3563@gmail.com> (raw)
Changes since v3:
Patch 1/2:
- Remove the CEC Version checks and else block.
- Add comment explaining why it works for CEC 1.4.
Patch 2/2:
- Keep/add empty line between variable declarations and code.
- Remove restriction to playback or recording devices.
- Extract the deck status where it was previously missed.
- Extend comment to explain CEC_OP_STATUS_REQ_OFF test.
- In the invalid test, remove redundant testing.
Changes since v2:
Patch 1/2 cec-follower: emulate features for CEC versions < CEC 2.0
* I already sent this as a single patch, and I have not made
changes since then, I am just including it because now I
need it for Patch 2/2 to apply.
Patch 2/2 cec: add tests for Give Deck Status message
* Combine functions with same name "deck_ctl_give_status"
to avoid confusion about the naming but also to avoid
returning FAIL rather than using "fail_on_test" directly.
* Expand the "Invalid Operand" test so that it will also test a
follower running version < CEC 2.0.
* Change the invalid operand from 0xaa to 0 and add a test for
invalid operand "4", both just outside of the valid range.
* Expand the "Invalid Operand" test to catch the other reasons
for which a follower might Feature Abort (e.g. Unrecognized
Op).
Changes since v1:
* Remove unnecessary functions.
* Revise function for turning Give Deck Status reporting On/Off.
* Combine the Give Deck Status Reporting test into the first
Give Deck Status test.
Deborah Brouwer (2):
cec-follower: emulate features for CEC versions < CEC 2.0
cec: add tests for Give Deck Status message
utils/cec-compliance/cec-test.cpp | 72 ++++++++++++++++++++++-----
utils/cec-follower/cec-follower.cpp | 44 +++++++++-------
utils/cec-follower/cec-follower.h | 1 +
utils/cec-follower/cec-processing.cpp | 41 +++++++--------
utils/libcecutil/cec-info.cpp | 2 -
5 files changed, 104 insertions(+), 56 deletions(-)
--
2.17.1
next reply other threads:[~2021-06-04 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 2:40 Deborah Brouwer [this message]
2021-06-04 2:40 ` [PATCH v4 1/2] cec-follower: emulate features for CEC versions < CEC 2.0 Deborah Brouwer
2021-06-04 2:40 ` [PATCH v4 2/2] cec: add tests for Give Deck Status message Deborah Brouwer
2021-06-04 7:53 ` [PATCH v4 0/2] " Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1622773904.git.deborahbrouwer3563@gmail.com \
--to=deborahbrouwer3563@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=jaffe1@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox